Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge #3108 | bors[bot] | 2020-02-17 | 6 | -36/+536 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3108: Magic Completion for `impl Trait for` Associated Items r=matklad a=kdelorey # Summary This PR adds a set of magic completions to auto complete associated trait items (functions/consts/types). ![Associated Trait Impl](https://user-images.githubusercontent.com/2295721/74493144-d8f1af00-4e96-11ea-93a4-82725bf89646.gif) ## Notes Since the assist and completion share the same logic when figuring out the associated items that are missing, a shared utility was created in the `ra_assists::utils` module. Resolves #1046 As this is my first PR to the rust-analyzer project, I'm new to the codebase, feedback welcomed! Co-authored-by: Kevin DeLorey <[email protected]> | ||||
| * | Added module doc comment to explain the purpose of the completion. | Kevin DeLorey | 2020-02-15 | 1 | -1/+32 |
| | | |||||
| * | Fixed bug that allowed for completion in a nested method. | Kevin DeLorey | 2020-02-15 | 1 | -7/+36 |
| | | |||||
| * | Reordered the `use` items. | Kevin DeLorey | 2020-02-15 | 1 | -9/+8 |
| | | |||||
| * | Adjusted the completion lookups to filter by just the name. | Kevin DeLorey | 2020-02-14 | 1 | -29/+44 |
| | | |||||
| * | Completion now replaces whole fn/const/type def with snippet. | Kevin DeLorey | 2020-02-13 | 1 | -16/+31 |
| | | |||||
| * | Cheese const tests as they requre an ident before becoming a CONST_DEF. | Kevin DeLorey | 2020-02-13 | 1 | -28/+21 |
| | | |||||
| * | Started to refactor the trigger of the trait_impl completion. | Kevin DeLorey | 2020-02-13 | 1 | -33/+77 |
| | | |||||
| * | Formatting. | Kevin DeLorey | 2020-02-11 | 1 | -1/+3 |
| | | |||||
| * | Fixing minor suggestions and added module level documentation. | Kevin DeLorey | 2020-02-11 | 2 | -11/+7 |
| | | |||||
| * | Removed doc comments entirely from the changes. | Kevin DeLorey | 2020-02-11 | 2 | -41/+0 |
| | | |||||
| * | Formatted changes. | Kevin DeLorey | 2020-02-11 | 3 | -29/+23 |
| | | |||||
| * | Removed docs from private method. | Kevin DeLorey | 2020-02-11 | 1 | -8/+0 |
| | | |||||
| * | Fixed warning generated after refactoring. | Kevin DeLorey | 2020-02-11 | 1 | -1/+1 |
| | | |||||
| * | Updated the `add_missing_impl_members` to use the shared utility. | Kevin DeLorey | 2020-02-11 | 2 | -34/+15 |
| | | |||||
| * | Adjusted the hashset buckets to lump functions/consts together as their ↵ | Kevin DeLorey | 2020-02-11 | 1 | -9/+10 |
| | | | | | | | | names must be unique. | ||||
| * | Added tests to test associated types and consts. | Kevin DeLorey | 2020-02-11 | 1 | -0/+78 |
| | | |||||
| * | Added some documentation to the `complete_trait_impl` completion. | Kevin DeLorey | 2020-02-11 | 1 | -1/+48 |
| | | |||||
| * | Added associated const magic completion. | Kevin DeLorey | 2020-02-10 | 1 | -11/+53 |
| | | |||||
| * | Added a utility function that can be used to determine the missing impl items. | Kevin DeLorey | 2020-02-09 | 4 | -118/+95 |
| | | |||||
| * | Merge branch 'master' into kdelorey/complete-trait-impl | Kevin DeLorey | 2020-02-09 | 327 | -3117/+5756 |
| |\ | |||||
| * | | Added associated type completion. | Kevin DeLorey | 2020-02-08 | 1 | -3/+15 |
| | | | |||||
| * | | Cleaning up unessicary code that the Magic completion takes care of. | Kevin DeLorey | 2020-02-08 | 1 | -39/+8 |
| | | | |||||
| * | | Got the magic completion working. | Kevin DeLorey | 2020-02-08 | 2 | -41/+16 |
| | | | |||||
| * | | Update completion kind to Magic in the unit tests. | Kevin DeLorey | 2020-02-08 | 1 | -2/+2 |
| | | | |||||
| * | | Add detection for a user already starting a fn impl and still providing ↵ | Kevin DeLorey | 2020-02-05 | 2 | -38/+157 |
| | | | | | | | | | | | | completion. | ||||
| * | | Already implemented fn will no longer be suggested for trait implementations. | Kevin DeLorey | 2020-01-29 | 2 | -17/+131 |
| | | | |||||
| * | | Renamed the trait completion mod. | Kevin DeLorey | 2020-01-23 | 2 | -3/+3 |
| | | | |||||
| * | | Added basic support for completing `fn` for trait impl. | Kevin DeLorey | 2020-01-23 | 3 | -0/+116 |
| | | | |||||
* | | | Merge #3181 | bors[bot] | 2020-02-17 | 4 | -0/+6 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3181: Add ability to pass additional arguments to rustfmt. r=matklad a=Leonqn relates to #2848 Co-authored-by: Ilya Titkov <[email protected]> | ||||
| * | | | Add arguments to rustfmt | Ilya Titkov | 2020-02-17 | 4 | -0/+6 |
| | | | | |||||
* | | | | Merge #3153 | bors[bot] | 2020-02-17 | 5 | -33/+100 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3153: When a single test is run, do not run others with overlapping names r=matklad a=SomeoneToIgnore Co-authored-by: Kirill Bulatov <[email protected]> | ||||
| * | | | | Fix a slow test | Kirill Bulatov | 2020-02-16 | 1 | -1/+1 |
| | | | | | |||||
| * | | | | Simplify module retrieval | Kirill Bulatov | 2020-02-16 | 1 | -7/+5 |
| | | | | | |||||
| * | | | | If possible, use --exact flag when running tests | Kirill Bulatov | 2020-02-14 | 4 | -32/+101 |
| | | | | | |||||
* | | | | | Merge #3179 | bors[bot] | 2020-02-17 | 4 | -80/+130 |
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3179: Introduce AsMacroCall trait r=matklad a=edwin0cheng This PR introduce `AsMacroCall` trait to help convert `ast::MacroCall` to `MacroCallId`. The main goal here is to centralize various conversions to single place and make implementing eager macro calls without further ado. ```rust pub trait AsMacroCall { fn as_call_id( &self, db: &(impl db::DefDatabase + AstDatabase), resolver: impl Fn(path::ModPath) -> Option<MacroDefId>, ) -> Option<MacroCallId>; } ``` Co-authored-by: Edwin Cheng <[email protected]> | ||||
| * | | | | Introduce AsMacroCall trait | Edwin Cheng | 2020-02-17 | 4 | -80/+130 |
| | | | | | |||||
* | | | | | 1-based columns | Aleksey Kladov | 2020-02-16 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | Support goto def in bences | Aleksey Kladov | 2020-02-16 | 2 | -13/+29 |
| | | | | | |||||
* | | | | | Refactor arg parsing | Aleksey Kladov | 2020-02-16 | 1 | -11/+8 |
| | | | | | |||||
* | | | | | Refactor position parsing | Aleksey Kladov | 2020-02-16 | 2 | -19/+28 |
| | | | | | |||||
* | | | | | Enable profiling for bench | Aleksey Kladov | 2020-02-16 | 3 | -6/+10 |
| | | | | | |||||
* | | | | | Add module colors to css | Aleksey Kladov | 2020-02-16 | 3 | -0/+3 |
| | | | | | |||||
* | | | | | Fix coercion of &T to itself | Florian Diebold | 2020-02-16 | 2 | -0/+24 |
|/ / / / | | | | | | | | | | | | | | | | | The autoderef coercion logic did not handle matching placeholders. This led to some type mismatches. | ||||
* | | | | Merge #3157 | bors[bot] | 2020-02-15 | 4 | -14/+96 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3157: Extend analysis-stats a bit r=matklad a=flodiebold This adds some tools helpful when debugging nondeterminism in analysis-stats: - a `--randomize` option that analyses everything in random order - a `-vv` option that prints even more detail Also add a debug log if Chalk fuel is exhausted (which would be a source of nondeterminism, but didn't happen in my tests). I found one source of nondeterminism (rust-lang/chalk#331), but there are still other cases remaining. Co-authored-by: Florian Diebold <[email protected]> | ||||
| * | | | | Extend analysis-stats a bit | Florian Diebold | 2020-02-15 | 4 | -14/+96 |
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds some tools helpful when debugging nondeterminism in analysis-stats: - a `--randomize` option that analyses everything in random order - a `-vv` option that prints even more detail Also add a debug log if Chalk fuel is exhausted (which would be a source of nondeterminism, but didn't happen in my tests). I found one source of nondeterminism (rust-lang/chalk#331), but there are still other cases remaining. | ||||
* / / / | Remove extra dep | Aleksey Kladov | 2020-02-15 | 1 | -1/+0 |
|/ / / | |||||
* | | | Bump crate resolution limit for large projects | Benjamin Brittain | 2020-02-14 | 1 | -1/+1 |
| | | | | | | | | | | | | Change-Id: Ie0221e5bcfd1779cd5e241f96b4489e5bd3854c1 | ||||
* | | | Merge #3147 | bors[bot] | 2020-02-14 | 3 | -0/+42 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3147: Check that impl self type matches up with expected self type in path mode r=matklad a=flodiebold Fixes #3144. Co-authored-by: Florian Diebold <[email protected]> | ||||
| * | | | Check that impl self type matches up with expected self type in path mode | Florian Diebold | 2020-02-14 | 3 | -0/+42 |
| | | | | | | | | | | | | | | | | Fixes #3144. |