aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Don't filter code suggestions on ApplicabilityChristopher Serr2021-02-011-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've noticed that there are various suggestions that rust-analyzer seems to filter out, even if they make sense. Here's an example of where it seems like there should be a suggestion, but there isn't: ![https://i.imgur.com/wsjM6iz.png](https://i.imgur.com/wsjM6iz.png) It turns out that this specific suggestion is not considered `MachineApplicable`, which are the only suggestions that rust-analyzer accepts. However if you read the documentation for `MachineApplicable`, https://github.com/rust-lang/rust/blob/b3897e3d1302391ed02efbac1dce8073646b8173/compiler/rustc_lint_defs/src/lib.rs#L27-L29 then you realize that these are specifically only those suggestions that rust-analyzer could even automatically apply (in some distant future, behind some setting or so). Other suggestions that may have some semantic impact do not use `MachineApplicable`. So all other suggestions are still intended to be suggested to the user, just not automatically applied without the user being consulted. https://github.com/rust-lang/rust/blob/b3897e3d1302391ed02efbac1dce8073646b8173/compiler/rustc_lint_defs/src/lib.rs#L22-L24 So with that in mind, rust-analyzer should almost definitely not filter out `MaybeIncorrect` (which honestly is named horribly, it just means that it's a semantic change, not just a syntactical one). Then there's `HasPlaceholders` which basically is just another semantic one, but with placeholders. The user will have to make some adjustments, but the suggestion still is perfectly valid. rust-analyzer could probably detect those placeholders and put proper "tab through" markers there for the IDE, but that's not necessary for now. Then the last one is `Unspecified` which is so unknown that I don't even know how to judge it, meaning that the suggestion should probably also just be suggested to the user and then they can decide. So with all that in mind, I'm proposing to get rid of the check for Applicability entirely.
* Shortcut `block_def_map` if there's no inner itemsJonas Schievink2021-02-011-2/+4
| | | | | This previously didn't work, but apparently only because of the wonky test setup
* Use body lowering for block_def_map testsJonas Schievink2021-02-013-68/+117
| | | | Removes the hacky and buggy custom lowering code
* Use block_def_map in body loweringJonas Schievink2021-02-016-26/+40
|
* Merge #7503bors[bot]2021-01-312-1/+25
|\ | | | | | | | | | | | | | | 7503: Return inner attributes of outline mod declarations in `attrs_query` r=jonas-schievink a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * Return inner attributes of outline mod declarations in `attrs_query`Lukas Wirth2021-01-312-1/+25
| |
* | Honor #![macro_use] in mod source filesLukas Wirth2021-01-312-8/+23
|/
* Merge #7500bors[bot]2021-01-301-2/+19
|\ | | | | | | | | | | | | | | | | | | 7500: Fix ast::String::value not properly escaping in some cases r=Veykril a=Veykril Fixes #7496 bors r+ Co-authored-by: Lukas Wirth <[email protected]>
| * Fix ast::String::value not properly escaping in some casesLukas Wirth2021-01-301-2/+19
| |
* | Merge #7483bors[bot]2021-01-305-27/+59
|\ \ | |/ |/| | | | | | | | | | | 7483: Classify function calls as functions when shadowed by types r=matklad a=Veykril Fixes #7479 Co-authored-by: Lukas Wirth <[email protected]>
| * Prefer ValueNS when resolving hir path for PathExpressionsLukas Wirth2021-01-291-14/+31
| |
| * Classify function calls as functions when shadowed by typesLukas Wirth2021-01-285-16/+31
| |
* | Merge #7494bors[bot]2021-01-304-74/+71
|\ \ | | | | | | | | | | | | | | | | | | | | | 7494: Simpilfy mbe parsing r=edwin0cheng a=edwin0cheng bors r+ Co-authored-by: Edwin Cheng <[email protected]>
| * | Simpilfy mbe parsingEdwin Cheng2021-01-304-74/+71
| | |
* | | Add --print-config-schema to helpLaurențiu Nicola2021-01-291-0/+2
|/ /
* | Simplify mbe match error.Edwin Cheng2021-01-296-210/+180
| | | | | | | | Handle parse error in rule parsing instead of match in mbe
* | Rename mbe_expander for consistencyEdwin Cheng2021-01-294-5/+5
| |
* | Forbid flyimport completions in use statementsKirill Bulatov2021-01-281-1/+22
| |
* | Fix incorrect `FileId` and remove broken shortcutJonas Schievink2021-01-282-16/+9
| | | | | | | | | | Apparently we were using the crate's root file instead of the file containing the block.
* | Merge #7482bors[bot]2021-01-281-0/+63
|\ \ | | | | | | | | | | | | | | | | | | | | | 7482: block_def_map: add a few macro tests r=jonas-schievink a=jonas-schievink bors r+ Co-authored-by: Jonas Schievink <[email protected]>
| * | block_def_map: add a few macro testsJonas Schievink2021-01-281-0/+63
| | |
* | | Merge #7412bors[bot]2021-01-2811-199/+397
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7412: Async loading for outdir and proc-macro r=maklad a=edwin0cheng cc #7328 ![Peek 2021-01-24 02-04](https://user-images.githubusercontent.com/11014119/105610083-8f208100-5de8-11eb-8e96-c2d4e349b352.gif) [Edit] ~~Finding a way to know when the workspace and build data are loaded...~~ [Edit 2] Not perfect solution, but seem to work now. Co-authored-by: Edwin Cheng <[email protected]>
| * | bug fixEdwin Cheng2021-01-281-1/+1
| | |
| * | Async Loading outdir and proc-macroEdwin Cheng2021-01-2811-199/+397
| |/
* | Update `original_module` when ascending `DefMap`sJonas Schievink2021-01-281-2/+5
| |
* | ItemTree: Treat items in `MacroStmts` as top-levelJonas Schievink2021-01-282-4/+32
|/
* Simplify heavy testsAleksey Kladov2021-01-281-18/+14
| | | | | | Progress notifications are edge triggered, while status is level triggered. This makes it a hared to misuse signal for the readiness of the server.
* Make logger-based debugging more pleasantAleksey Kladov2021-01-283-4/+19
|
* Use RA_LOG in testsAleksey Kladov2021-01-281-1/+1
|
* Easier to debug timeouts in testsAleksey Kladov2021-01-281-12/+22
|
* Enable fill_match_arms in macrosLukas Wirth2021-01-271-3/+35
|
* Fix legacy macro resolution in block expressionsJonas Schievink2021-01-272-1/+15
|
* Merge #7451bors[bot]2021-01-273-12/+24
|\ | | | | | | | | | | | | | | 7451: rust-analyzer.files.excludeDirs r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Add config option to ignore directoriesAleksey Kladov2021-01-263-6/+22
| |
| * Allow non-absolute paths to rust sourceAleksey Kladov2021-01-261-6/+2
| |
* | Merge #7465bors[bot]2021-01-271-1/+19
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 7465: Only hide parameter hints for path, field and methodcall expressions r=SomeoneToIgnore a=Veykril Doing this check for other expressions makes little sense to me. Fixes #7458 Co-authored-by: Lukas Wirth <[email protected]>
| * | Only hide parameter hints for path, field and methodcall expressionsLukas Wirth2021-01-271-1/+19
| | |
* | | Export `CARGO` for proc. macrosJonas Schievink2021-01-271-1/+4
| | |
* | | Bump depsLaurențiu Nicola2021-01-272-4/+4
| | |
* | | Squelch a warningAleksey Kladov2021-01-271-0/+1
| | |
* | | add more countsAleksey Kladov2021-01-274-2/+8
| | |
* | | Merge #7457bors[bot]2021-01-263-21/+83
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7457: Add no-buffering file logging and wait for a debugger option. r=vsrs a=vsrs Adds two command line flags: `--no-buffering` and `--wait-dbg`. Not sure if someone else needs this, but personally I found both flags extremely useful trying to figure out why RA does not work with Visual Studio. Or better to say why Visual Studio does not work with RA. Co-authored-by: vsrs <[email protected]>
| * | | Apply suggestions.vsrs2021-01-262-11/+17
| | | |
| * | | cargo fmtvsrs2021-01-261-1/+1
| | | |
| * | | Add debug only guard for the --wait-dbg flagvsrs2021-01-262-1/+4
| | | |
| * | | Add RA_WAIT_DBG and docsvsrs2021-01-252-1/+2
| | | |
| * | | Add the ability to wait for a debugger.vsrs2021-01-252-7/+45
| | | |
| * | | Add stderr flushvsrs2021-01-252-8/+16
| | | |
| * | | Add --no-buffering flag for the file logging.vsrs2021-01-253-15/+21
| | | |
* | | | Make always-assert crate reusableAleksey Kladov2021-01-268-71/+11
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-14 17:57:52 +0000