aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Switch to ungrammar from ast_srcAleksey Kladov2020-07-294-2205/+825
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The primary advantage of ungrammar is that it (eventually) allows one to describe concrete syntax tree structure -- with alternatives and specific sequence of tokens & nodes. That should be re-usable for: * generate `make` calls * Rust reference * Hypothetical parser's evented API We loose doc comments for the time being unfortunately. I don't think we should add support for doc comments to ungrammar -- they'll make grammar file hard to read. We might supply docs as out-of band info, or maybe just via a reference, but we'll think about that once things are no longer in flux
* | | Dead codeAleksey Kladov2020-07-291-41/+0
| | |
* | | Remove dead codeAleksey Kladov2020-07-291-3/+1
| | |
* | | Remove dead codeAleksey Kladov2020-07-291-46/+0
|/ /
* | Merge #5564bors[bot]2020-07-299-53/+182
|\ \ | | | | | | | | | | | | | | | | | | | | | 5564: SSR: Restrict to current selection if any r=davidlattimore a=davidlattimore The selection is also used to avoid unnecessary work, but only to the file level. Further restricting unnecessary work is left for later. Co-authored-by: David Lattimore <[email protected]>
| * | SSR: Rename position and lookup_context to resolve_contextDavid Lattimore2020-07-292-6/+6
| | |
| * | SSR: Restrict to current selection if anyDavid Lattimore2020-07-298-48/+177
| | | | | | | | | | | | | | | The selection is also used to avoid unnecessary work, but only to the file level. Further restricting unnecessary work is left for later.
* | | Merge #5565bors[bot]2020-07-292-1/+62
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5565: SSR: Don't mix non-path-based rules with path-based r=matklad a=davidlattimore If any rules contain paths, then we reject any rules that don't contain paths. Allowing a mix leads to strange semantics, since the path-based rules only match things where the path refers to semantically the same thing, whereas the non-path-based rules could match anything. Specifically, if we have a rule like `foo ==>> bar` we only want to match the `foo` that is in the current scope, not any `foo`. However "foo" can be parsed as a pattern (BIND_PAT -> NAME -> IDENT). Allowing such a rule through would result in renaming everything called `foo` to `bar`. It'd also be slow, since without a path, we'd have to use the slow-scan search mechanism. Co-authored-by: David Lattimore <[email protected]>
| * | | SSR: Don't mix non-path-based rules with path-basedDavid Lattimore2020-07-292-1/+62
| |/ / | | | | | | | | | If any rules contain paths, then we reject any rules that don't contain paths. Allowing a mix leads to strange semantics, since the path-based rules only match things where the path refers to semantically the same thing, whereas the non-path-based rules could match anything. Specifically, if we have a rule like `foo ==>> bar` we only want to match the `foo` that is in the current scope, not any `foo`. However "foo" can be parsed as a pattern (BIND_PAT -> NAME -> IDENT). Allowing such a rule through would result in renaming everything called `foo` to `bar`. It'd also be slow, since without a path, we'd have to use the slow-scan search mechanism.
* / / Allow running more tests at onceKirill Bulatov2020-07-281-54/+110
|/ /
* | Fix nameref parsingAleksey Kladov2020-07-283-7/+8
| |
* | Bump test timeout for macsAleksey Kladov2020-07-281-1/+2
| |
* | Merge #5547bors[bot]2020-07-271-1/+13
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5547: Fold multiline fn parameters r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fold multiline fn parametersAleksey Kladov2020-07-271-1/+13
| | |
* | | Merge #5532bors[bot]2020-07-272-23/+31
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 5532: Restore line index optimization for edits r=matklad a=lnicola Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | Restore line index micro-optimizationLaurențiu Nicola2020-07-252-23/+31
| | |
* | | Merge #5539bors[bot]2020-07-273-27/+103
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5539: SSR: Fix path resolution of locals in current scope r=matklad a=davidlattimore Co-authored-by: David Lattimore <[email protected]>
| * | | SSR: Fix for path resolution of localsDavid Lattimore2020-07-262-0/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It seems that Semantics::scope, if given a statement node, won't resolve locals that were defined in the current scope, only in parent scopes. Not sure if this is intended / expected behavior, but we work around it for now by finding another nearby node to use as the scope (e.g. the expression inside the EXPR_STMT).
| * | | SSR: Move more resolution-related code into the resolving moduleDavid Lattimore2020-07-262-27/+38
| | | |
* | | | add completion for rustc lintsEmil Gardström2020-07-271-4/+278
|/ / /
* | | Report type errors in metricsAleksey Kladov2020-07-261-0/+4
| | |
* | | Add one more testAleksey Kladov2020-07-261-21/+50
|/ /
* | Add rustc-perf to metricsAleksey Kladov2020-07-254-20/+54
| |
* | Merge #5520bors[bot]2020-07-244-7/+26
|\ \ | | | | | | | | | | | | | | | | | | | | | 5520: Add DocumentData to represent in-memory document with LSP info r=matklad a=kjeremy At the moment this only holds document version information but in the near-future it will hold other things like semantic token delta info. Co-authored-by: kjeremy <[email protected]>
| * | Add DocumentData to represent in-memory document with LSP infokjeremy2020-07-244-7/+26
| | |
* | | Merge #5524bors[bot]2020-07-249-98/+149
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5524: Allow opting out of experimental diagnostics like MismatchedArgCount r=matklad a=jonas-schievink Closes https://github.com/rust-analyzer/rust-analyzer/issues/5448 Closes https://github.com/rust-analyzer/rust-analyzer/issues/5419 Co-authored-by: Jonas Schievink <[email protected]>
| * | | Only display experimental diagnostics when enabledJonas Schievink2020-07-245-11/+22
| | | |
| * | | Add toggle for experimental diagnosticsJonas Schievink2020-07-241-0/+4
| | | |
| * | | Mark MismatchedArgCount as experimentalJonas Schievink2020-07-241-0/+3
| | | |
| * | | Allow filtering diagnosticsJonas Schievink2020-07-241-3/+22
| | | |
| * | | Add a builder for DiagnosticSinkJonas Schievink2020-07-244-88/+102
| | | |
* | | | Revert "Merge #5516"Aleksey Kladov2020-07-242-43/+32
| | | | | | | | | | | | | | | | | | | | This reverts commit 5b13c2411f025a16495f5828afe2def6e9220102, reversing changes made to c3defe2532ba6ffd12a13bcbc8fdeda037665efc.
* | | | Merge #5522bors[bot]2020-07-241-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5522: Increace tracing-tree version from 0.1.3 to 0.1.4 r=kjeremy a=vandenheuvel Co-authored-by: Bram van den Heuvel <[email protected]>
| * | | | Increace tracing-tree version from 0.1.3 to 0.1.4Bram van den Heuvel2020-07-241-1/+1
| | |_|/ | |/| |
* | | | Merge #5516bors[bot]2020-07-242-32/+43
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5516: Better LSP conformance r=matklad a=vsrs At the moment rust-analyzer does not fully conform to the LSP. This PR fixes two LSP related issues: 1) rust-analyzer sends predefined server capabilities and does not take supplied client capabilities in mind. 2) rust-analyzer uses dynamic `textDocument/didSave` registration even if the client does not support it. Co-authored-by: vsrs <[email protected]>
| * | | Always send experimental & semantic server caps.vsrs2020-07-241-72/+36
| | | |
| * | | Code formattingvsrs2020-07-241-1/+2
| | | |
| * | | Send dynamic didSave only if the client supportsvsrs2020-07-242-32/+42
| | | |
| * | | Prepare server capabilities based on client ones.vsrs2020-07-241-36/+72
| |/ /
* | | Merge #5518bors[bot]2020-07-2416-389/+1411
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5518: Use resolved paths in SSR rules r=matklad a=davidlattimore The main user-visible changes are: * SSR now matches paths based on whether they resolve to the same thing instead of whether they're written the same. * So `foo()` won't match `foo()` if it's a different function `foo()`, but will match `bar::foo()` if it's the same `foo`. * Paths in the replacement will now be rendered with appropriate qualification for their context. * For example `foo::Bar` will render as just `Bar` inside the module `foo`, but might render as `baz::foo::Bar` from elsewhere. * This means that all paths in the search pattern and replacement template must be able to be resolved. * It now also matters where you invoke SSR from, since paths are resolved relative to wherever that is. * Search now uses find-uses on paths to locate places to try matching. This means that when a path is present in the pattern, search will generally be pretty fast. * Function calls can now match method calls again, but this time only if they resolve to the same function. Co-authored-by: David Lattimore <[email protected]>
| * | SSR: Allow function calls to match method callsDavid Lattimore2020-07-246-25/+169
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This differs from how this used to work before I removed it in that: a) It's only one direction. Function calls in the pattern can match method calls in the code, but not the other way around. b) We now check that the function call in the pattern resolves to the same function as the method call in the code. The lack of (b) was the reason I felt the need to remove the feature before.
| * | SSR: Disable matching within use declarationsDavid Lattimore2020-07-242-1/+51
| | | | | | | | | | | | | | | It currently does the wrong thing when the use declaration contains braces.
| * | SSR: Use Definition::find_usages to speed up matching.David Lattimore2020-07-245-24/+157
| | | | | | | | | | | | When the search pattern contains a path, this substantially speeds up finding matches, especially if the path references a private item.
| * | SSR: Match paths based on what they resolve toDavid Lattimore2020-07-249-61/+482
| | | | | | | | | | | | Also render template paths appropriately for their context.
| * | SSR: Pass current file position through to SSR code.David Lattimore2020-07-248-28/+69
| | | | | | | | | | | | In a subsequent commit, it will be used for resolving paths.
| * | SSR: Refactor to not rely on recursive search for nesting of matchesDavid Lattimore2020-07-244-27/+120
| | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, submatches were handled simply by searching in placeholders for more matches. That only works if we search all nodes in the tree recursively. In a subsequent commit, I intend to make search not always be recursive recursive. This commit prepares for that by finding all matches, even if they overlap, then nesting them and removing overlapping matches.
| * | SSR: Add a couple of tests for non-recursive searchDavid Lattimore2020-07-241-0/+33
| | | | | | | | | | | | | | | These tests already pass, however once we switch to non-recursive search, it'd be easy for these tests to not pass.
| * | SSR tests: Define all paths needed for templatesDavid Lattimore2020-07-241-26/+76
| | | | | | | | | | | | | | | | | | | | | In a later commit, paths in templates will be resolved. This allows us to render the path with appropriate qualifiers for its context. Here we prepare for that change by updating existing tests where I'd previously not bothered to define the items that the template referred to.
| * | Move iteration over all files into the SSR crateDavid Lattimore2020-07-246-89/+92
| | | | | | | | | | | | The methods `edits_for_file` and `find_matches_in_file` are replaced with just `edits` and `matches`. This simplifies the API a bit, but more importantly it makes it possible in a subsequent commit for SSR to decide to not search all files.
| * | SSR: Move search code into a submoduleDavid Lattimore2020-07-242-48/+56
| | | | | | | | | | | | | | | | | | Also renamed find_matches to slow_scan_node to reflect that it's a slow way to do things. Actually the name came from a later commit and probably makes more sense once there's an alternative.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 19:44:58 +0000