aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
| * Wrap `BuiltinType` in code modelJonas Schievink2021-02-119-28/+56
| |
| |
| \
*-. \ Merge #7638 #7648bors[bot]2021-02-123-4/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7638: libloading 0.7 r=kjeremy a=kjeremy See https://docs.rs/libloading/0.7.0/libloading/changelog/r0_7_0/index.html 7648: fix nightly warning `legacy_derive_helpers` r=lnicola a=peddermaster2 With a recent nightly (e.g. 2021-02-10) a warning comes up. This PR reorders the attributes to fix the warning. See https://github.com/rust-lang/rust/issues/79202 Co-authored-by: kjeremy <[email protected]> Co-authored-by: Peter Wischer <[email protected]>
| | * | fix nightly warning `legacy_derive_helpers`Peter Wischer2021-02-121-1/+1
| |/ / |/| | | | | | | | see https://github.com/rust-lang/rust/issues/79202
* | | Pin Rust to 1.49.0 on CIJonas Schievink2021-02-124-10/+12
| |/ |/|
| * libloading 0.7kjeremy2021-02-112-3/+3
|/ | | | See https://docs.rs/libloading/0.7.0/libloading/changelog/r0_7_0/index.html
* Add test for #1165Jonas Schievink2021-02-101-0/+29
| | | | Closes #1165
* Slightly expand testJonas Schievink2021-02-101-0/+3
|
* Add more testsJonas Schievink2021-02-102-8/+84
|
* Put the old resolver backJonas Schievink2021-02-101-3/+8
|
* Update fixed testsJonas Schievink2021-02-103-18/+21
|
* infer: update resolver when descending into blockJonas Schievink2021-02-102-16/+39
|
* Merge #7617bors[bot]2021-02-109-68/+603
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7617: Add getter/setter assists r=Veykril a=yoshuawuyts This patch makes progress towards the design outlined in https://github.com/rust-analyzer/rust-analyzer/issues/5943, and includes a small refactor which closes https://github.com/rust-analyzer/rust-analyzer/issues/7607. All together this patch does 4 things: - Adds a `generate_getter` assist. - Adds a `generate_getter_mut` assist. - Adds a `generate_setter` assist. - Moves the `generate_impl_text` function from `generate_new` into `utils` (which closes #7607). ## Design Notes I've chosen to follow the [Rust API guidelines on getters](https://rust-lang.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter) as closely as possible. This deliberately leaves "builder pattern"-style setters out of scope. Also, similar to https://github.com/rust-analyzer/rust-analyzer/pull/7570 this assist generates doc comments. I think this should work well in most cases, and for the few where it doesn't it's probably easily edited. This makes it slightly less correct than the #7570 implementation, but I think this is still useful enough to include for many of the same reasons. The reason why this PR contains 3 assists, rather than 1, is because each of them is so similar to the others that it felt more noisy to do them separately than all at once. The amount of code added does not necessarily reflect that, but hope that still makes sense. ## Examples **Input** ```rust struct Person { name: String, // <- cursor on "name" } ``` **generate getter** ```rust struct Person { name: String, } impl Person { /// Get a reference to the person's name. fn name(&self) -> &String { &self.name } } ``` **generate mut getter** ```rust struct Person { name: String, } impl Person { /// Get a mutable reference to the person's name. fn name_mut(&mut self) -> &mut String { &mut self.name } } ``` **generate setter** ```rust struct Person { name: String, } impl Person { /// Set the person's name. fn set_name(&mut self, name: String) { self.name = name; } } ``` Co-authored-by: Yoshua Wuyts <[email protected]>
| * Add getter/setter assistsYoshua Wuyts2021-02-099-68/+603
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Finish implementing `generate_setter` assists Make `generate_impl_text` util generic generate getter methods Fix getter / setter naming It's now in-line with the Rust API naming guidelines: https://rust-lang.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter apply clippy Improve examples
| |
| \
*-. \ Merge #7591 #7622bors[bot]2021-02-102-6/+34
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7591: Fix/no floating promises r=matklad a=sahandevs closes #3515 - added `@typescript-eslint/no-floating-promises: error` rule - changed `"no-console": ["error"]` to `"no-console": ["error", { allow: ["warn", "error"] }]` (we at least log the error messages of the floating promises) - fixed lint/compile errors 7622: Resolve TupleStructPat in SourceAnalyzer::resolve_path r=Veykril a=Veykril Closes #7594 bors r+ Co-authored-by: Sahandevs <[email protected]> Co-authored-by: Lukas Wirth <[email protected]>
| | * | Resolve TupleStructPat in SourceAnalyzer::resolve_pathLukas Wirth2021-02-102-6/+34
| | | |
* | | | Add #[track_caller] to assist testsYoshua Wuyts2021-02-091-0/+4
| |/ / |/| |
* | | Show qualified variant pattern completionsLukas Wirth2021-02-094-45/+95
| | |
* | | Merge #7616bors[bot]2021-02-093-6/+74
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7616: Show `Self` pattern and Self-prefixed enum-variant completions r=Veykril a=Veykril ![jDfQXNE0qZ](https://user-images.githubusercontent.com/3757771/107413514-1ff99b00-6b11-11eb-88b3-126cd106b514.gif) ![JpogVIgloq](https://user-images.githubusercontent.com/3757771/107413519-212ac800-6b11-11eb-8282-51115468dccc.gif) Variant pattern completions are to be done still. Closes #6549, at least that should address all that's left from that issue from what I can see. Co-authored-by: Lukas Wirth <[email protected]>
| * | | Show Self pattern completions for Adts if inside implsLukas Wirth2021-02-093-6/+40
| | | |
| * | | Show completions for enum variant with self prefix if inside implLukas Wirth2021-02-091-1/+35
| | | |
* | | | Merge #7615bors[bot]2021-02-093-8/+66
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7615: Add parsing benchmark r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Add parsing benchmarkAleksey Kladov2021-02-093-8/+66
| | | | |
* | | | | Merge #7614bors[bot]2021-02-097-237/+333
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7614: Unleash inner item resolution to users r=jonas-schievink a=jonas-schievink ![Peek 2021-02-09 17-30](https://user-images.githubusercontent.com/1786438/107394800-8627f300-6afc-11eb-8662-ed07226bc58f.gif) Co-authored-by: Jonas Schievink <[email protected]>
| * | | | Remove unneeded returnJonas Schievink2021-02-091-2/+2
| | | | |
| * | | | Remove `pub`Jonas Schievink2021-02-091-2/+2
| | | | |
| * | | | Use `block_def_map` in `Resolver`Jonas Schievink2021-02-091-118/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This required a few changes to not bail out immediately if a `ModuleScope` doesn't resolve a path. The `LocalItemsScope` hack is now removed.
| * | | | Teach `find_path` about inner itemsJonas Schievink2021-02-091-10/+91
| | | | |
| * | | | Add another block def map testJonas Schievink2021-02-091-0/+27
| | | | |
| * | | | Make `with_ancestor_maps` publicJonas Schievink2021-02-091-1/+1
| | | | |
| * | | | Add `TestDB::module_at_position`Jonas Schievink2021-02-092-104/+99
| | | | |
| * | | | Add expression scopes for blocksJonas Schievink2021-02-091-4/+18
| |/ / /
* / / / Infra for "unit" benchmarkingAleksey Kladov2021-02-096-4001/+96
|/ / /
* | | restore accidentally deleted testAleksey Kladov2021-02-091-0/+13
| | |
* | | More precise navigation to parentAleksey Kladov2021-02-093-10/+13
| | |
* | | Cleanup testsAleksey Kladov2021-02-093-55/+53
| | |
* | | Cleanup testAleksey Kladov2021-02-091-20/+21
| | |
* | | Modernize testsAleksey Kladov2021-02-091-197/+169
| |/ |/|
* | Merge #7602bors[bot]2021-02-082-11/+38
|\ \ | | | | | | | | | | | | | | | | | | | | | 7602: Check for dyn impls in method resolution r=flodiebold a=Veykril Fixes #6777 Co-authored-by: Lukas Wirth <[email protected]>
| * | Check for dyn impls in method resolutionLukas Wirth2021-02-082-11/+38
| | |
* | | Update crateskjeremy2021-02-083-6/+7
| | | | | | | | | | | | Pulls in https://github.com/rust-lang/chalk/pull/682
* | | Consolidate `fn load_cargo(…)` parameters into `struct LoadCargoConfig ↵Vincent Esche2021-02-085-31/+70
| | | | | | | | | | | | { … }`
* | | Add `config: &CargoConfig` parameter to `fn load_cargo(…)`Vincent Esche2021-02-085-7/+18
| | |
* | | chore: swap order of placeholdersGowri2021-02-081-1/+1
| | |
* | | ci: update relevant test case expected valuesGowri2021-02-071-0/+7
| | |
* | | fix: add for keyword in completion #7588Gowri2021-02-071-0/+1
| |/ |/|
* | AdtDef -> AdtAleksey Kladov2021-02-078-38/+38
| |
* | Add a semantic token type for char literalspetr-tik2021-02-052-1/+3
|/ | | | | The LSP spec doesn't recognise character literals, so had to extend the suported types to our own custom type
* Test `super` resolution tooJonas Schievink2021-02-051-0/+2
|
* Fix resolution of `self` module within blocksJonas Schievink2021-02-052-7/+17
|
* Merge #7572bors[bot]2021-02-053-29/+30
|\ | | | | | | | | | | | | | | | | | | | | | | 7572: Add `find_or_create_impl_block` to assist utils r=matklad a=yoshuawuyts This is another continuation of https://github.com/rust-analyzer/rust-analyzer/pull/7562, introducing a small util to either find an `impl` block, or create a new one if none exists. I copied this code from the `generate_new` assist into https://github.com/rust-analyzer/rust-analyzer/pull/7562, and this unifies both into a helper. It doesn't feel super polished in its current state, but my hope is that this is enough of a starting point that it can be expanded on later. For example something that would be useful would be a flag which either returns the index of the start of the block, or the end of the block. Anyway, I hope this is useful. Thanks! Co-authored-by: Yoshua Wuyts <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-02 18:43:00 +0000