aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Merge #6666bors[bot]2020-11-291-17/+39
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6666: Support 'go to definition' for self r=jonas-schievink a=Veykril Also reverts #6660, instead of showing the type it now works like it does for names by returning the declaration we are already on. This for example enables VSCode to show all references(#6665) when executing `go to definition` on the declaration. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | Support 'go to definition' for selfLukas Wirth2020-11-291-17/+39
| | |_|/ / | |/| | |
* | | | | Merge #6664bors[bot]2020-11-281-3/+43
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6664: Show type of self param on hover r=jonas-schievink a=Veykril Show the type of `self` when hovering the token in a `SelfParam`. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Show type of self param on hoverLukas Wirth2020-11-281-3/+43
| | | | |
* | | | | Merge #6660bors[bot]2020-11-281-6/+36
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6660: Support "go to definition" for SelfParams r=jonas-schievink a=Veykril Fixes #6657 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | | Support goto definition for ADT-SelfParamsLukas Wirth2020-11-281-6/+36
| |/ / / /
* | | | | Merge #6659bors[bot]2020-11-281-2/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6659: Explain how we get precise spans for diagnostics. r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | | Explain how we get precise spans for diagnostics.Aleksey Kladov2020-11-281-2/+7
| | | | | |
* | | | | | Merge #6645bors[bot]2020-11-289-9/+198
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6645: Publish diagnostics for macro expansion errors r=matklad a=jonas-schievink This adds 2 new diagnostics, emitted during name resolution: * `unresolved-proc-macro`, a weak warning that is emitted when a proc macro is supposed to be expanded, but was not provided by the build system. This usually means that proc macro support is turned off, but may also indicate setup issues when using rust-project.json. Being a weak warning, this should help set expectations when users see it, while not being too obstructive. We do not yet emit this for attribute macros though, just custom derives and `!` macros. * `macro-error`, which is emitted when any macro (procedural or `macro_rules!`) fails to expand due to some error. This is an error-level diagnostic, but currently still marked as experimental, because there might be spurious errors and this hasn't been tested too well. This does not yet emit diagnostics when expansion in item bodies fails, just for module-level macros. Known bug: The "proc macro not found" diagnostic points at the whole item for custom derives, it should just point at the macro's name in the `#[derive]` list, but I haven't found an easy way to do that. Screenshots: ![screenshot-2020-11-26-19:54:14](https://user-images.githubusercontent.com/1786438/100385782-f8bc2300-3023-11eb-9f27-e8f8ce9d6114.png) ![screenshot-2020-11-26-19:55:39](https://user-images.githubusercontent.com/1786438/100385784-f954b980-3023-11eb-9617-ac2eb0a0a9dc.png) Co-authored-by: Jonas Schievink <[email protected]>
| * | | | | More accurately place proc-macro diagnosticJonas Schievink2020-11-273-8/+48
| | | | | |
| * | | | | Publish diagnostics for macro expansion errorsJonas Schievink2020-11-277-7/+154
| | | | | |
| * | | | | Add dedicated error for "proc macro not found"Jonas Schievink2020-11-272-1/+3
| |/ / / /
* | | | | Merge #6650bors[bot]2020-11-2829-302/+304
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6650: Make completion and assists module independent r=matklad a=SomeoneToIgnore A follow-up of https://github.com/rust-analyzer/rust-analyzer/pull/6553#discussion_r524402907 Move the common code for both assists and completion modules into a separate crate. Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | | Move the helpers into ide_dbKirill Bulatov2020-11-2826-53/+28
| | | | | |
| * | | | | Rustdocs fixesKirill Bulatov2020-11-272-2/+4
| | | | | |
| * | | | | Group import data in a structKirill Bulatov2020-11-275-52/+49
| | | | | |
| * | | | | Extract the import code into the shared moduleKirill Bulatov2020-11-2729-253/+281
| | | | | |
* | | | | | Coalesce flycheck eventsJonas Schievink2020-11-271-45/+59
| | | | | |
* | | | | | Downgrade "failed to load" error to warningJonas Schievink2020-11-271-1/+1
| | | | | |
* | | | | | Add/Fix macro expansion profilingJonas Schievink2020-11-271-2/+4
|/ / / / /
* | | | | Fix the profiling stringKirill Bulatov2020-11-271-1/+1
| | | | | | | | | | | | | | | Co-authored-by: LaurenČ›iu Nicola <[email protected]>
* | | | | Profile completions betterKirill Bulatov2020-11-278-0/+21
|/ / / /
* | | | Merge #6648bors[bot]2020-11-271-9/+18
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6648: Avoid allocation in ast::String::value if the string needs no unescaping r=lnicola a=Veykril Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Avoid allocation in ast::String::value if the string needs no unescapingLukas Wirth2020-11-271-9/+18
| | |_|/ | |/| |
* | | | Merge #6586bors[bot]2020-11-271-8/+16
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6586: Don't call a closure a function in the infer_function_return_type assist label r=lnicola a=Veykril `Add this function's return type` becomes `Add this closure's return type` for closures. This makes it more obvious that we are indeed planning on modifying the closure and not its containing function. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Don't call a closure function in infer_function_return_type labelLukas Wirth2020-11-171-8/+16
| | | | |
* | | | | Don't use raw identifiersLukas Wirth2020-11-261-2/+2
| |/ / / |/| | |
* | | | Merge #6635bors[bot]2020-11-262-14/+46
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6635: Complete struct in irrefutable let r=Veykril a=Veykril Fixes #6210 Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Complete struct in irrefutable letLukas Wirth2020-11-262-14/+46
| | | | |
* | | | | Simplify error formattingLaurențiu Nicola2020-11-262-8/+5
| | | | |
* | | | | Remove unused importLaurențiu Nicola2020-11-261-1/+1
| | | | |
* | | | | Don't store `SyntaxNodePtr` in `CrateDefMap`Jonas Schievink2020-11-262-8/+7
| | | | | | | | | | | | | | | | | | | | It is volatile across reparses and makes incrementality worse.
* | | | | Test def map invalidation with #[cfg] below changeJonas Schievink2020-11-261-0/+6
| | | | |
* | | | | Implement `Display` for macro expansion errorsJonas Schievink2020-11-262-0/+27
| | | | |
* | | | | Use `ExpandResult` instead of `MacroResult`Jonas Schievink2020-11-265-56/+42
| | | | | | | | | | | | | | | | | | | | `MacroResult` is redundant
* | | | | Use named fields in `ExpandResult`Jonas Schievink2020-11-265-29/+39
| | | | |
* | | | | Publish diagnostics on file openJonas Schievink2020-11-261-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | Diagnostics are sometimes only showing up when typing. This should fix that.
| | | | |
| \ \ \ \
*-. \ \ \ \ Merge #6614 #6632bors[bot]2020-11-267-35/+117
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6614: Improve autoimports on completion speed r=matklad a=SomeoneToIgnore Presumably closes https://github.com/rust-analyzer/rust-analyzer/issues/6594 May help https://github.com/rust-analyzer/rust-analyzer/issues/6612 * Ignore modules eaferly * Do less completion string rendering 6632: Pin cargo_metadata r=matklad a=kjeremy See: https://github.com/oli-obk/cargo_metadata/pull/142#issuecomment-733653275 Co-authored-by: Kirill Bulatov <[email protected]> Co-authored-by: kjeremy <[email protected]>
| | * | | | | Pin cargo_metadatakjeremy2020-11-253-3/+3
| |/ / / / / |/| | | | |
| * | | | | Improve autoimports on completion speedKirill Bulatov2020-11-244-32/+114
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Ignore modules eaferly * Do less completion string rendering
* | | | | | Document experimental completionsKirill Bulatov2020-11-241-0/+7
| | | | | |
* | | | | | Gate autoimports begind experimental completions flagKirill Bulatov2020-11-243-1/+8
| | | | | |
* | | | | | Rename `parse_macro` to `parse_macro_expansion`Jonas Schievink2020-11-246-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | This does not parse macros, it expands a macro and parses the *result*
* | | | | | hir_expand::db: reduce fn visibilityJonas Schievink2020-11-241-15/+9
| | | | | |
* | | | | | Remove fixed FIXME, propagate errors betterJonas Schievink2020-11-241-6/+2
| |/ / / / |/| | | |
* | | | | hir_expand: propagate expansion errorsJonas Schievink2020-11-244-46/+91
| | | | |
* | | | | Check structs for match exhaustivenessLukas Wirth2020-11-241-31/+120
| | | | |
* | | | | Add middle ellipsis missing arm textLukas Wirth2020-11-241-0/+14
| | | | |
* | | | | Handle ellipsis in tuple patterns in match exhaustiveness checkingLukas Wirth2020-11-241-42/+41
| | | | |
* | | | | Merge #6618bors[bot]2020-11-242-12/+129
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 6618: Properly infer tuple patterns when encountering ellipsis r=Veykril a=Veykril We basically just split the subpatterns into two halves when the ellipsis is present and then offset the latter half to account for the ignored bindings. Fixes #6616 Co-authored-by: Lukas Wirth <[email protected]>