aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* internal: prepare to move rename to base_dbAleksey Kladov2021-06-141-41/+40
| | | | | | | | | | It's better to handle magical cases upper in the stack, because it allows for better re-use of the general implementation below. So, we pull the `self` case up here. The end goal is to put `Definition::rename` to the `ide_db`, because it's a generally re-usable functionality useful for different ide features, alongside with the search which is already there.
* Merge #9263bors[bot]2021-06-141-41/+119
|\ | | | | | | | | | | | | | | | | 9263: fix: don't use display-related functionality where semantics matters r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * fix: don't use display-related functionality where semantics mattersAleksey Kladov2021-06-141-41/+119
| | | | | | | | | | | | | | NavigationTarget is strictly a UI-level thing -- it describes where the cursor should be placed when the user presses goto definition. It doesn't make any semantic guaratees about rage and focus range and, as such, is not suitable for driving renames.
* | Don't keep a trailing self token in import paths after unmerge_useLukas Wirth2021-06-141-1/+15
|/
* Merge #9260bors[bot]2021-06-1431-36/+36
|\ | | | | | | | | | | | | | | 9260: tree-wide: make rustdoc links spiky so they are clickable r=matklad a=lf- Rustdoc was complaining about these while I was running with --document-private-items and I figure they should be fixed. Co-authored-by: Jade <[email protected]>
| * tree-wide: make rustdoc links spiky so they are clickableJade2021-06-1431-36/+36
| |
* | internal: diagnostic code is mandatoryAleksey Kladov2021-06-133-29/+17
| |
* | minor: dead codeAleksey Kladov2021-06-132-50/+34
| |
* | internal: kill diagnostic sinkAleksey Kladov2021-06-134-170/+19
| |
* | internal: use cov-mark rather than bailing out diagnosticAleksey Kladov2021-06-135-108/+62
| |
* | internal: refactor missing match arms diagnosticsAleksey Kladov2021-06-134-930/+935
| |
* | internal: remove DiagnosticWithFix infraAleksey Kladov2021-06-134-585/+534
| |
* | internal: refactor incorrect case diagnosticsAleksey Kladov2021-06-136-79/+49
| |
* | minorAleksey Kladov2021-06-132-38/+38
| |
* | internal: refactor find_map diagnosticAleksey Kladov2021-06-136-193/+192
| |
* | minorAleksey Kladov2021-06-133-44/+34
| |
* | internal: refactor missing or or some diagnosticAleksey Kladov2021-06-135-58/+44
| |
* | internal: refactor remove this semicolon diagnosticsAleksey Kladov2021-06-138-83/+71
| |
* | internal: refactor mismatched args count diagnosticAleksey Kladov2021-06-134-280/+279
| |
* | internal: refactor missing unsafe diagnosticAleksey Kladov2021-06-134-107/+106
| |
* | internal: refactor BreakOutsideOfLoop diagnosticAleksey Kladov2021-06-134-32/+36
| |
* | internal: refactor NoSuchField diagnosticAleksey Kladov2021-06-135-314/+300
| |
* | internal: refactor unimplemented builtin macro diagnosticAleksey Kladov2021-06-134-31/+33
| |
* | minor: simplifyAleksey Kladov2021-06-136-35/+18
| |
* | internal: check diagnostics in all files and not just the first oneAleksey Kladov2021-06-136-50/+84
| |
* | Merge #9249bors[bot]2021-06-1311-562/+398
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 9249: internal: remove def-level diagnostics tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: remove def-level diagnostics testsAleksey Kladov2021-06-133-171/+21
| | |
| * | internal: refactor macro errorAleksey Kladov2021-06-137-198/+178
| | |
| * | internal: refactor unresolved proc macro diagnosticAleksey Kladov2021-06-135-61/+59
| | |
| * | internal: refactor inactive code diagnosticsAleksey Kladov2021-06-136-133/+141
| | |
* | | Merge #9248bors[bot]2021-06-137-186/+220
|\| | | | | | | | | | | | | | | | | | | | | | | | | | 9248: internal: refactor unresolved macro call diagnostic r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: refactor unresolved macro call diagnosticAleksey Kladov2021-06-135-95/+94
| | |
| * | internal: refactor unresolved import diagnosticAleksey Kladov2021-06-136-92/+127
| | |
* | | Merge #9247bors[bot]2021-06-135-54/+60
|\| | | | | | | | | | | | | | | | | | | | | | | | | | 9247: internal: refactor unresolved extern crate diagnostic r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: refactor unresolved extern crate diagnosticAleksey Kladov2021-06-135-54/+60
| | |
* | | Merge #9246bors[bot]2021-06-138-401/+342
|\| | | | | | | | | | | | | | | | | | | | | | | | | | 9246: internal: unified missing fields diagnostic r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: unified missing fields diagnosticAleksey Kladov2021-06-135-142/+94
| | |
| * | internal: move missing_fields diagnosticsAleksey Kladov2021-06-136-109/+98
| | |
* | | Merge #9245bors[bot]2021-06-136-82/+119
|\| | | | | | | | | | | | | | | | | | | | | | | | | | 9245: internal: start new diagnostics API r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | internal: start new diagnostics APIAleksey Kladov2021-06-136-82/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the moment, this moves only a single diagnostic, but the idea is reafactor the rest to use the same pattern. We are going to have a single file per diagnostic. This file will define diagnostics code, rendering range and fixes, if any. It'll also have all of the tests. This is similar to how we deal with assists. After we refactor all diagnostics to follow this pattern, we'll probably move them to a new `ide_diagnostics` crate. Not that we intentionally want to test all diagnostics on this layer, despite the fact that they are generally emitted in the guts on the compiler. Diagnostics care to much about the end presentation details/fixes to be worth-while "unit" testing. So, we'll unit-test only the primary output of compilation process (types and name res tables), and will use integrated UI tests for diagnostics.
* | | Merge #9244bors[bot]2021-06-135-36/+154
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 9244: feat: Make block-local trait impls work r=flodiebold a=flodiebold As long as either the trait or the implementing type are defined in the same block. CC #8961 Co-authored-by: Florian Diebold <[email protected]>
| * | Make block-local trait impls workFlorian Diebold2021-06-135-36/+154
| | | | | | | | | | | | | | | As long as either the trait or the implementing type are defined in the same block.
* | | internal: check that coverage marks are always pairedAleksey Kladov2021-06-132-5/+6
| | |
* | | minor: put a mark backAleksey Kladov2021-06-132-0/+2
|/ /
* | Merge #9242bors[bot]2021-06-13131-395/+366
|\ \ | | | | | | | | | | | | | | | | | | | | | 9242: Clippy r=matklad a=Maan2003 Best viewed commit wise Co-authored-by: Maan2003 <[email protected]>
| * | cargo fmtMaan20032021-06-139-61/+38
| | |
| * | clippy::redundant_field_namesMaan20032021-06-136-7/+7
| | |
| * | clippy::manual_str_repeatMaan20032021-06-132-3/+3
| | |
| * | clippy::useless_returnMaan20032021-06-1310-15/+15
| | |
| * | clippy::redundant_closureMaan20032021-06-1312-17/+17
| | |