aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Merge #8717bors[bot]2021-05-317-806/+2769
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 8717: Update match checking algorithm r=iDawer a=iDawer I've recently got interest in the match checking to extend the current algo to support reporting witnesses of non-exhaustiveness. It appears the algo is outdated from rustc's implementation. I decided to rewrite it based on the latest rustc's version. It is a diff-based port to ra codebase. That means you can diff-compare these files to rustc. I'm striving to keep minimal ra-related changes in the algo to make it easier to backport future changes from the upstream. Based on upstream algorithm of version rust-lang/rust 1.52.0-nightly (25c15cdbe 2021-04-22) https://github.com/rust-lang/rust/blob/25c15cdbe/compiler/rustc_mir_build/src/thir/pattern/usefulness.rs The goal of this PR is to cover the current `missing-match-arm` diagnostic. What is remaining to do: - [x] Error handling. The errors that are unrelated to match checking will be handled before the check. Just like how it made in rustc. - [x] Lowering `hir_def::expr::Pat` to `hir_ty::diagnostics::match_check::Pat`. rustc's match checking works on top of `rustc_mir_build::thir::Pat`, which is lowered from `hir::Pat` and carries some extra semantics used by the check. All unrelated checks are done there. RA could use this to rule out running the check on unimplemented cases (`Pat::ConstBlock`, etc). - [x] ~~Proper~~Loose typecheck of match arm patterns (https://github.com/rust-analyzer/rust-analyzer/pull/8840, https://github.com/rust-analyzer/rust-analyzer/pull/8875). - [x] Tests from `hir_ty::diagnostics::match_check::tests`. - [x] Clean up `todo`s - [x] Test run on real repos https://github.com/rust-analyzer/rust-analyzer/pull/8717#issuecomment-847120265. Co-authored-by: Dawer <[email protected]>
| * Expand fixme commentsDawer2021-05-314-3/+9
| |
| * fix: panic on extra fields in a patternDawer2021-05-311-0/+25
| |
| * Correct binding pattern's type; handle invalid records.Dawer2021-05-311-5/+55
| |
| * Take substitutions into account.Dawer2021-05-313-14/+33
| |
| * eprint panic contextDawer2021-05-313-14/+36
| |
| * minor: doc comment pat_utilDawer2021-05-311-0/+4
| |
| * Test match guards, reference patternsDawer2021-05-311-0/+51
| |
| * Box field detection; test #[non-exhaustive] attributeDawer2021-05-313-10/+52
| |
| * Better tests: check if match checking bails out.Dawer2021-05-312-1/+69
| |
| * Replace the old match checking algorithmDawer2021-05-317-1927/+311
| |
| * Include old testsDawer2021-05-311-69/+597
| |
| * Don't panic on a pattern of unresolved ADT variant.Dawer2021-05-312-50/+14
| |
| * Clean up, more docs.Dawer2021-05-315-105/+384
| |
| * Check pattern types.Dawer2021-05-313-30/+85
| |
| * Expand binding patterns.Dawer2021-05-312-6/+110
| |
| * Fix visibility warningsDawer2021-05-313-12/+12
| |
| * Lower binding patternDawer2021-05-312-9/+28
| |
| * Lower bool literalsDawer2021-05-312-13/+29
| |
| * Treat ctor of unhandled type as non-exhaustive.Dawer2021-05-312-4/+24
| |
| * Lower Pat::PathDawer2021-05-311-0/+18
| |
| * Do not do match check if lowering failed.Dawer2021-05-311-2/+19
| |
| * Fix panics on pattern_arena.borrow with ugly cloningDawer2021-05-312-16/+15
| |
| * Basic lowering hir_def::exrp::Pat -> typed HIR.Dawer2021-05-315-164/+387
| | | | | | | | Pattern arena is broken
| * Handle unordered fields in struct patternsDawer2021-05-311-2/+12
| |
| * Complete field replacingDawer2021-05-311-2/+7
| |
| * Support bool literal patternsDawer2021-05-312-9/+182
| |
| * Check enum patternsDawer2021-05-313-6/+124
| |
| * Build wildcard witnesses instead of panickingDawer2021-05-311-8/+8
| |
| * Implement struct ctor applicationDawer2021-05-315-69/+121
| |
| * Add remaining Constructor variantsDawer2021-05-311-14/+56
| |
| * Complete usefulness::SubPatSet implDawer2021-05-311-3/+71
| |
| * List useless patterns in a useful match armDawer2021-05-311-9/+58
| |
| * Remove unneeded indirection on PatCtxtDawer2021-05-313-24/+24
| |
| * Enable generation of non-exhaustiveness witnessesDawer2021-05-313-13/+76
| |
| * Update match checking.Dawer2021-05-316-1/+1471
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fn is_useful , more skeletons Specify a lifetime on pattern references impl PatStack fill impl Matrix PatStack::pop_head_constructor Index-based approach struct PatCtxt fields construction fn Fields::wildcards split wildcard fn Constructor::is_covered_by_any(..) fn Matrix::specialize_constructor(..) impl Usefulness Initial work on witness construction Reorganize files Replace match checking diagnostic Handle types of expanded patterns unit match checking go brrr
* | hir_ty: use correct receiver_ty in method resolutioncynecx2021-05-313-12/+82
|/
* Merge #9088bors[bot]2021-05-311-1/+0
|\ | | | | | | | | | | | | | | | | 9088: minor: remove debug print r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * minor: remove debug printAleksey Kladov2021-05-311-1/+0
| |
* | Merge #9084 #9087bors[bot]2021-05-312-112/+37
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | 9084: fix: avoid panics in match case diagnostic r=matklad a=matklad bors r+ 🤖 closes #8809 9087: fix: fix shell injection in task spawning r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
* | Use `cargo check` againJonas Schievink2021-05-311-1/+1
| |
| * minor: it's Parameter, not ArgumentAleksey Kladov2021-05-312-5/+5
| |
| * fix: avoid panics in match case diagnosticAleksey Kladov2021-05-311-108/+33
|/
* Merge #8952bors[bot]2021-05-311-1/+71
|\ | | | | | | | | | | | | | | 8952: add support of impl block for doctest into runnables r=matklad a=bnjjj close #6356 Co-authored-by: Benjamin Coenen <[email protected]>
| * add support of impl block for doctest into runnablesBenjamin Coenen2021-05-241-1/+71
| | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | Simplify proc_macro_srv testsJonas Schievink2021-05-315-241/+116
| |
* | Merge #9079bors[bot]2021-05-311-3/+53
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 9079: Don't take the parent kind of trailing attributes in attr completion r=Veykril a=Veykril bors r+ fixes https://github.com/rust-analyzer/rust-analyzer/issues/9076 Co-authored-by: Lukas Wirth <[email protected]>
| * | Don't take the parent kind of trailing attributes in attr completionLukas Wirth2021-05-311-3/+53
| | |
* | | Merge #9039bors[bot]2021-05-3111-26/+154
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 9039: feat: Complete fields and methods with `self.` prefixed when inside methods r=matklad a=Veykril ![w65NbjkZiG](https://user-images.githubusercontent.com/3757771/119984385-a0111700-bfc1-11eb-9dbf-52fdaa4d72b5.gif) Closes #7173 Co-authored-by: Lukas Wirth <[email protected]>
| * | | Add config setting for self-on-the-flyLukas Wirth2021-05-317-2/+11
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-23 17:52:17 +0000