Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | | | Add benchmark test for mbe | Edwin Cheng | 2021-02-24 | 4 | -0/+222 | |
| | | | | | | ||||||
* | | | | | | generate try_into instead of into | Domantas Jadenkus | 2021-02-27 | 3 | -72/+96 | |
| | | | | | | ||||||
* | | | | | | rename generate_enum_match_method file to match assist name | Domantas Jadenkus | 2021-02-27 | 2 | -2/+2 | |
| | | | | | | ||||||
* | | | | | | move into_ and as_ generation to a separate file | Domantas Jadenkus | 2021-02-27 | 4 | -402/+340 | |
| | | | | | | ||||||
* | | | | | | cargo fmt | Domantas Jadenkus | 2021-02-27 | 1 | -35/+20 | |
| | | | | | | ||||||
* | | | | | | add generate_enum_as_method assist | Domantas Jadenkus | 2021-02-27 | 3 | -0/+154 | |
| | | | | | | ||||||
* | | | | | | deduplicate some | Domantas Jadenkus | 2021-02-27 | 1 | -37/+28 | |
| | | | | | | ||||||
* | | | | | | add generate_enum_into_method assist | Domantas Jadenkus | 2021-02-27 | 3 | -20/+275 | |
| | | | | | | ||||||
* | | | | | | make generate_enum_is_method work on any variants | Domantas Jadenkus | 2021-02-27 | 1 | -18/+95 | |
| | | | | | | ||||||
* | | | | | | rename existing assist to generate_enum_is_method | Domantas Jadenkus | 2021-02-27 | 3 | -11/+11 | |
| |_|/ / / |/| | | | | ||||||
* | | | | | Disable "Flip comma" assist inside a macro call | Denys Zadorozhnyi | 2021-02-26 | 1 | -2/+24 | |
| | | | | | ||||||
* | | | | | docs(ide_assists): Change importMergeBehaviour to importMergeBehavior | Sanchith Hegde | 2021-02-26 | 1 | -3/+3 | |
| | | | | | ||||||
* | | | | | bump crates | kjeremy | 2021-02-25 | 1 | -1/+1 | |
| | | | | | ||||||
* | | | | | Merge #7741 | bors[bot] | 2021-02-24 | 4 | -0/+327 | |
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7741: Add convert_for_to_iter_for_each assist r=mattyhall a=mattyhall Implements one direction of #7681 I wonder if this tries to guess too much at the right thing here. A common pattern is: ```rust let col = vec![1, 2, 3]; for v in &mut col { *v *= 2; } // equivalent to: col.iter_mut().for_each(|v| *v *= 2); ``` I've tried to detect this case by checking if the expression after the `in` is a (mutable) reference and if not inserting iter()/iter_mut(). This is just a convention used in the stdlib however, so could sometimes be wrong. I'd be happy to make an improvement for this, but not sure what would be best. A few options spring to mind: 1. Only allow this for types that are known to have iter/iter_mut (ie stdlib types) 2. Try to check if iter/iter_mut exists and they return the right iterator type 3. Don't try to do this and just add `.into_iter()` to whatever is after `in` Co-authored-by: Matt Hall <[email protected]> | |||||
| * | | | | Address further review comments | Matt Hall | 2021-02-24 | 2 | -51/+36 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Use known names for iter/iter_mut method (simplifies checking if the method exists * Extract code to check assist with fixtures to function | |||||
| * | | | | Address review comments | Matt Hall | 2021-02-23 | 1 | -33/+125 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | * Move code to build replacement into closure * Look for iter/iter_mut methods on types behind reference | |||||
| * | | | | Add convert_for_to_iter_for_each assist | Matt Hall | 2021-02-23 | 3 | -0/+250 | |
| |/ / / | ||||||
* | | | | Add tests for apply_demorgan | Lukas Wirth | 2021-02-24 | 3 | -18/+83 | |
| | | | | ||||||
* | | | | De Morgan's Law assist now correctly inverts <, <=, >, >=. | lbrande | 2021-02-24 | 7 | -13/+68 | |
| | | | | ||||||
* | | | | De Morgan's Law assist now correctly parenthesizes binary expressions. | lbrande | 2021-02-24 | 3 | -11/+7 | |
| |/ / |/| | | ||||||
* | | | Pickup ConstReference patterns in FindUsages | Lukas Wirth | 2021-02-23 | 2 | -4/+36 | |
|/ / | ||||||
* | | is_visible_from_def_map: handle block expressions | Jonas Schievink | 2021-02-23 | 3 | -9/+37 | |
| | | ||||||
* | | Add test | Jonas Schievink | 2021-02-23 | 1 | -0/+28 | |
| | | ||||||
* | | 7526: Renamed create ssr to ide_ssr. | Chetan Khilosiya | 2021-02-22 | 15 | -8/+9 | |
| | | ||||||
* | | 7526: Rename crate assists to ide_assists. | Chetan Khilosiya | 2021-02-22 | 71 | -6/+6 | |
| | | ||||||
* | | Add isize to the list of suffixed integers in typed_integer | Jonas Bushart | 2021-02-22 | 1 | -2/+1 | |
| | | | | | | | | | | | | The missing `isize` in `typed_integers` seems to just be an oversight. Might fix: #7751 | |||||
* | | Make more common assist easier to ues | Aleksey Kladov | 2021-02-22 | 4 | -42/+87 | |
| | | ||||||
* | | Add test from #7273 | Laurențiu Nicola | 2021-02-21 | 1 | -0/+45 | |
| | | ||||||
* | | Bump deps | Laurențiu Nicola | 2021-02-21 | 2 | -4/+4 | |
| | | ||||||
* | | Stop mixing Result and Option with ? in inline_local_variable | Scott McMurray | 2021-02-20 | 1 | -4/+4 | |
| | | | | | | | | Depending on the discussion in RFC#3058 this might not end up being necessary, but I think it's a reasonable change regardless. | |||||
* | | Merge #7732 | bors[bot] | 2021-02-20 | 6 | -37/+45 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7732: Don't lower TypeBound::Lifetime as GenericPredicate::Error r=flodiebold a=Veykril Basically we just discard the typebound for now instead when lowering to `GenericPredicate`. I think this shouldn't have any other side effects? Fixes #7683(hopefully for real this time) I also played around with introducing `GenericPredicate::LifetimeOutlives` and `GenericPredicate::TypeOutlives`(see https://github.com/Veykril/rust-analyzer/commit/b9d69048451a5f2e9c5a72c800369bbeef36fdcf) but that won't fix this issue(at least not for now) due to lifetime predicate mismatches when resolving methods so I figure this is a good way to fix it for now. Co-authored-by: Lukas Wirth <[email protected]> | |||||
| * | | Don't write trailing whitespace when formatting empty GenericPredicates | Lukas Wirth | 2021-02-20 | 3 | -14/+24 | |
| | | | ||||||
| * | | Don't lower TypeBound::Lifetime as GenericPredicate::Error | Lukas Wirth | 2021-02-20 | 4 | -25/+23 | |
| | | | ||||||
* | | | Update tests | Jeremy Kolb | 2021-02-20 | 10 | -0/+104 | |
| | | | ||||||
* | | | Use format_to! to make logic a bit nicer | Matt Hall | 2021-02-20 | 1 | -6/+8 | |
| | | | ||||||
* | | | Fix #7712 retain visibility extracting mod to file | Matt Hall | 2021-02-20 | 1 | -2/+43 | |
| | | | ||||||
* | | | Remove documentation of obsolete extend selection command | Laurențiu Nicola | 2021-02-20 | 1 | -3/+5 | |
| | | | ||||||
* | | | Merge #7726 | bors[bot] | 2021-02-20 | 1 | -0/+3 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7726: feat(completion): add doc(hidden) completion for attributes r=lnicola a=bnjjj Co-authored-by: Benjamin Coenen <[email protected]> | |||||
| * | | | feat(completion): add doc(hidden) completion for attributes | Benjamin Coenen | 2021-02-20 | 1 | -0/+3 | |
| |/ / | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
* / / | fix(assist): display where predicates when we want to generate impl | Benjamin Coenen | 2021-02-20 | 2 | -1/+33 | |
|/ / | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]> | |||||
* | | Consider import prefix config settings during flyimports | Kirill Bulatov | 2021-02-20 | 3 | -4/+94 | |
| | | ||||||
* | | Add test | Laurențiu Nicola | 2021-02-20 | 1 | -0/+24 | |
| | | ||||||
* | | Fix incorrect missing field diagnostic with box patterns | Laurențiu Nicola | 2021-02-20 | 1 | -4/+13 | |
| | | ||||||
* | | rename completion -> ide_completion | Aleksey Kladov | 2021-02-17 | 34 | -6/+6 | |
| | | | | | | | | We don't have completion-related PRs in flight, so lets do it | |||||
* | | Revert "Replace usage of ast::NameOrNameRef with ast::NameLike" | Lukas Wirth | 2021-02-17 | 3 | -28/+26 | |
| | | | | | | | | This reverts commit e1dbf43cf85f84c3a7e40f9731fc1f7ac96f8979. | |||||
* | | Merge #7699 | bors[bot] | 2021-02-17 | 6 | -115/+118 | |
|\ \ | | | | | | | | | | | | | | | | | | | | | | 7699: Implement ast::AstNode for NameLike and move it to node_ext r=matklad a=Veykril With this `search`(and 2 other modules) don't necessarily go through 3 calls of `find_node_at_offset_with_descend` to find the correct node. Also makes the code that searches for NameLikes a bit easier on the eyes imo, though that can be fixed with just a helper function as well so its not that relevant. Co-authored-by: Lukas Wirth <[email protected]> | |||||
| * | | Replace usage of ast::NameOrNameRef with ast::NameLike | Lukas Wirth | 2021-02-17 | 3 | -26/+28 | |
| | | | ||||||
| * | | Implement ast::AstNode for NameLike and move it to node_ext | Lukas Wirth | 2021-02-16 | 5 | -101/+102 | |
| | | | ||||||
* | | | Merge #7705 | bors[bot] | 2021-02-17 | 1 | -2/+38 | |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 7705: Show hover info of the definition of ConstReference patterns instead of its type r=Veykril a=Veykril Closes #7671 bors r+ Co-authored-by: Lukas Wirth <[email protected]> | |||||
| * | | | Show hover info of the definition of ConstReference patterns instead of its type | Lukas Wirth | 2021-02-17 | 1 | -2/+38 | |
| |/ / |