Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Refactor if-let -> match assist to use ast::make | Aleksey Kladov | 2020-02-05 | 4 | -32/+55 |
| | |||||
* | Merge #3019 | bors[bot] | 2020-02-05 | 1 | -36/+91 |
|\ | | | | | | | | | | | | | | | 3019: Better cursor placement when merging arms r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | Better cursor placement when merging arms | Aleksey Kladov | 2020-02-05 | 1 | -4/+17 |
| | | |||||
| * | Merge match arms works with many arms | Aleksey Kladov | 2020-02-05 | 1 | -29/+70 |
| | | |||||
| * | Cleanup | Aleksey Kladov | 2020-02-05 | 1 | -11/+12 |
| | | |||||
* | | Apply the reviews suggestions | Kirill Bulatov | 2020-02-05 | 5 | -32/+64 |
| | | |||||
* | | Normalize dashes in crate names | Kirill Bulatov | 2020-02-05 | 1 | -8/+33 |
|/ | |||||
* | Merge #2948 | bors[bot] | 2020-02-04 | 1 | -6/+48 |
|\ | | | | | | | | | | | | | | | 2948: Allow add_explicit_type to replace a placeholder type r=matklad a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]> | ||||
| * | Allow add_explicit_type to replace a placeholder type | Laurențiu Nicola | 2020-02-03 | 1 | -6/+48 |
| | | |||||
* | | minor, if let else -> match | Aleksey Kladov | 2020-02-04 | 1 | -6/+3 |
| | | |||||
* | | Make sure that newly created nodes are the root of the tree | Aleksey Kladov | 2020-02-04 | 1 | -2/+11 |
| | | |||||
* | | Merge #2962 | bors[bot] | 2020-02-04 | 4 | -14/+34 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | 2962: Differentiate underscore alias from named aliases r=matklad a=zombiefungus pre for Fixing Issue 2736 edited to avoid autoclosing the issue Co-authored-by: zombiefungus <[email protected]> | ||||
| * | | include requested changes | zombiefungus | 2020-02-02 | 4 | -27/+28 |
| | | | |||||
| * | | add new ImportAlias enum to differentiate no alias from an _ alias | zombiefungus | 2020-02-02 | 4 | -11/+30 |
| | | | |||||
* | | | ra_syntax: added tests for tokenization errors | Veetaha | 2020-02-03 | 150 | -49/+427 |
| | | | |||||
* | | | ra_syntax: add backticks around tokens specimen | Veetaha | 2020-02-03 | 1 | -12/+23 |
| | | | |||||
* | | | ra_syntax: removed unnecessary init statement from reparsing tests | Veetaha | 2020-02-03 | 1 | -3/+0 |
| | | | |||||
* | | | ra_syntax: rename first_token() -> lex_first_token() | Veetaha | 2020-02-03 | 1 | -3/+3 |
| | | | |||||
* | | | ra_syntax: fixed a typo in doc comment | Veetaha | 2020-02-03 | 1 | -2/+4 |
| | | | |||||
* | | | ra_syntax: refactored the lexer design as per @matklad and @kiljacken PR review | Veetaha | 2020-02-03 | 9 | -178/+199 |
| | | | |||||
* | | | ra_syntax: remove backticks from TokenizeError message since that is not ↵ | Veetaha | 2020-02-03 | 1 | -9/+9 |
| | | | | | | | | | | | | Markdown ;( | ||||
* | | | add better docs for tokenize errors | Veetaha | 2020-02-03 | 1 | -2/+2 |
| | | | |||||
* | | | ra_syntax: moved ParsedToken derive attribute under the doc comment | Veetaha | 2020-02-03 | 1 | -1/+1 |
| | | | |||||
* | | | ra_syntax: fixed doc comment | Veetaha | 2020-02-03 | 1 | -1/+1 |
| | | | |||||
* | | | Reimplemented lexer with vectors instead of iterators | Veetaha | 2020-02-03 | 10 | -196/+250 |
| | | | |||||
* | | | ra_syntax: changed added diagnostics information returned from tokenize() ↵ | Veetaha | 2020-02-03 | 4 | -74/+237 |
| | | | | | | | | | | | | (implemented with iterators) | ||||
* | | | Use proper import name in the label | Kirill Bulatov | 2020-02-03 | 1 | -10/+6 |
| | | | |||||
* | | | Merge #2994 | bors[bot] | 2020-02-03 | 2 | -12/+11 |
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2994: Small cleanup r=matklad a=SomeoneToIgnore A follow-up to https://github.com/rust-analyzer/rust-analyzer/pull/2990#discussion_r374044482 Co-authored-by: Kirill Bulatov <[email protected]> | ||||
| * | | | Simplify paths searches | Kirill Bulatov | 2020-02-03 | 1 | -4/+3 |
| | | | | |||||
| * | | | Fix inlay hints test snippet compilation | Kirill Bulatov | 2020-02-03 | 1 | -8/+8 |
| | | | | |||||
* | | | | Merge #2959 | bors[bot] | 2020-02-03 | 14 | -247/+244 |
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2959: Rework how we send diagnostics to client r=matklad a=kiljacken The previous way of sending from the thread pool suffered from stale diagnostics due to being canceled before we could clear the old ones. The key change is moving to sending diagnostics from the main loop thread, but doing all the hard work in the thread pool. This should provide the best of both worlds, with little to no of the downsides. This should hopefully fix a lot of issues, but we'll need testing in each individual issue to be sure. Co-authored-by: Emil Lauridsen <[email protected]> | ||||
| * | | | Update snapshot tests due to removed SuggestedFix | Emil Lauridsen | 2020-02-03 | 7 | -39/+67 |
| | | | | |||||
| * | | | Remove stray todo | Emil Lauridsen | 2020-02-03 | 1 | -1/+0 |
| | | | | |||||
| * | | | Rework how we send diagnostics to client. | Emil Lauridsen | 2020-02-03 | 7 | -208/+178 |
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous way of sending from the thread pool suffered from stale diagnostics due to being canceled before we could clear the old ones. The key change is moving to sending diagnostics from the main loop thread, but doing all the hard work in the thread pool. This should provide the best of both worlds, with little to no of the downsides. This should hopefully fix a lot of issues, but we'll need testing in each individual issue to be sure. | ||||
* / | | Use name only when searching for an import candidate | Kirill Bulatov | 2020-02-02 | 1 | -6/+16 |
|/ / | |||||
* | | Avoid premature pessimization | Aleksey Kladov | 2020-02-02 | 3 | -33/+34 |
| | | | | | | | | | | | | The extra allocation for message should not matter here at all, but using a static string is just as ergonomic, if not more, and there's no reason to write deliberately slow code | ||||
* | | Merge #2982 | bors[bot] | 2020-02-02 | 6 | -42/+90 |
|\ \ | |/ |/| | | | | | | | | | | | 2982: Merge imports when auto importing r=flodiebold a=SomeoneToIgnore Co-authored-by: Kirill Bulatov <[email protected]> | ||||
| * | Remove obsolete rustdoc | Kirill Bulatov | 2020-02-02 | 1 | -1/+0 |
| | | |||||
| * | Code review fixes | Kirill Bulatov | 2020-02-02 | 3 | -22/+19 |
| | | |||||
| * | Require ModPath for importing | Kirill Bulatov | 2020-02-02 | 6 | -37/+65 |
| | | |||||
| * | Merge imports when auto importing | Kirill Bulatov | 2020-02-02 | 1 | -6/+30 |
| | | |||||
* | | Auto import functions | Kirill Bulatov | 2020-02-01 | 2 | -6/+35 |
|/ | |||||
* | Prevent child cargo process from messing with our stdin | Aleksey Kladov | 2020-02-01 | 1 | -0/+1 |
| | | | | | | | | By default, `spawn` inherits stderr/stdout/stderr of the parent process, and so, if child, for example does fcntl(O_NONBLOCK), weird stuff happens to us. Closes https://github.com/rust-analyzer/lsp-server/pull/10 | ||||
* | Merge #2965 | bors[bot] | 2020-02-01 | 1 | -6/+10 |
|\ | | | | | | | | | | | | | | | 2965: Improve auto import message r=kiljacken a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]> | ||||
| * | Improve auto import message | Laurențiu Nicola | 2020-01-31 | 1 | -6/+10 |
| | | |||||
* | | Fix extra parentheses warnings | Laurențiu Nicola | 2020-01-31 | 1 | -2/+2 |
|/ | |||||
* | Small cleanup | Aleksey Kladov | 2020-01-31 | 1 | -4/+6 |
| | |||||
* | Add a FIXME note | Aleksey Kladov | 2020-01-30 | 1 | -0/+3 |
| | |||||
* | Merge #2920 | bors[bot] | 2020-01-30 | 1 | -2/+18 |
|\ | | | | | | | | | | | | | | | | | | | 2920: Better handle illformed node id from metadata r=matklad a=edwin0cheng In some rare cases, deps node-id from cargo-metadata do not match its version-id, which cause a panic in `cargo-workspace.rs`. This PR try to ignore these ill-formed node id from `cargo-metadata`. An alternative is return `Err` in these cases but I think make it resilience is a better choice here. Related #2767 Co-authored-by: Edwin Cheng <[email protected]> | ||||
| * | Ignore illform node id from metadata | Edwin Cheng | 2020-01-28 | 1 | -2/+18 |
| | |