Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Better error messages while deserializing | Aleksey Kladov | 2020-02-11 | 3 | -11/+17 |
| | |||||
* | Merge #3074 | bors[bot] | 2020-02-10 | 20 | -112/+420 |
|\ | | | | | | | | | | | | | | | 3074: Or patterns r=matthewjasper a=matthewjasper Works towards #2458 Co-authored-by: Matthew Jasper <[email protected]> | ||||
| * | Address review comments | Matthew Jasper | 2020-02-10 | 3 | -14/+66 |
| | | |||||
| * | Update tests for or-patterns | Matthew Jasper | 2020-02-09 | 4 | -60/+184 |
| | | |||||
| * | Add or- and parenthesized-patterns | Matthew Jasper | 2020-02-09 | 14 | -45/+177 |
| | | |||||
* | | More specific error if `rustc --print sysroot` fails | Aleksey Kladov | 2020-02-10 | 1 | -1/+2 |
| | | |||||
* | | move to to_usize() | Veetaha | 2020-02-09 | 3 | -6/+6 |
|/ | |||||
* | Fix rebase leftovers | Kirill Bulatov | 2020-02-09 | 1 | -2/+2 |
| | |||||
* | Do not import anything if first segment of FQN resolves | Kirill Bulatov | 2020-02-09 | 1 | -12/+36 |
| | |||||
* | Set auto-import target | Aleksey Kladov | 2020-02-09 | 1 | -1/+17 |
| | | | | closes #3067 | ||||
* | Simplify Assists interface | Aleksey Kladov | 2020-02-09 | 5 | -141/+108 |
| | | | | | Instead of building a physical tree structure, just "tag" related assists with the same group | ||||
* | Slightly simpler API for groups | Aleksey Kladov | 2020-02-09 | 2 | -48/+77 |
| | |||||
* | Some README fixes/cleanups | Florian Diebold | 2020-02-09 | 1 | -1/+1 |
| | | | | Make capitalization more consistent and fix some typos. | ||||
* | Merge #3050 | bors[bot] | 2020-02-09 | 24 | -614/+1174 |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3050: Refactor type parameters, implement argument position impl trait r=matklad a=flodiebold I wanted to implement APIT by lowering to type parameters because we need to do that anyway for correctness and don't need Chalk support for it; this grew into some more wide-ranging refactoring of how type parameters are handled :sweat_smile: - use Ty::Bound instead of Ty::Param to represent polymorphism, and explicitly count binders. This gets us closer to Chalk's way of doing things, and means that we now only use Param as a placeholder for an unknown type, e.g. within a generic function. I.e. we're never using Param in a situation where we want to substitute it, and the method to do that is gone; `subst` now always works on bound variables. (This changes how the types of generic functions print; previously, you'd get something like `fn identity<i32>(T) -> T`, but now we display the substituted signature `fn identity<i32>(i32) -> i32`, which I think makes more sense.) - once we do this, it's more natural to represent `Param` by a globally unique ID; the use of indices was mostly to make substituting easier. This also means we fix the bug where `Param` loses its name when going through Chalk. - I would actually like to rename `Param` to `Placeholder` to better reflect its use and get closer to Chalk, but I'll leave that to a follow-up. - introduce a context for type lowering, to allow lowering `impl Trait` to different things depending on where we are. And since we have that, we can also lower type parameters directly to variables instead of placeholders. Also, we'll be able to use this later to collect diagnostics. - implement argument position impl trait by lowering it to type parameters. I've realized that this is necessary to correctly implement it; e.g. consider `fn foo(impl Display) -> impl Something`. It's observable that the return type of e.g. `foo(1u32)` unifies with itself, but doesn't unify with e.g. `foo(1i32)`; so the return type needs to be parameterized by the argument type. This fixes a few bugs as well: - type parameters 'losing' their name when they go through Chalk, as mentioned above (i.e. getting `[missing name]` somewhere) - impl trait not being considered as implementing the super traits (very noticeable for the `db` in RA) - the fact that argument impl trait was only turned into variables when the function got called caused type mismatches when the function was used as a value (fixes a few type mismatches in RA) The one thing I'm not so happy with here is how we're lowering `impl Trait` types to variables; since `TypeRef`s don't have an identity currently, we just count how many of them we have seen while going through the function signature. That's quite fragile though, since we have to do it while desugaring generics and while lowering the type signature, and in the exact same order in both cases. We could consider either giving only `TypeRef::ImplTrait` a local id, or maybe just giving all `TypeRef`s an identity after all (we talked about this before)... Follow-up tasks: - handle return position impl trait; we basically need to create a variable and some trait obligations for that variable - rename `Param` to `Placeholder` Co-authored-by: Florian Diebold <[email protected]> Co-authored-by: Florian Diebold <[email protected]> | ||||
| * | Add two more tests | Florian Diebold | 2020-02-07 | 1 | -0/+51 |
| | | |||||
| * | Fix some TODOs | Florian Diebold | 2020-02-07 | 3 | -11/+17 |
| | | |||||
| * | Fix add_new assist (kind of) | Florian Diebold | 2020-02-07 | 1 | -5/+10 |
| | | |||||
| * | Don't print implicit type args from impl Trait | Florian Diebold | 2020-02-07 | 2 | -14/+21 |
| | | |||||
| * | Deal better with implicit type parameters and argument lists | Florian Diebold | 2020-02-07 | 4 | -26/+138 |
| | | |||||
| * | Formatting | Florian Diebold | 2020-02-07 | 12 | -53/+98 |
| | | |||||
| * | Clean up RPIT a bit | Florian Diebold | 2020-02-07 | 5 | -41/+14 |
| | | |||||
| * | Fix compilation of other crates | Florian Diebold | 2020-02-07 | 3 | -14/+25 |
| | | |||||
| * | Use variables in predicates as well | Florian Diebold | 2020-02-07 | 5 | -63/+52 |
| | | |||||
| * | Comment fixes / todos | Florian Diebold | 2020-02-07 | 3 | -6/+8 |
| | | |||||
| * | Fix APIT some more | Florian Diebold | 2020-02-07 | 4 | -101/+115 |
| | | |||||
| * | Fix APIT | Florian Diebold | 2020-02-07 | 1 | -0/+2 |
| | | |||||
| * | Change Ty::Param to contain param ID | Florian Diebold | 2020-02-07 | 11 | -127/+136 |
| | | |||||
| * | WIP use params for APIT | Florian Diebold | 2020-02-07 | 3 | -1/+64 |
| | | |||||
| * | Fix assoc type selection | Florian Diebold | 2020-02-07 | 2 | -32/+43 |
| | | |||||
| * | Fix another test | Florian Diebold | 2020-02-07 | 2 | -7/+3 |
| | | |||||
| * | First stab at desugaring bounds for APIT | Florian Diebold | 2020-02-07 | 3 | -10/+56 |
| | | |||||
| * | Fix crash | Florian Diebold | 2020-02-07 | 1 | -4/+7 |
| | | |||||
| * | Fix enum constructors | Florian Diebold | 2020-02-07 | 3 | -11/+9 |
| | | |||||
| * | Fix printing of function types | Florian Diebold | 2020-02-07 | 7 | -72/+73 |
| | | |||||
| * | Lower impl trait to variables, move away from using placeholders where they ↵ | Florian Diebold | 2020-02-07 | 9 | -188/+220 |
| | | | | | | | | don't belong | ||||
| * | wip lower impl trait to type args | Florian Diebold | 2020-02-07 | 8 | -14/+97 |
| | | |||||
| * | wip implement lowering mode | Florian Diebold | 2020-02-07 | 2 | -26/+34 |
| | | |||||
| * | Add impl trait lowering mode | Florian Diebold | 2020-02-07 | 6 | -40/+141 |
| | | |||||
| * | Introduce TyLoweringContext | Florian Diebold | 2020-02-07 | 6 | -152/+144 |
| | | |||||
* | | Remove ImportResolver-related stubs | Kirill Bulatov | 2020-02-09 | 2 | -9/+1 |
| | | |||||
* | | Remove hard-coded auto-import during completion | Aleksey Kladov | 2020-02-09 | 1 | -128/+3 |
| | | | | | | | | We now have a real auto-import system, so we can do a proper thing. | ||||
* | | Rename add import assist | Kirill Bulatov | 2020-02-07 | 7 | -88/+81 |
|/ | |||||
* | Merge #3049 | bors[bot] | 2020-02-07 | 28 | -107/+95 |
|\ | | | | | | | | | | | | | | | 3049: Introduce assists utils r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | Introduce assists utils | Aleksey Kladov | 2020-02-07 | 5 | -26/+32 |
| | | |||||
| * | Name assist handlers | Aleksey Kladov | 2020-02-07 | 27 | -33/+17 |
| | | |||||
| * | Cleanups | Aleksey Kladov | 2020-02-07 | 1 | -2/+5 |
| | | |||||
| * | Cleanup imports | Aleksey Kladov | 2020-02-07 | 1 | -1/+1 |
| | | |||||
| * | Cleanup | Aleksey Kladov | 2020-02-07 | 2 | -4/+11 |
| | | |||||
| * | Cleanup | Aleksey Kladov | 2020-02-07 | 1 | -3/+4 |
| | | |||||
| * | Simplify | Aleksey Kladov | 2020-02-07 | 2 | -42/+29 |
| | |