aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #3935 from cjhopman/todoAleksey Kladov2020-04-113-18/+21
|\ | | | | Change missing impl assist to use todo!() instead of unimplemented()
| * Change missing impl assist to use todo!() instead of unimplemented()Chris Hopman2020-04-103-18/+21
| | | | | | | | | | | | | | | | | | | | | | | | todo!() "Indicates unfinished code" (https://doc.rust-lang.org/std/macro.todo.html) Rust documentation provides further clarification: > The difference between unimplemented! and todo! is that while todo! > conveys an intent of implementing the functionality later and the > message is "not yet implemented", unimplemented! makes no such claims. todo!() seems more appropriate for assists that insert missing impls.
* | Merge pull request #3910 from lnicola/fn-named-param-hintAleksey Kladov2020-04-111-5/+12
|\ \ | | | | | | Hide parameter hints for single-argument functions with the same name
| * | Hide parameter hints for single-argument functions with the same nameLaurențiu Nicola2020-04-091-5/+12
| | |
* | | Merge #3920bors[bot]2020-04-117-5/+551
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3920: Implement expand_task and list_macros in proc_macro_srv r=matklad a=edwin0cheng This PR finish up the remain `proc_macro_srv` implementation : 1. Added dylib loading code for proc-macro crate dylib. Note that we have to add some special flags for unix loading because of a bug in old version of glibc, see https://github.com/fedochet/rust-proc-macro-panic-inside-panic-expample/issues/1 and https://github.com/rust-lang/rust/issues/60593 for details. 2. Added tests for proc-macro expansion: We use a trick here by adding `serde_derive` to dev-dependencies and calling `cargo-metadata` for searching its dylib path, and expand it in our tests. [EDIT] Note that this PR **DO NOT** implement the final glue code with rust-analzyer and proc-macro-srv yet. Co-authored-by: Edwin Cheng <[email protected]>
| * | | Improve error handlingEdwin Cheng2020-04-111-24/+30
| | | |
| * | | tidy up a bitEdwin Cheng2020-04-101-50/+18
| | | |
| * | | Fix macos symbol name bugEdwin Cheng2020-04-091-1/+19
| | | |
| * | | Remove allow(unused)Edwin Cheng2020-04-091-3/+2
| | | |
| * | | Add testsEdwin Cheng2020-04-095-0/+304
| | | |
| * | | Implement expand_task and list_macrosEdwin Cheng2020-04-091-4/+27
| | | |
| * | | Add dylib loading codeEdwin Cheng2020-04-094-1/+229
| | | |
* | | | Fix non canonicallized path for crate fileEdwin Cheng2020-04-112-2/+6
| | | |
* | | | Forward compatAleksey Kladov2020-04-108-26/+25
| |_|/ |/| |
* | | Move timeit to stdxAleksey Kladov2020-04-102-16/+15
| | |
* | | profile queriesAleksey Kladov2020-04-101-0/+5
| | |
* | | Fix accidently quadratic behavior when processing includesAleksey Kladov2020-04-101-17/+19
| | | | | | | | | | | | closes #3927
* | | Add failing testAleksey Kladov2020-04-101-2/+29
| | |
* | | SimplifyAleksey Kladov2020-04-102-19/+2
| | |
* | | Rename some tokensAleksey Kladov2020-04-10207-1380/+1094
| | |
* | | Better readabilityAleksey Kladov2020-04-102-0/+142
| | |
* | | Remove dead codeAleksey Kladov2020-04-104-195/+187
| | |
* | | Generate only minimal set of ineresting tokensAleksey Kladov2020-04-105-1306/+23
| | |
* | | Scale token generation backAleksey Kladov2020-04-106-309/+77
| | |
* | | Convert more tokensAleksey Kladov2020-04-103-219/+15
| | |
* | | Other delimitersAleksey Kladov2020-04-101-32/+32
| | |
* | | Curley tokensAleksey Kladov2020-04-105-116/+34
| | |
* | | Start replacing tokensAleksey Kladov2020-04-101-34/+12
| | |
* | | Semicolon tokenAleksey Kladov2020-04-105-16/+38
| | |
* | | More readable ast_src for keywordsAleksey Kladov2020-04-101-69/+77
| | |
* | | Merge #3905bors[bot]2020-04-107-57/+159
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3905: add ellipsis field to hir pat record r=matklad a=JoshMcguigan This PR corrects a `fixme`, adding an `ellipsis` field to the hir `Pat::Record` type. It will also be unlock some useful follow on work for #3894. Additionally it adds a diagnostic for missing fields in record patterns. ~~Marking as a draft because I don't have any tests, and a small amount of manual testing on my branch from #3894 suggests it might *not* be working. Any thoughts on how I can best test this, or else pointers on where I might be going wrong?~~ Co-authored-by: Josh Mcguigan <[email protected]>
| * | | add record pat missing field diagnosticJosh Mcguigan2020-04-107-57/+159
| | | |
* | | | Implement Chalk's debug methods using TLSFlorian Diebold2020-04-105-56/+297
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | Chalk now panics if we don't implement these methods and run with CHALK_DEBUG, so I thought I'd try to implement them 'properly'. Sadly, it seems impossible to do without transmuting lifetimes somewhere. The problem is that we need a `&dyn HirDatabase` to get names etc., which we can't just put into TLS. I thought I could just use `scoped-tls`, but that doesn't support references to unsized types. So I put the `&dyn` into another struct and put the reference to *that* into the TLS, but I have to transmute the lifetime to 'static for that to work.
* | | Simpler acessors for keywordsAleksey Kladov2020-04-0912-1015/+101
| | |
* | | use uniform accessorAleksey Kladov2020-04-092-5/+1
| | |
* | | use stdxAleksey Kladov2020-04-091-3/+3
| | |
* | | Drop needless traitAleksey Kladov2020-04-093-24/+16
| | |
* | | Remove code duplicationAleksey Kladov2020-04-095-60/+49
| | |
* | | Merge #3918bors[bot]2020-04-095-45/+142
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | 3918: Add support for feature attributes in struct literal r=matklad a=bnjjj As promised here is the next PR to solve 2 different scenarios with feature flag on struct literal. close #3870 Co-authored-by: Benjamin Coenen <[email protected]>
| * | feat: add support for feature attributes in struct literalBenjamin Coenen2020-04-0924-7989/+7218
| |\ \ | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | feat: add support for feature attributes in struct literalBenjamin Coenen2020-04-096-45/+143
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | Merge #3901bors[bot]2020-04-091-6/+46
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3901: Add more heuristics for hiding obvious param hints r=matklad a=IceSentry This will now hide `value`, `pat`, `rhs` and `other`. These words were selected from the std because they are used in commonly used functions with only a single param and are obvious by their use. It will also hide the hint if the passed param **starts** or end with the param_name. Maybe we could also split on '_' and check if one of the string is the param_name. I think it would be good to also hide `bytes` if the type is `[u8; n]` but I'm not sure how to get the param type signature. Closes #3900 Co-authored-by: IceSentry <[email protected]>
| * | | use .expr() to remove refIceSentry2020-04-091-5/+10
| | | |
| * | | clean up param hint checkingIceSentry2020-04-091-18/+18
| | | |
| * | | better `&mut ` and `&` matchingIceSentry2020-04-091-6/+6
| | | |
| * | | ignore `&mut ` and `&` when checking paramsIceSentry2020-04-091-3/+13
| | | |
| * | | remove TODOIceSentry2020-04-081-1/+0
| | | |
| * | | Add more heuristics for hiding obvious param hintsIceSentry2020-04-081-4/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This will now hide "value", "pat", "rhs" and "other" These words were selected from the std because they are used in common functions with only a single param and are obvious by their use. I think it would be good to also hide "bytes" if the type is `[u8; n]` but I'm not sure how to get the param type signature It will also hide the hint if the passed param starts or end with the param_name
* | | | Merge #3919bors[bot]2020-04-0921-339/+243
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3919: Refactor tokena accessors r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Be consistent about token accesorsAleksey Kladov2020-04-0913-112/+33
| | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 08:20:44 +0000