aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Don't unify within a referenceFlorian Diebold2019-12-063-11/+72
| | | | | | | If we are expecting a `&Foo` and get a `&something`, when checking the `something`, we are *expecting* a `Foo`, but we shouldn't try to unify whatever we get with that expectation, because it could actually be a `&Foo`, and `&&Foo` coerces to `&Foo`. So this fixes quite a few false type mismatches.
* Simplify testAleksey Kladov2019-12-051-13/+10
|
* Merge #2479bors[bot]2019-12-0520-81/+632
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2479: Add expansion infrastructure for derive macros r=matklad a=flodiebold I thought I'd experiment a bit with attribute macro/derive expansion, and here's what I've got so far. It has dummy implementations of the Copy / Clone derives, to show that the approach works; it doesn't add any attribute macro support, but I think that fits into the architecture. Basically, during raw item collection, we look at the attributes and generate macro calls for them if necessary. Currently I only do this for derives, and just add the derive macro calls as separate calls next to the item. I think for derives, it's important that they don't obscure the actual item, since they can't actually change it (e.g. sending the item token tree through macro expansion unnecessarily might make completion within it more complicated). Attribute macros would have to be recognized at that stage and replace the item (i.e., the raw item collector will just emit an attribute macro call, and not the item). I think when we implement this, we should try to recognize known inert attributes, so that we don't do macro expansion unnecessarily; anything that isn't known needs to be treated as a possible attribute macro call (since the raw item collector can't resolve the macro yet). There's basically no name resolution for attribute macros implemented, I just hardcoded the built-in derives. In the future, the built-ins should work within the normal name resolution infrastructure; the problem there is that the builtin stubs in `std` use macros 2.0, which we don't support yet (and adding support is outside the scope of this). One aspect that I don't really have a solution for, but I don't know how important it is, is removing the attribute itself from its input. I'm pretty sure rustc leaves out the attribute macro from the input, but to do that, we'd have to create a completely new syntax node. I guess we could do it when / after converting to a token tree. Co-authored-by: Florian Diebold <[email protected]>
| * Implement all the other built-in derivesFlorian Diebold2019-12-052-15/+86
| | | | | | | | Since as long as we're not implementing the bodies, they all work the same way.
| * Implement derive(Copy, Clone) properly (well, kind of)Florian Diebold2019-12-053-7/+241
| |
| * Don't wrap most syntax trees in invisible delimiters when converting to ↵Florian Diebold2019-12-051-2/+8
| | | | | | | | | | | | token tree Otherwise parsing them again doesn't work.
| * Add expansion infrastructure for derive macrosFlorian Diebold2019-12-0518-79/+319
| |
* | Reduce copy-pasteAleksey Kladov2019-12-051-20/+30
| |
* | Introduce ChildFromSourceAleksey Kladov2019-12-053-101/+317
|/
* Publicize `file_id` to make `test_db` compileice10002019-12-051-1/+1
|
* Use placeholder instead of `Option`ice10002019-12-052-14/+10
|
* One pub function less is good!ice10002019-12-053-12/+7
|
* Reduce visibility, use struct instead of tuplesice10002019-12-051-20/+23
|
* No block at the momentice10002019-12-045-14/+3
|
* Remove almost unused `ModuleSource::new`ice10002019-12-042-20/+2
|
* Confluent `ModuleSource` usageice10002019-12-042-18/+6
|
* Add `ModuleSource::Block`ice10002019-12-049-100/+102
|
* Fix test compilationice10002019-12-042-2/+2
|
* Three-state enum for module originice10002019-12-042-20/+78
|
* Run rustfmt with respect to Cargo.toml editionVincent Rouillé2019-12-044-0/+78
|
* :arrow_up: rowanAleksey Kladov2019-12-043-8/+8
|
* Merge #2471bors[bot]2019-12-032-2/+4
|\ | | | | | | | | | | | | | | 2471: Add `ModuleItemsOwner` to `Block` r=matklad a=ice1000 As title Co-authored-by: ice1000 <[email protected]>
| * Add `ModuleItemsOwner` to `Block`ice10002019-12-032-2/+4
| |
* | Split up ty tests a bitFlorian Diebold2019-12-037-4902/+4882
|/
* Replace `ra_hir_expand::either` with crateice10002019-12-0322-112/+65
|
* Fix #2467Florian Diebold2019-12-034-7/+65
| | | | | The stand-alone `unify` requires that the type doesn't contain any type variables. So we can't share the code here for now (without more refactoring)...
* Merge #2465bors[bot]2019-12-033-127/+219
|\ | | | | | | | | | | | | | | 2465: Extract built-in trait implementations to separate module r=matklad a=flodiebold This untangles the builtin logic from the Chalk translation. Co-authored-by: Florian Diebold <[email protected]>
| * Extract built-in trait implementations to separate moduleFlorian Diebold2019-12-033-127/+219
| | | | | | | | This untangles the builtin logic from the Chalk translation.
* | Make unify pub(crate)Florian Diebold2019-12-031-1/+1
| |
* | Add tests for checking the impl self typeFlorian Diebold2019-12-022-0/+47
| |
* | Refactor a bitFlorian Diebold2019-12-023-77/+74
| |
* | Check receiver type properlyFlorian Diebold2019-12-024-19/+80
| |
* | Extract unification code to unify moduleFlorian Diebold2019-12-026-263/+312
| |
* | Change order of calls to get method candidate order correctFlorian Diebold2019-12-022-39/+115
|/
* Merge #2018bors[bot]2019-12-023-0/+227
|\ | | | | | | | | | | | | | | | | | | 2018: assists: add assist for custom implementation for derived trait r=matklad a=paulolieuthier Please, tell me if something could be more idiomatic or efficient. Fixes #1256. Co-authored-by: Paulo Lieuthier <[email protected]>
| * docs: describe new feature 'add custom impl for derived trait'Paulo Lieuthier2019-11-282-0/+36
| |
| * assists: add assist for custom implementation for derived traitPaulo Lieuthier2019-11-282-0/+191
| |
* | Merge #2455bors[bot]2019-12-017-32/+139
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | 2455: Add BuiltinShadowMode r=flodiebold a=edwin0cheng This PR try to fix #1905 by introduce an `BuiltinShadowMode` in name resolving functions. cc @flodiebold Co-authored-by: Edwin Cheng <[email protected]>
| * | Remove some empty linesEdwin Cheng2019-12-011-2/+0
| | |
| * | Use index instead of peekableEdwin Cheng2019-12-011-35/+19
| | |
| * | Fix commentEdwin Cheng2019-12-011-2/+1
| | |
| * | Add BuiltinShadowModeEdwin Cheng2019-11-307-31/+157
| | |
* | | Merge #2451bors[bot]2019-11-306-13/+5
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2451: Use env_logger instead of flexi_logger r=matklad a=AlexanderEkdahl This fixes https://github.com/rust-analyzer/rust-analyzer/issues/2335 - By default only `error` will be printed. From what I can tell this matches the current behaviour. Configured through `RUST_LOG`. - I looked through the optional dependencies for `env_logger`and I have only enabled `human_time`. Without this feature no timestamp will be shown for log messages. - `RA_LOG_DIR` feature is removed This PR adds 2 new dependencies(`env_logger` and `human_time`) and removes 6 dependencies. Co-authored-by: Alexander Ekdahl <[email protected]>
| * | | Remove log dependency from ra_cliAlexander Ekdahl2019-11-301-1/+0
| | | |
| * | | Remove flexi_logger from ra_lsp_serverAlexander Ekdahl2019-11-305-15/+4
| | | |
| * | | Use env_logger in ra_cliAlexander Ekdahl2019-11-302-3/+7
| | |/ | |/|
* | | Add cycle recovery for type aliasesFlorian Diebold2019-11-303-2/+10
| | |
* | | Add cycle recovery for generic predicatesFlorian Diebold2019-11-303-8/+10
| | |
* | | Handle cycles in impl types betterFlorian Diebold2019-11-308-53/+82
| | | | | | | | | | | | | | | | | | - impl Trait<Self> for S is allowed - impl Trait for S<Self> is an invalid cycle, but we can add cycle recovery for it in Salsa now
* | | Merge #2449bors[bot]2019-11-302-3/+51
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2449: Only allow renames to valid identifiers r=matklad a=detrumi Implements #2121 Co-authored-by: Wilco Kusee <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-18 01:55:56 +0000