aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | Make MergeBehaviour configurableLukas Wirth2020-09-128-17/+50
| | |/ / | |/| |
* | | | Merge #5971bors[bot]2020-09-1312-55/+314
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5971: Implement async blocks r=flodiebold a=oxalica Fix #4018 @flodiebold already gave a generic guide in the issue. Here's some concern about implementation detail: - Chalk doesn't support generator type yet. - Adding generator type as a brand new type (ctor) can be complex and need to *re-introduced* builtin impls. (Like how we implement closures before native closure support of chalk, which is already removed in #5401 ) - The output type of async block should be known after type inference of the whole body. - We cannot directly get the type from source like return-positon-impl-trait. But we still need to provide trait bounds when chalk asking for `opaque_ty_data`. - During the inference, the output type of async block can be temporary unknown and participate the later inference. `let a = async { None }; let _: i32 = a.await.unwrap();` So in this PR, the type of async blocks is inferred as an opaque type parameterized by the `Future::Output` type it should be, like what we do with closure type. And it really works now. Well, I still have some questions: - The bounds `AsyncBlockImplType<T>: Future<Output = T>` is currently generated in `opaque_ty_data`. I'm not sure if we should put this code here. - Type of async block is now rendered as `impl Future<Output = OutputType>`. Do we need to special display to hint that it's a async block? Note that closure type has its special format, instead of `impl Fn(..) -> ..` or function type. Co-authored-by: oxalica <[email protected]>
| * | | | Fix type walking about type of async blockoxalica2020-09-113-14/+78
| | | | |
| * | | | Fix and prettify commentsoxalica2020-09-111-4/+6
| | | | |
| * | | | Implement async blocksoxalica2020-09-1011-55/+248
| | | | |
* | | | | Implement box pattern inferenceJonas Schievink2020-09-123-2/+20
| | | | |
* | | | | Add box pattern testJonas Schievink2020-09-121-0/+25
| |/ / / |/| | |
* | | | Properly preserve macro bracesKirill Bulatov2020-09-111-25/+16
| | | |
* | | | Merge #5955bors[bot]2020-09-112-82/+114
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5955: Remove merge import code duplication r=jonas-schievink a=Veykril This removes the code duplication caused by #5935, this also allows the assist to merge imports that have equal visibility and prevents merges of unequal visibility. This PR also fixes an iteration mistake in the mentioned PR: Turns out I made a mistake when writing the `segment_iter` function, I was assuming that the `children` of a path will just be the segments, which is obviously not the case. This also brings insertion order of shorter paths in line with how `rustfmt` orders them. Co-authored-by: Lukas Wirth <[email protected]>
| * | | | Allow merge_imports assists to merge imports of equal visibilityLukas Wirth2020-09-052-6/+61
| | | | |
| * | | | Remove duplicated import merge logicLukas Wirth2020-09-052-77/+43
| | | | |
| * | | | Fix segment_iter not iterating segments properlyLukas Wirth2020-09-051-5/+16
| |/ / /
| | | |
| \ \ \
*-. \ \ \ Merge #5951 #5975bors[bot]2020-09-1114-34/+53
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5951: Rename record_field_pat to record_pat_field r=jonas-schievink a=pksunkara The token was renamed but not this. 5975: Report better errors in project.json/sysroot r=jonas-schievink a=jonas-schievink This does a bunch of light refactoring so that the `Sysroot` is loaded later, which makes sure that any errors are reported to the user. I then added a check that reports an error if libcore is missing in the loaded sysroot. Since a sysroot without libcore is very useless, this indicates a configuration error. Co-authored-by: Pavan Kumar Sunkara <[email protected]> Co-authored-by: Jonas Schievink <[email protected]>
| | * | | | Report better errors in project.json/sysrootJonas Schievink2020-09-114-17/+36
| | | |/ / | | |/| |
| * | | | Rename record_field_pat to record_pat_fieldPavan Kumar Sunkara2020-09-1010-17/+17
| | | | |
* | | | | Merge #5970bors[bot]2020-09-111-37/+118
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5970: Use better heuristics for replacement text when removing dbg! r=jonas-schievink a=SomeoneToIgnore Closes https://github.com/rust-analyzer/rust-analyzer/issues/5911 Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | One more testKirill Bulatov2020-09-101-0/+2
| | | | |
| * | | | Use better heuristics for replacement text when removing dbg!Kirill Bulatov2020-09-101-37/+116
| |/ / /
* | | | Merge #5969bors[bot]2020-09-1110-5/+431
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5969: Propose module name completion options r=jonas-schievink a=SomeoneToIgnore <img width="539" alt="image" src="https://user-images.githubusercontent.com/2690773/92663009-cb0aec00-f308-11ea-9ef5-1faa91518031.png"> Currently traverses the whole file set every time we try to complete the module, as discussed in https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/mod.3C.7C.3E.20completion Co-authored-by: Kirill Bulatov <[email protected]>
| * | | | Adjust the test commentKirill Bulatov2020-09-111-9/+16
| | | | |
| * | | | One more testKirill Bulatov2020-09-091-0/+15
| | | | |
| * | | | Rename the method to avoid false promisesKirill Bulatov2020-09-092-17/+15
| | | | |
| * | | | Add VirtualPath testsKirill Bulatov2020-09-091-3/+38
| | | | |
| * | | | Fix the testsKirill Bulatov2020-09-095-7/+9
| | | | |
| * | | | Add testsKirill Bulatov2020-09-091-0/+153
| | | | |
| * | | | Properly handle mod.rs importsKirill Bulatov2020-09-091-47/+40
| | | | |
| * | | | Complete semicolon when neededKirill Bulatov2020-09-096-26/+30
| | | | |
| * | | | Properly reacto to keywordsKirill Bulatov2020-09-096-4/+28
| | | | |
| * | | | Less false positive completion candidatesKirill Bulatov2020-09-091-44/+59
| | | | |
| * | | | Properly handle nested submodules in the same fileKirill Bulatov2020-09-091-70/+79
| | | | |
| * | | | Move most of the logic into the completion moduleKirill Bulatov2020-09-098-118/+107
| | | | |
| * | | | Finally cretae the mod completion moduleKirill Bulatov2020-09-094-18/+43
| | | | |
| * | | | Move rust-related logic from vfs to base_db levelKirill Bulatov2020-09-092-61/+74
| | | | |
| * | | | Properly handle special cases (binaries, mod.rs)Kirill Bulatov2020-09-093-52/+60
| | | | |
| * | | | Exclude special filesKirill Bulatov2020-09-092-3/+5
| | | | |
| * | | | Implement file name & extension retrieval method for VirtualPathKirill Bulatov2020-09-091-2/+20
| | | | |
| * | | | Small refactoringKirill Bulatov2020-09-092-32/+26
| | | | |
| * | | | Happy path implementedKirill Bulatov2020-09-098-26/+38
| | | | |
| * | | | Properly use FileSet APIKirill Bulatov2020-09-093-38/+49
| | | | |
| * | | | Better APIKirill Bulatov2020-09-098-24/+64
| | | | |
| * | | | First steps for mod<|> completionKirill Bulatov2020-09-094-6/+65
| |/ / /
* | | | Merge #5957bors[bot]2020-09-103-23/+66
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5957: Add consuming modifier to lvalues that are passed by value and not Copy r=jonas-schievink a=Nashenas88 Related to #5856 Co-authored-by: Paul Daniel Faria <[email protected]>
| * | | | Fix handling of consuming self, refactor shared logic into a single functionPaul Daniel Faria2020-09-062-30/+34
| | | | |
| * | | | Add consuming modifier to lvalues that are passed by value and not CopyPaul Daniel Faria2020-09-063-14/+53
| | |/ / | |/| |
* | | | Merge #5956bors[bot]2020-09-102-7/+89
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5956: Highlight errors in macros r=jonas-schievink a=popzxc Resolves #4924 This PR makes rust-analyzer highlight not only the source place when error originates in macro, but also the exact places in macro which caused an error. This is done by creating an inverse diagnostic, which points to the macro and cross-references the source place. ![изображение](https://user-images.githubusercontent.com/12111581/92319594-b71e6c00-f022-11ea-94c1-f412905269dd.png) Co-authored-by: Igor Aleksanov <[email protected]>
| * | | Highlight errors in macrosIgor Aleksanov2020-09-062-7/+89
| |/ /
* | | Merge #5968bors[bot]2020-09-093-14/+30
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 5968: Lookup ADT and associated type names for chalk debugging / tweak chalk interner r=flodiebold a=nathanwhit This PR improves the chalk program writing integration by looking up the names for ADTs and associated types, making the output much more readable. There are also a few small changes to the interner, which gives some nice performance improvements. We clone `Ty`s and `ProgramClause`s relatively often in chalk, so wrapping them in `Arc`s is a perf win. This takes the time for performing type inference on the rust-analyzer codebase from 40s to 33s on my machine. Co-authored-by: Nathan Whitaker <[email protected]>
| * | Tweak interner for chalkNathan Whitaker2020-09-091-9/+9
| | |
| * | Lookup ADT and assoc. type names for chalk debugNathan Whitaker2020-09-092-5/+21
| | |
* | | Merge #5940bors[bot]2020-09-045-1/+267
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5940: Implement "Replace `impl Trait` function argument with the named generic" assist. r=matklad a=alekseysidorov Fixes #5085 Co-authored-by: Aleksei Sidorov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 06:10:20 +0000