Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | internal: prepare to move rename to base_db | Aleksey Kladov | 2021-06-14 | 1 | -41/+40 |
| | | | | | | | | | | It's better to handle magical cases upper in the stack, because it allows for better re-use of the general implementation below. So, we pull the `self` case up here. The end goal is to put `Definition::rename` to the `ide_db`, because it's a generally re-usable functionality useful for different ide features, alongside with the search which is already there. | ||||
* | Merge #9263 | bors[bot] | 2021-06-14 | 1 | -41/+119 |
|\ | | | | | | | | | | | | | | | | | 9263: fix: don't use display-related functionality where semantics matters r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | fix: don't use display-related functionality where semantics matters | Aleksey Kladov | 2021-06-14 | 1 | -41/+119 |
| | | | | | | | | | | | | | | NavigationTarget is strictly a UI-level thing -- it describes where the cursor should be placed when the user presses goto definition. It doesn't make any semantic guaratees about rage and focus range and, as such, is not suitable for driving renames. | ||||
* | | Don't keep a trailing self token in import paths after unmerge_use | Lukas Wirth | 2021-06-14 | 1 | -1/+15 |
|/ | |||||
* | Merge #9260 | bors[bot] | 2021-06-14 | 31 | -36/+36 |
|\ | | | | | | | | | | | | | | | 9260: tree-wide: make rustdoc links spiky so they are clickable r=matklad a=lf- Rustdoc was complaining about these while I was running with --document-private-items and I figure they should be fixed. Co-authored-by: Jade <[email protected]> | ||||
| * | tree-wide: make rustdoc links spiky so they are clickable | Jade | 2021-06-14 | 31 | -36/+36 |
| | | |||||
* | | internal: diagnostic code is mandatory | Aleksey Kladov | 2021-06-13 | 3 | -29/+17 |
| | | |||||
* | | minor: dead code | Aleksey Kladov | 2021-06-13 | 2 | -50/+34 |
| | | |||||
* | | internal: kill diagnostic sink | Aleksey Kladov | 2021-06-13 | 4 | -170/+19 |
| | | |||||
* | | internal: use cov-mark rather than bailing out diagnostic | Aleksey Kladov | 2021-06-13 | 5 | -108/+62 |
| | | |||||
* | | internal: refactor missing match arms diagnostics | Aleksey Kladov | 2021-06-13 | 4 | -930/+935 |
| | | |||||
* | | internal: remove DiagnosticWithFix infra | Aleksey Kladov | 2021-06-13 | 4 | -585/+534 |
| | | |||||
* | | internal: refactor incorrect case diagnostics | Aleksey Kladov | 2021-06-13 | 6 | -79/+49 |
| | | |||||
* | | minor | Aleksey Kladov | 2021-06-13 | 2 | -38/+38 |
| | | |||||
* | | internal: refactor find_map diagnostic | Aleksey Kladov | 2021-06-13 | 6 | -193/+192 |
| | | |||||
* | | minor | Aleksey Kladov | 2021-06-13 | 3 | -44/+34 |
| | | |||||
* | | internal: refactor missing or or some diagnostic | Aleksey Kladov | 2021-06-13 | 5 | -58/+44 |
| | | |||||
* | | internal: refactor remove this semicolon diagnostics | Aleksey Kladov | 2021-06-13 | 8 | -83/+71 |
| | | |||||
* | | internal: refactor mismatched args count diagnostic | Aleksey Kladov | 2021-06-13 | 4 | -280/+279 |
| | | |||||
* | | internal: refactor missing unsafe diagnostic | Aleksey Kladov | 2021-06-13 | 4 | -107/+106 |
| | | |||||
* | | internal: refactor BreakOutsideOfLoop diagnostic | Aleksey Kladov | 2021-06-13 | 4 | -32/+36 |
| | | |||||
* | | internal: refactor NoSuchField diagnostic | Aleksey Kladov | 2021-06-13 | 5 | -314/+300 |
| | | |||||
* | | internal: refactor unimplemented builtin macro diagnostic | Aleksey Kladov | 2021-06-13 | 4 | -31/+33 |
| | | |||||
* | | minor: simplify | Aleksey Kladov | 2021-06-13 | 6 | -35/+18 |
| | | |||||
* | | internal: check diagnostics in all files and not just the first one | Aleksey Kladov | 2021-06-13 | 6 | -50/+84 |
| | | |||||
* | | Merge #9249 | bors[bot] | 2021-06-13 | 11 | -562/+398 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | 9249: internal: remove def-level diagnostics tests r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | | internal: remove def-level diagnostics tests | Aleksey Kladov | 2021-06-13 | 3 | -171/+21 |
| | | | |||||
| * | | internal: refactor macro error | Aleksey Kladov | 2021-06-13 | 7 | -198/+178 |
| | | | |||||
| * | | internal: refactor unresolved proc macro diagnostic | Aleksey Kladov | 2021-06-13 | 5 | -61/+59 |
| | | | |||||
| * | | internal: refactor inactive code diagnostics | Aleksey Kladov | 2021-06-13 | 6 | -133/+141 |
| | | | |||||
* | | | Merge #9248 | bors[bot] | 2021-06-13 | 7 | -186/+220 |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | 9248: internal: refactor unresolved macro call diagnostic r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | | internal: refactor unresolved macro call diagnostic | Aleksey Kladov | 2021-06-13 | 5 | -95/+94 |
| | | | |||||
| * | | internal: refactor unresolved import diagnostic | Aleksey Kladov | 2021-06-13 | 6 | -92/+127 |
| | | | |||||
* | | | Merge #9247 | bors[bot] | 2021-06-13 | 5 | -54/+60 |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | 9247: internal: refactor unresolved extern crate diagnostic r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | | internal: refactor unresolved extern crate diagnostic | Aleksey Kladov | 2021-06-13 | 5 | -54/+60 |
| | | | |||||
* | | | Merge #9246 | bors[bot] | 2021-06-13 | 8 | -401/+342 |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | 9246: internal: unified missing fields diagnostic r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | | internal: unified missing fields diagnostic | Aleksey Kladov | 2021-06-13 | 5 | -142/+94 |
| | | | |||||
| * | | internal: move missing_fields diagnostics | Aleksey Kladov | 2021-06-13 | 6 | -109/+98 |
| | | | |||||
* | | | Merge #9245 | bors[bot] | 2021-06-13 | 6 | -82/+119 |
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | 9245: internal: start new diagnostics API r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]> | ||||
| * | | internal: start new diagnostics API | Aleksey Kladov | 2021-06-13 | 6 | -82/+119 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the moment, this moves only a single diagnostic, but the idea is reafactor the rest to use the same pattern. We are going to have a single file per diagnostic. This file will define diagnostics code, rendering range and fixes, if any. It'll also have all of the tests. This is similar to how we deal with assists. After we refactor all diagnostics to follow this pattern, we'll probably move them to a new `ide_diagnostics` crate. Not that we intentionally want to test all diagnostics on this layer, despite the fact that they are generally emitted in the guts on the compiler. Diagnostics care to much about the end presentation details/fixes to be worth-while "unit" testing. So, we'll unit-test only the primary output of compilation process (types and name res tables), and will use integrated UI tests for diagnostics. | ||||
* | | | Merge #9244 | bors[bot] | 2021-06-13 | 5 | -36/+154 |
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | 9244: feat: Make block-local trait impls work r=flodiebold a=flodiebold As long as either the trait or the implementing type are defined in the same block. CC #8961 Co-authored-by: Florian Diebold <[email protected]> | ||||
| * | | Make block-local trait impls work | Florian Diebold | 2021-06-13 | 5 | -36/+154 |
| | | | | | | | | | | | | | | | As long as either the trait or the implementing type are defined in the same block. | ||||
* | | | internal: check that coverage marks are always paired | Aleksey Kladov | 2021-06-13 | 2 | -5/+6 |
| | | | |||||
* | | | minor: put a mark back | Aleksey Kladov | 2021-06-13 | 2 | -0/+2 |
|/ / | |||||
* | | Merge #9242 | bors[bot] | 2021-06-13 | 131 | -395/+366 |
|\ \ | | | | | | | | | | | | | | | | | | | | | | 9242: Clippy r=matklad a=Maan2003 Best viewed commit wise Co-authored-by: Maan2003 <[email protected]> | ||||
| * | | cargo fmt | Maan2003 | 2021-06-13 | 9 | -61/+38 |
| | | | |||||
| * | | clippy::redundant_field_names | Maan2003 | 2021-06-13 | 6 | -7/+7 |
| | | | |||||
| * | | clippy::manual_str_repeat | Maan2003 | 2021-06-13 | 2 | -3/+3 |
| | | | |||||
| * | | clippy::useless_return | Maan2003 | 2021-06-13 | 10 | -15/+15 |
| | | | |||||
| * | | clippy::redundant_closure | Maan2003 | 2021-06-13 | 12 | -17/+17 |
| | | |