aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Merge #2668bors[bot]2019-12-2917-8/+1843
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2668: In-server cargo check watching r=matklad a=kiljacken Opening a draft now so people can follow the progress, and comment if they spot something stupid. Things that need doing: - [x] Running cargo check on save - [x] Pipe through configuration options from client - [x] Tests for parsing behavior - [x] Remove existing cargo watch support from VSCode extension - [x] Progress notification in VSCode extension using LSP 3.15 `$/progress` notification - [ ] ~~Rework ra-ide diagnostics to support secondary messages~~ - [ ] ~~Make cargo-check watcher use ra-ide diagnostics~~ ~~I'd love some input on whether to try to keep the status bar progress thingy for VSCode? It will require some plumbing, and maintaining yet another rust-analyzer specific LSP notification, which I'm not sure we want to.~~ Fixes #1894 Co-authored-by: Emil Lauridsen <[email protected]>
| * Fix busy-waiting issue in main cargo watch threadEmil Lauridsen2019-12-271-3/+5
| |
| * Don't finish main cargo watch thread when subprocess finishes.Emil Lauridsen2019-12-272-3/+5
| |
| * Fix shutdown behavoir of main cargo-watch thread.Emil Lauridsen2019-12-271-7/+8
| | | | | | | | | | Even though this didn't error, it became clear to me that it was closing the wrong channel, resulting in the child thread never finishing.
| * Add doc comment to moduleEmil Lauridsen2019-12-271-0/+2
| |
| * Cargo fmt runEmil Lauridsen2019-12-271-7/+1
| |
| * Shutdown/cancelation story for main cargo watch threadEmil Lauridsen2019-12-271-15/+32
| |
| * Consistent, hopefully robust, shutdown/cancelation story for cargo check ↵Emil Lauridsen2019-12-271-16/+50
| | | | | | | | subprocess
| * Move cargo watch functionality to separate crateEmil Lauridsen2019-12-2715-1336/+1358
| |
| * Keep VSCode config mostly backwards compatibleEmil Lauridsen2019-12-254-49/+31
| |
| * Some documentatioNEmil Lauridsen2019-12-251-0/+13
| |
| * Actually respect disabling cargo check functionalityEmil Lauridsen2019-12-251-3/+19
| |
| * Re-format ra_lsp_server changesEmil Lauridsen2019-12-253-7/+7
| |
| * Re-implement status display using LSP 3.15 progress eventEmil Lauridsen2019-12-252-9/+52
| |
| * Migrate tests from extension to rustEmil Lauridsen2019-12-258-0/+1068
| |
| * Fix use of wrong message in diagnosticEmil Lauridsen2019-12-251-1/+1
| |
| * Configuration plumbing for cargo watcherEmil Lauridsen2019-12-254-10/+55
| |
| * Initial implementation of cargo check watchingEmil Lauridsen2019-12-257-4/+598
| |
* | Merge #2667bors[bot]2019-12-2920-113/+608
|\ \ | | | | | | | | | | | | | | | | | | | | | 2667: Visibility r=matklad a=flodiebold This adds the infrastructure for handling visibility (for fields and methods, not in name resolution) in the HIR and code model, and as a first application hides struct fields from completions if they're not visible from the current module. (We might want to relax this again later, but I think it's ok for now?) Co-authored-by: Florian Diebold <[email protected]>
| * | visible_from -> is_visible_fromFlorian Diebold2019-12-274-10/+10
| | |
| * | Remove Arc from RawVisibilityFlorian Diebold2019-12-261-11/+6
| | | | | | | | | | | | | | | Now that it's not used as a direct query return value anymore, it doesn't need to be cheaply cloneable anymore.
| * | Fix cross-crate glob privacy handlingFlorian Diebold2019-12-263-6/+28
| | |
| * | Remove visibility query, instead add struct field visibility to dataFlorian Diebold2019-12-265-102/+35
| | | | | | | | | | | | | | | Methods should be handled the same, and for items the visibility will be in the def map.
| * | Rename ResolvedVisibility -> VisibilityFlorian Diebold2019-12-268-67/+54
| | |
| * | Rename Visibility -> RawVisibilityFlorian Diebold2019-12-266-40/+40
| | |
| * | Handle privacy for modulesFlorian Diebold2019-12-263-11/+36
| | |
| * | Take visibility into account for glob importsFlorian Diebold2019-12-267-43/+165
| | |
| * | Keep track of visibility during def collectionFlorian Diebold2019-12-266-54/+120
| | |
| * | Collect visibility of items during nameresFlorian Diebold2019-12-266-19/+63
| | |
| * | Add doc commentFlorian Diebold2019-12-261-0/+2
| | |
| * | Make enum variant fields publicFlorian Diebold2019-12-261-2/+9
| | |
| * | Hide completions for private struct fieldsFlorian Diebold2019-12-261-1/+56
| | |
| * | Add visibility in code model for fieldsFlorian Diebold2019-12-262-3/+20
| | |
| * | Add logic for resolving and checking visibilityFlorian Diebold2019-12-262-1/+60
| | |
| * | Add infrastructure for visibility on syntax and hir_def levelFlorian Diebold2019-12-265-2/+163
| | |
* | | Merge #2657bors[bot]2019-12-273-18/+62
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | 2657: Omit closure parameters in closure type display strings r=flodiebold a=SomeoneToIgnore Part of https://github.com/rust-analyzer/rust-analyzer/issues/1946 I wonder, should we display the the closure trait (Fn/FnMut/FnOnce) in inlay hints instead of `|...|` at all? Co-authored-by: Kirill Bulatov <[email protected]>
| * | Omit closure parametersKirill Bulatov2019-12-233-18/+62
| | |
* | | Merge #2658bors[bot]2019-12-251-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2658: Only add features flags if non-empty r=matklad a=edwin0cheng This prevent error when disabled `all-features` in a cargo workspace, because of `--features is not allowed in the root of a virtual workspace` when running `cargo metadata`. Co-authored-by: Edwin Cheng <[email protected]>
| * | | Only add features flags if non-emptyEdwin Cheng2019-12-231-1/+1
| | | |
* | | | Merge #2663bors[bot]2019-12-254-26/+140
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | 2663: Fill in type params in 'add missing impl members' assist r=flodiebold a=flodiebold Co-authored-by: Florian Diebold <[email protected]>
| * | | Fill in type params in 'add missing impl members' assistFlorian Diebold2019-12-244-26/+140
| | |/ | |/|
* | | Merge #2661bors[bot]2019-12-245-3/+110
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2661: Implement infer await from async function r=flodiebold a=edwin0cheng This PR is my attempt for trying to add support for infer `.await` expression from an `async` function, by desugaring its return type to `Impl Future<Output=RetType>`. Note that I don't know it is supposed to desugaring it in that phase, if it is not suitable in current design, just feel free to reject it :) r=@flodiebold Co-authored-by: Edwin Cheng <[email protected]>
| * | Remove AsyncOwnerEdwin Cheng2019-12-245-13/+6
| | |
| * | Check if parameters is emptyEdwin Cheng2019-12-241-4/+6
| | |
| * | Add FIXMEEdwin Cheng2019-12-241-1/+5
| | |
| * | FormattingEdwin Cheng2019-12-242-3/+4
| | |
| * | Implement infer await from async funcEdwin Cheng2019-12-247-5/+112
| |/
* | lsp-types 0.67Jeremy Kolb2019-12-232-1/+2
| |
* | Merge #2636bors[bot]2019-12-237-278/+326
|\ \ | | | | | | | | | | | | | | | | | | | | | 2636: Chalk update and refactoring r=flodiebold a=flodiebold This updates the Chalk integration to https://github.com/rust-lang/chalk/pull/311, which will presumably get merged soon, and refactors it some more, most notably introducing our own `TypeFamily` instead of reusing `ChalkIr`. It's still mostly the same as `ChalkIr` though, except for using Salsa `InternId`s directly. Co-authored-by: Florian Diebold <[email protected]>
| * | Filter out error predicates in type bounds as wellFlorian Diebold2019-12-222-2/+29
| | |