aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge #4596bors[bot]2020-05-271-1/+59
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4596: Strip leading underscores of argument names in function/method r=matklad a=kuy Closes #4510 ### Goal When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names. ### Solution - Option 1: All signatures don't contain underscores - Option 2: Keep same signature, but inserted snippet doesn't contain underscores I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE. ### Other impls. rls: Complete argument names with underscores (same as actual ra) IntelliJ Rust: Doesn't complete argument names VSCode (TypeScript): Doesn't complete argument names ### Working example ![Screen Shot 2020-05-25 at 0 03 21](https://user-images.githubusercontent.com/151614/82757771-a05e5b80-9e1d-11ea-9dbc-1263c960e2ae.png) Co-authored-by: Yuki Kodama <[email protected]>
| * | | Trim at presentation layerYuki Kodama2020-05-252-4/+2
| | | |
| * | | Fix test to consider multiple underscoresYuki Kodama2020-05-251-7/+7
| | | |
| * | | Use built-in methodYuki Kodama2020-05-251-11/+5
| | | |
| * | | Separate assertionsYuki Kodama2020-05-251-7/+65
| | | |
| * | | Reflect test caseYuki Kodama2020-05-251-7/+7
| | | |
| * | | Strip leading underscoreYuki Kodama2020-05-251-2/+10
| | | |
| | | |
| \ \ \
*-. \ \ \ Merge #4625 #4629bors[bot]2020-05-271-3/+3
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4625: Partially fix displaying inlay hints in Github PR diff views r=matklad a=Veetaha See the comment in https://github.com/rust-analyzer/rust-analyzer/issues/4608#issuecomment-63424257 It partially fixes the left side of diff view (the one where old code is displayed), but the diff editor with new code changes still has `file` scheme and will proceed displaying inlay hints... 4629: Fix the `should_panic` snippet r=matklad a=eminence Closes #4628 Co-authored-by: veetaha <[email protected]> Co-authored-by: Andrew Chin <[email protected]>
| | * | | | Fix the `should_panic` snippetAndrew Chin2020-05-261-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | Closes #4628
* | | | | | Merge #4622bors[bot]2020-05-274-43/+40
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4622: Pass trivially copy types as copy r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | | | Pass trivially copy types as copykjeremy2020-05-264-43/+40
| |/ / / /
* / / / / Update lexerkjeremy2020-05-261-1/+1
|/ / / /
* | | | Merge #4534bors[bot]2020-05-261-0/+59
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4534: Add call postfix completion r=matklad a=vain0x To make it easier to wrap an expression with Ok/Some/Rc::new etc. Note I agree with conclusion of the discussion in #1431 that adding many completions is not the way to go. However, this PR still could be justified due to versatility of use. Co-authored-by: vain0x <[email protected]>
| * | | | Add call postfix completionvain0x2020-05-201-0/+59
| | | | | | | | | | | | | | | | | | | | To make it easier to wrap an expression with Ok/Some/Rc::new etc.
* | | | | Hover tooltip module name is monospace once againAaron Loucks2020-05-263-9/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The line separator is moved below the function signature to split regions between the docs. This is very similar to how IntelliJ displays tooltips. Adding an additional separator between the module name and function signature currently has rendering issues. Fixes #4594 Alternative to #4615
* | | | | Fix some clippy perf warningsJeremy Kolb2020-05-254-9/+8
| |/ / / |/| | |
| | | |
| \ \ \
*-. \ \ \ Merge #4602 #4603bors[bot]2020-05-255-4/+9
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4602: Add boolean literal semantic token type to package.json r=matklad a=lnicola Closes #4583. CC @GrayJack 4603: Add self keyword semantic token type r=matklad a=lnicola Not sure if this is warranted a new token type or just a modifier. --- CC #4583, @GrayJack Co-authored-by: Laurențiu Nicola <[email protected]>
| | * | | | Add self keyword semantic token typeLaurențiu Nicola2020-05-255-4/+9
| |/ / / /
* | | | | Document `parentModule` experimental LSP requestAleksey Kladov2020-05-254-29/+25
| | | | |
* | | | | Cleanup lsp extensions on the client sideAleksey Kladov2020-05-252-9/+4
| | | | |
* | | | | Less rust-analyzer specific onEnterAleksey Kladov2020-05-257-48/+43
|/ / / /
* | | | Merge #4593bors[bot]2020-05-243-20/+18
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4593: Document some rust-analyzer specific protocol extensions r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | | | Fix formattingAleksey Kladov2020-05-242-4/+1
| | | | |
| * | | | Document some rust-analyzer specific protocol extensionsAleksey Kladov2020-05-241-7/+8
| | | | |
| * | | | Document matchingBrace LSP requestAleksey Kladov2020-05-243-12/+12
| | | | |
* | | | | Handle more cases in `highlight_name_by_syntax`Matthew Jasper2020-05-241-11/+19
| | | | |
* | | | | Highlight `true` and `false` as literalsMatthew Jasper2020-05-249-1/+11
|/ / / /
* | | | Fix testsAleksey Kladov2020-05-241-25/+25
| | | |
* | | | Merge pull request #4548 from bnjjj/fix_4464Aleksey Kladov2020-05-248-19/+231
|\ \ \ \ | | | | | | | | | | add support of feature flag for runnables
| * | | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-242-15/+1
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-235-99/+142
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-222-21/+9
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-21116-1915/+2702
| |\ \ \ \ | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | | | | add support of feature flag for runnables #4464Benjamin Coenen2020-05-217-19/+212
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | | | Merge pull request #4495 from vsrs/fixture_metaAleksey Kladov2020-05-247-77/+326
|\ \ \ \ \ \ | | | | | | | | | | | | | | Test fixtures parsing improvements
| * | | | | | JFF, ra_fixture arg name for a code highlightingvsrs2020-05-161-9/+11
| | | | | | |
| * | | | | | smoke testvsrs2020-05-161-0/+6
| | | | | | |
| * | | | | | Propogate fixture meta to AnalysisHostvsrs2020-05-165-16/+113
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Except crate name.
| * | | | | | Use FixtureMeta in MockAnalysisvsrs2020-05-162-17/+85
| | | | | | |
| * | | | | | Remove temporary FixtureEntry parsed_meta field.vsrs2020-05-164-11/+10
| | | | | | |
| * | | | | | Reimplement ra_db::fixture::ParsedMetavsrs2020-05-162-51/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | in terms of test_utils::FixtureMeta
| * | | | | | parse fixture meta in test_utils cratevsrs2020-05-162-1/+101
| | | | | | |
* | | | | | | Merge pull request #4474 from georgewfraser/color_attrsAleksey Kladov2020-05-245-3/+11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Color attribute functions
| * | | | | | | Color attribute functionsGeorge Fraser2020-05-195-3/+11
| | | | | | | |
* | | | | | | | Some FIXMEs were outdated:Julian Wollersberger2020-05-241-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Done at line 243: "Add validation of `crate` keyword not appearing in the middle of the symbol path" * Already happened: "Remove validation of unterminated literals (it is already implemented in `tokenize()`)" * Happens in `unescape()`: "Add validation of character literal containing only a single char" * Missing: "raw string literals and raw byte string literals"
* | | | | | | | Update to rustc_lexer version 660.Julian Wollersberger2020-05-243-11/+12
| |_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | Change `unescape_*()` to `unescape_literal()`.
| | | | | | |
| \ \ \ \ \ \
*-. \ \ \ \ \ \ Merge #4555 #4575bors[bot]2020-05-237-18/+179
|\ \ \ \ \ \ \ \ | | |_|_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4555: VSCode: added patchelf after download for NixOS support r=matklad a=cab404 This adds Nix support, and fixes #4542 4575: Use Chalk's built-in representations for fn items and pointers r=matklad a=flodiebold The `TypeName::FnDef` was just added; the function pointer variant has existed for a while, I just forgot about it because it's special (because fn pointers can be higher-ranked over lifetimes). We *could* also make `FnPtr` a separate `Ty` variant instead of a `TypeCtor` variant, which would make the conversion code a bit less special-casey, but it doesn't seem worth doing right now. Co-authored-by: Vladimir Serov <[email protected]> Co-authored-by: Cabia Rangris <[email protected]> Co-authored-by: Florian Diebold <[email protected]>
| | * | | | | | Use Chalk's Ty::Function for function pointer typesFlorian Diebold2020-05-222-8/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Function pointers can be 'higher-ranked' over lifetimes, which is why they're not an application type in Chalk, but since we don't model lifetimes it doesn't matter for us yet.
| | * | | | | | Use Chalk's built-in representation of function item typesFlorian Diebold2020-05-227-10/+128
| | | | | | | |
* | | | | | | | Merge #4578bors[bot]2020-05-234-7/+5
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4578: Remove unnecessary clone that prevented clippy from moving on r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-04 10:51:30 +0000