aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Reduce visibilityKirill Bulatov2020-01-151-1/+1
| | | | |
* | | | | itertools::Either -> either::EitherKirill Bulatov2020-01-156-6/+6
| | | | |
* | | | | Apply the api design suggestionsKirill Bulatov2020-01-156-46/+79
| | | | |
* | | | | Another attempt to add multiple editsKirill Bulatov2020-01-156-25/+84
| | | | |
* | | | | More orthogonal path editingAleksey Kladov2020-01-153-19/+54
| | | | |
* | | | | More fluent APIAleksey Kladov2020-01-151-10/+12
| | | | |
* | | | | Slightly more fluent APIAleksey Kladov2020-01-152-14/+14
| | | | |
* | | | | SimplifyAleksey Kladov2020-01-151-5/+8
| | | | |
* | | | | SimplifyAleksey Kladov2020-01-151-7/+5
| | | | |
* | | | | RenameAleksey Kladov2020-01-153-17/+14
|/ / / /
* | | | Extract check task handling into functionEmil Lauridsen2020-01-151-47/+56
| | | |
* | | | Tweak naming slightlyEmil Lauridsen2020-01-151-5/+5
| | | |
* | | | Manage check state updates in main_loop to reduce lock contentionEmil Lauridsen2020-01-153-44/+64
| | | |
* | | | Don't parse child modules when doing diagnosticsAleksey Kladov2020-01-152-3/+10
| | | |
* | | | lsp-types 0.69.0Jeremy Kolb2020-01-152-2/+2
| | | | | | | | | | | | | | | | Stabilizes most proposed features
* | | | Merge #2843bors[bot]2020-01-154-2/+161
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2843: Add inlay parameter name hints for call expr r=matklad a=imtsuki This patch adds Intellij-like parameter name hints for literal values in function calls. <img width="624" alt="Screenshot" src="https://user-images.githubusercontent.com/8423594/72366533-68d7f800-3735-11ea-9279-cf193ca8ca2f.png"> Signed-off-by: imtsuki <[email protected]> Co-authored-by: imtsuki <[email protected]>
| * | | | FnSignature: use unwrap_or_default for parameter_name_listimtsuki2020-01-151-5/+3
| | | | | | | | | | | | | | | | | | | | Signed-off-by: imtsuki <[email protected]>
| * | | | Update test snapshotimtsuki2020-01-141-2/+2
| | | | | | | | | | | | | | | | | | | | Signed-off-by: imtsuki <[email protected]>
| * | | | Add inlay parameter name hints for function callsimtsuki2020-01-144-2/+163
| | | | | | | | | | | | | | | | | | | | Signed-off-by: imtsuki <[email protected]>
* | | | | Cleanup assertkjeremy2020-01-141-5/+1
| |/ / / |/| | |
* | | | Merge #2841bors[bot]2020-01-1426-42/+59
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2841: More UI friendly labels r=kjeremy a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | | | unwrapJeremy Kolb2020-01-141-2/+2
| | | | |
| * | | | Assert that first letter is capitalizedJeremy Kolb2020-01-141-0/+6
| | | | |
| * | | | Fix casingJeremy Kolb2020-01-1421-30/+33
| | | | |
| * | | | More UI friendly labelsJeremy Kolb2020-01-1423-35/+43
| | | | |
* | | | | Merge #2844bors[bot]2020-01-142-85/+15
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2844: Use dummy value for line! and column! macro r=matklad a=edwin0cheng Use dummy value `0` for line! and column! macro. Co-authored-by: Edwin Cheng <[email protected]>
| * | | | | Use dummy value for line! and column! macroEdwin Cheng2020-01-142-85/+15
| | | | | |
* | | | | | Merge #2834bors[bot]2020-01-141-35/+26
|\ \ \ \ \ \ | |_|/ / / / |/| | | / / | | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2834: refactor(ra_syntax.validation): removed code duplication from validate_literal() r=kiljacken a=Veetaha Hi! This is my first ever contribution to this project. I've taken some dirty job from issue #223 This is a simple atomic PR to remove code duplication according to FIXME comment in the function that is the main focus of the further development. I just didn't want to mix refactoring with the implementation of new features... I am not sure whether you prefer such atomic PRs here or you'd rather have a single PR that contains all atomic commits inside of it? So if you want me to add all that validation in one PR I'll mark this one as WIP and update it when the work is finished, otherwise, I'll go with the option of creating separate PRs per each feature of validation of strings, numbers, and comments respectively. ### Comments about refactoring Yeah, reducing the duplication is quite hard here, extracting into stateless functions could be another option but the number of their arguments would be very big and repeated across char and string implementations so that just writing their types and names would become cumbersome. I tried the option of having everything captured implicitly in the closure but failed since rust doesn't have templated (or generic) closures as C++ does, this is needed because `unescape_byte*()` and `unescape_char|str()` have different return types... Maybe I am missing something here? I may be wrong because I am not enough experienced in Rust... Well, I am awaiting any kind of feedback! Co-authored-by: Veetaha <[email protected]>
| * | | | refactor(ra_syntax.validation): removed code duplication from ↵Veetaha2020-01-141-35/+26
| | |/ / | |/| | | | | | | | | | validate_literal() function
* | | | Merge #2839bors[bot]2020-01-142-1/+5
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2839: Tweak add_custom_impl r=matklad a=kjeremy Display a nicer label and categorize Co-authored-by: Jeremy Kolb <[email protected]>
| * | | | Tweak add_custom_implJeremy Kolb2020-01-142-1/+5
| | | | |
* | | | | Move Type API to typeAleksey Kladov2020-01-144-85/+102
| | | | |
* | | | | Push resolver further upAleksey Kladov2020-01-144-27/+60
| | | | |
* | | | | Push resolver upAleksey Kladov2020-01-141-21/+51
|/ / / /
* | | | Move impls_future to Type, where it belongsAleksey Kladov2020-01-144-28/+21
| | | |
* | | | Use lang-items to resolve future traitAleksey Kladov2020-01-142-10/+10
| | | |
* | | | Move utility functions downAleksey Kladov2020-01-141-58/+58
| | | |
* | | | Rename fileAleksey Kladov2020-01-142-2/+2
|/ / /
* | | Log client info if presentkjeremy2020-01-131-0/+4
| | |
* | | Don't panic if chalk panicsAleksey Kladov2020-01-131-9/+35
| | |
* | | Merge #2825bors[bot]2020-01-139-45/+44
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2825: Some clippy lints r=matklad a=kjeremy Co-authored-by: kjeremy <[email protected]>
| * | | Readabilitykjeremy2020-01-132-6/+6
| | | |
| * | | Some clippy lintskjeremy2020-01-1310-46/+45
| | | |
* | | | Schedule check update regardless of notification settingEmil Lauridsen2020-01-131-1/+1
| | | |
* | | | Defer cargo check until after workspace loadEmil Lauridsen2020-01-132-2/+12
|/ / /
* / / Dropping a reference does nothing.kjeremy2020-01-131-1/+0
|/ / | | | | | | Allows clippy to continue compilation
* | Merge #2815bors[bot]2020-01-131-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | 2815: Report macro calls as functions r=matklad a=kjeremy Co-authored-by: Jeremy Kolb <[email protected]>
| * | Report macro calls as functionsJeremy Kolb2020-01-121-0/+1
| | |
* | | Add macro_rules item snippetmemoryruins2020-01-121-0/+8
|/ /
* | Remove hir usage from macro_rules! detection in structure_node()Roland Ruckerbauer2020-01-122-6/+3
| |