aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Support function's completion snippetAvishay Matayev2020-03-042-14/+22
| | | | | | | Note that `detail` was replced with `function_signature` to avoid calling `from` on FunctionSignature twice. I didn't add new tests because the current ones seem enough.
* Merge #3429bors[bot]2020-03-042-2/+39
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3429: Fix panic on eager expansion r=matklad a=edwin0cheng When lazy expanding inside an eager macro, its *parent* file of that lazy macro call must be already exists such that a panic is occurred because that parent file is the eager macro we are processing. This PR fix this bug by store the argument syntax node as another eager macro id for that purpose. Personally I don't know if it is a good answer for this bug. Co-authored-by: Edwin Cheng <[email protected]>
| * Fixed a typo in commentEdwin Cheng2020-03-031-1/+1
| |
| * Fix panic on eager expansionEdwin Cheng2020-03-032-2/+39
| |
* | Fix completion snippet for reexported functionsFlorian Diebold2020-03-032-4/+54
| | | | | | | | Fixes #3356.
* | Merge #3428bors[bot]2020-03-038-122/+90
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | 3428: Move reference classification to ra_ide_db r=matklad a=matklad Lost some marks along the way :-( bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix importsAleksey Kladov2020-03-035-19/+14
| |
| * Move reference classification to ra_ide_dbAleksey Kladov2020-03-035-104/+77
| | | | | | | | Lost some marks along the way :-(
* | Merge #3427bors[bot]2020-03-038-106/+103
|\| | | | | | | | | | | | | | | | | | | | | 3427: Rename NameDefinition -> Definition r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Rename NameDefinition -> DefinitionAleksey Kladov2020-03-038-106/+103
| |
* | Merge #3392bors[bot]2020-03-0311-82/+399
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3392: Implement concat eager macro r=matklad a=edwin0cheng This PR implements the following things: 1. Add basic eager macro infrastructure by introducing `EagerCallId` such that the new `MacroCallId` is defined as : ``` #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] pub enum MacroCallId { LazyMacro(LazyMacroId), EagerMacro(EagerMacroId), } ``` 2. Add `concat!` builtin macro. Co-authored-by: Edwin Cheng <[email protected]>
| * Fix for rebasingEdwin Cheng2020-03-031-3/+14
| |
| * Move pub function firstEdwin Cheng2020-03-031-24/+24
| |
| * Add doc about eager expansion name resolutionEdwin Cheng2020-03-031-0/+19
| |
| * Add testEdwin Cheng2020-03-031-0/+19
| |
| * Implement concat macroEdwin Cheng2020-03-0310-77/+305
| |
| * Add LazyMacroIdEdwin Cheng2020-03-035-16/+56
| |
* | Merge #3426bors[bot]2020-03-033-27/+74
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 3426: Refactor reference search a bit r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Refactor reference search a bitAleksey Kladov2020-03-033-27/+74
| |
* | Merge #3425bors[bot]2020-03-033-6/+16
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | 3425: Fix a bug for single dollar sign macro r=matklad a=edwin0cheng This PR fixed a bug to allow the following valid `macro_rules!` : ```rust macro_rules! m { ($) => ($) } ``` Co-authored-by: Edwin Cheng <[email protected]>
| * Fix a bug for single dollar sign macroEdwin Cheng2020-03-033-6/+16
| |
* | Merge #3422bors[bot]2020-03-031-0/+1
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3422: Add profile call r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add profile callAleksey Kladov2020-03-031-0/+1
| | |
* | | Highlight assist testsAleksey Kladov2020-03-033-49/+53
| | |
* | | Fix applicability of inline localAleksey Kladov2020-03-033-10/+34
|/ /
* / Remove stray dbgAleksey Kladov2020-03-031-2/+2
|/
* Drop larlpop-intern depLaurențiu Nicola2020-03-032-4/+2
|
* Update chalk for Ty internersLaurențiu Nicola2020-03-022-11/+14
|
* Update chalk for RawId removalLaurențiu Nicola2020-03-022-16/+10
|
* Simplify by using to_veckjeremy2020-03-021-2/+2
|
* Merge #3406bors[bot]2020-03-022-23/+13
|\ | | | | | | | | | | | | | | | | | | | | 3406: Simplify: remove couple of useless functions r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Simplify: remove couple of useless functionsAleksey Kladov2020-03-022-23/+13
| |
* | Merge #3405bors[bot]2020-03-027-36/+79
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | 3405: More principled approach for gotodef for field shorhand r=matklad a=matklad Callers can now decide for themselves if they should prefer field or local definition. By default, it's the local. bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * More principled approach for gotodef for field shorhandAleksey Kladov2020-03-027-36/+79
| | | | | | | | | | Callers can now decide for themselves if they should prefer field or local definition. By default, it's the local.
* | lsp-types 0.72kjeremy2020-03-024-14/+11
|/
*-. Merge #3397 #3398bors[bot]2020-03-022-11/+3
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3397: Minimal viable meta r=matklad a=matklad bors r+ 🤖 3398: Reformat? r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| | * Reformat?Aleksey Kladov2020-03-022-11/+3
| |/
* | Merge #3385bors[bot]2020-03-024-6/+45
|\ \ | |/ |/| | | | | | | | | | | | | | | | | 3385: Fix #3373 r=matklad a=flodiebold Basically, we need to allow variables in the caller self type to unify with the impl's declared self type. That requires some more contortions in the variable handling. I'm looking forward to (hopefully) handling this in a cleaner way when we switch to Chalk's types and unification code. Co-authored-by: Florian Diebold <[email protected]>
| * Fix #3373Florian Diebold2020-03-014-6/+45
| | | | | | | | | | | | | | Basically, we need to allow variables in the caller self type to unify with the impl's declared self type. That requires some more contortions in the variable handling. I'm looking forward to (hopefully) handling this in a cleaner way when we switch to Chalk's types and unification code.
* | One more assertAleksey Kladov2020-03-021-1/+6
| |
* | Tighten up an assertAleksey Kladov2020-03-021-0/+4
| |
* | Merge #3387bors[bot]2020-03-012-2/+108
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3387: Type inference for slice patterns r=flodiebold a=JoshMcguigan Fixes #3043 Notes to reviewer: 1. This only works if `expected` is `Ty::Apply`. I'm not sure of the implications of this. 1. This only works if the slice pattern only has a prefix. I think this means it doesn't work for subslice patterns, which are currently only available behind a feature flag. Co-authored-by: Josh Mcguigan <[email protected]>
| * | handle array pattern matching type inferenceJosh Mcguigan2020-03-012-10/+55
| | |
| * | remove match statement, handle suffixJosh Mcguigan2020-03-012-14/+11
| | |
| * | handle arbitrary length slicesJosh Mcguigan2020-03-012-12/+29
| | |
| * | match single prefix sliceJosh Mcguigan2020-03-012-1/+48
| |/
* | Merge #3384bors[bot]2020-03-014-6/+88
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | 3384: fix #2377 super::super::* r=flodiebold a=JoshMcguigan Thanks @matklad for the detailed explanation on #2377. I believe this fixes it. One thing I'm not sure about is you said the fix would involve changing `crates/ra_hir_def/src/path/lower/lower.rs`, but I only changed `crates/ra_hir_def/src/path/lower/lower_use.rs`. I'm not sure what kind of test code I'd have to write to expose the issue in `lower.rs`, but I'd be happy to add it if you are able to provide additional guidance. closes #2377 Co-authored-by: Josh Mcguigan <[email protected]>
| * fix completion for super::super::Josh Mcguigan2020-03-012-2/+45
| |
| * fix #2377 super::super::*Josh Mcguigan2020-03-012-4/+43
| |
* | Merge #3383bors[bot]2020-02-292-70/+59
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3383: Slightly refactor inlay hints r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 19:45:28 +0000