aboutsummaryrefslogtreecommitdiff
path: root/crates
Commit message (Collapse)AuthorAgeFilesLines
* Merge #4346bors[bot]2020-05-072-2/+70
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4346: Fix rename of enum variant visible from module r=matklad a=montekki Probably fixes #4237 It looks like the ref is found correctly in this case but it's visibility is not correctly determined. I took a stab at fixing that by adding an implementation of `HasVisibility` for `EnumVariant` so it works more or less the same way it does for struct fields. In other words, the `search_range` here does not contain the ref since it's not considered visible: https://github.com/rust-analyzer/rust-analyzer/blob/efd8e34c396f1524623a495e47111f1047cf2879/crates/ra_ide_db/src/search.rs#L209-L214 Before that I tried to populate `ItemScope` with visible enum variants but that ended up with breaking tests all over the place and also it looked illogical in the end: `ItemScope` is not populated with, say, public struct fields and the same should be true for `enum` variants. I've added two more or less identical tests: one for the case with a struct field rename and one for enum variant rename; the test for struct should probably be removed and the names should be changed. Co-authored-by: Fedor Sakharov <[email protected]>
| * Remove HasVisibility implementationFedor Sakharov2020-05-073-12/+6
| |
| * Fix rename of enum variant visible from moduleFedor Sakharov2020-05-064-2/+76
| |
* | SimplifyAleksey Kladov2020-05-075-6/+5
| |
* | Nicer APIAleksey Kladov2020-05-073-42/+42
| |
* | Rename AssitLabel -> AssistAleksey Kladov2020-05-074-24/+24
| |
* | Refactor assists API to be more convenient for adding new assistsAleksey Kladov2020-05-0738-593/+521
| | | | | | | | It now duplicates completion API in its shape.
* | Fix panic in FunctionSignatureAleksey Kladov2020-05-071-1/+7
| |
* | Merge #4316 #4351bors[bot]2020-05-061-4/+45
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4316: do not truncate display for hover r=matklad a=bnjjj close #4311 4351: Fix Windows server path r=matklad a=lnicola CC @Coder-256. Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | do not truncate display for hoverBenjamin Coenen2020-05-061-2/+2
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | do not truncate display for hoverBenjamin Coenen2020-05-061-1/+42
| | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
| * | Merge branch 'master' of github.com:rust-analyzer/rust-analyzer into fix_4311Benjamin Coenen2020-05-0655-425/+634
| |\ \
| * | | do not truncate display for hover #4311Benjamin Coenen2020-05-051-1/+1
| | | | | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | Merge #4331bors[bot]2020-05-062-10/+140
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4331: Fixture improvements r=TimoFreiberg a=TimoFreiberg As mentioned in [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/resolve_path.20between.20fixture.20files) :) I think always allowing unindented first lines is friendlier than making the user fix it and I don't see any drawbacks. Co-authored-by: Timo Freiberg <[email protected]>
| * | | | Allow fixture strings with unindented first lineTimo Freiberg2020-05-061-9/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows fixtures like "//- /lib.rs ... //- /foo.rs ... "
| * | | | Add fixture doc commentTimo Freiberg2020-05-061-1/+45
| | | | |
* | | | | add Ok wrappingBenjamin Coenen2020-05-063-0/+986
|/ / / / | | | | | | | | | | | | Signed-off-by: Benjamin Coenen <[email protected]>
* | | | Merge #4347bors[bot]2020-05-061-6/+23
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4347: Fix usefulness check for never type r=flodiebold a=MikailBag Co-authored-by: Mikail Bagishov <[email protected]>
| * | | | Fix usefulness check for never typeMikail Bagishov2020-05-061-6/+23
| | |_|/ | |/| |
* | | | SimplifyAleksey Kladov2020-05-063-33/+17
| | | |
* | | | MinorAleksey Kladov2020-05-061-1/+2
| | | |
* | | | RenameAleksey Kladov2020-05-064-13/+13
|/ / /
* | | Use SourceChange for assistsAleksey Kladov2020-05-066-87/+60
| | |
* | | Fix TODOAleksey Kladov2020-05-063-19/+17
| | |
* | | Move target to AssistLabelAleksey Kladov2020-05-0636-256/+292
| | | | | | | | | | | | | | | Target is used for assists sorting, so we need it before we compute the action.
* | | Lift SourceChange to the ra_ide_dbAleksey Kladov2020-05-066-25/+25
| | |
* | | Fix capitalizationAleksey Kladov2020-05-061-2/+2
| | |
* | | RegenerateAleksey Kladov2020-05-062-38/+40
| | |
* | | Merge doc_tests and testsAleksey Kladov2020-05-064-41/+28
| | |
* | | Merge assits::test_helpers and testsAleksey Kladov2020-05-0635-180/+172
| |/ |/|
* | Merge #4332bors[bot]2020-05-0519-226/+271
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 4332: Refactor TextEdit r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Fixup testsAleksey Kladov2020-05-059-43/+71
| | |
| * | Use more natural signature for Edit::applyAleksey Kladov2020-05-054-20/+42
| | |
| * | Rename AtomTextEdit -> IndelAleksey Kladov2020-05-0510-162/+154
| | |
| * | Minor cleanupsAleksey Kladov2020-05-052-6/+9
| | |
* | | add the allFeatures flag (true by default)guigui642020-05-052-3/+8
|/ /
* | Merge #4327bors[bot]2020-05-058-45/+42
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4327: Refactor assists r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Normalize naming of diagnosticsAleksey Kladov2020-05-055-21/+23
| | |
| * | Fix compilationAleksey Kladov2020-05-052-13/+8
| | |
| * | Move group_label where it belongsAleksey Kladov2020-05-052-7/+6
| | |
| * | use GroupLabel for type safetyAleksey Kladov2020-05-051-3/+4
| | |
| * | Minor renameAleksey Kladov2020-05-051-3/+3
| | |
| * | Flip Assist::new argumentsAleksey Kladov2020-05-052-4/+4
| | |
* | | Merge #4325bors[bot]2020-05-051-2/+15
|\ \ \ | |/ / |/| | | | | | | | | | | | | | | | | 4325: Fix column conversion for supplementary plane characters r=matklad a=lnicola Fixes https://github.com/rust-analyzer/rust-analyzer/pull/4276#issuecomment-623079855. Co-authored-by: LaurenČ›iu Nicola <[email protected]>
| * | Fix column conversion for supplementary plane charactersLaurențiu Nicola2020-05-051-2/+15
| | |
* | | Merge #4166bors[bot]2020-05-055-7/+17
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4166: Defining a default target to support cross-compilation targets r=matklad a=FuriouZz Related to #4163 Co-authored-by: Christophe MASSOLIN <[email protected]>
| * | | Remove code duplicatesChristophe MASSOLIN2020-05-051-12/+6
| | | |
| * | | Pass cargo.target to rustcChristophe MASSOLIN2020-05-053-7/+15
| | | |
| * | | Rename `defaultTarget` to targetChristophe MASSOLIN2020-05-052-4/+4
| | | |
| * | | [config] remove RustcConfigChristophe MASSOLIN2020-04-271-5/+0
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 12:33:22 +0000