aboutsummaryrefslogtreecommitdiff
path: root/editors/code/src/commands/cargo_watch.ts
Commit message (Collapse)AuthorAgeFilesLines
* Protect against null as revealed by `npm test`kjeremy2019-12-201-2/+7
|
* Fix formattingVadzim Dambrouski2019-12-161-2/+1
|
* Add option to disable all-targets.Vadzim Dambrouski2019-12-151-1/+4
| | | | Can be useful in embedded.
* Code: enable prettier trailing commasLaurențiu Nicola2019-12-091-17/+17
|
* Adds config option for cargo-watch `--ignore` flagRoberto Vidal2019-10-171-1/+6
|
* Replace watcher file existence check with vscode.fs versionLucas Spits2019-09-091-11/+10
|
* Fix `cargo watch` code action filteringRyan Cumming2019-06-291-46/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | There are two issues with the implementation of `provideCodeActions` introduced in #1439: 1. We're returning the code action based on the file its diagnostic is in; not the file the suggested fix is in. I'm not sure how often fixes are suggested cross-file but it's something we should handle. 2. We're not filtering code actions based on the passed range. The means if there is any suggestion in a file we'll show an action for every line of the file. I naively thought that VS Code would filter for us but that was wrong. Unfortunately the VS Code `CodeAction` object is very complex - it can handle edits across multiple files, run commands, etc. This makes it complex to check them for equality or see if any of their edits intersects with a specified range. To make it easier to work with suggestions this introduces a `SuggestedFix` model object and a `SuggestFixCollection` code action provider. This is a layer between the raw Rust JSON and VS Code's `CodeAction`s. I was reluctant to introduce another layer of abstraction here but my attempt to work directly with VS Code's model objects was worse.
* Initial Visual Studio Code unit testsRyan Cumming2019-06-261-61/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As promised in #1439 this is an initial attempt at unit testing the VSCode extension. There are two separate parts to this: getting the test framework working and unit testing the code in #1439. The test framework nearly intact from the VSCode extension generator. The main thing missing was `test/index.ts` which acts as an entry point for Mocha. This was simply copied back in. I also needed to open the test VSCode instance inside a workspace as our file URI generation depends on a workspace being open. There are two ways to run the test framework: 1. Opening the extension's source in VSCode, pressing F5 and selecting the "Extensions Test" debug target. 2. Closing all copies of VSCode and running `npm test`. This is started from the command line but actually opens a temporary VSCode window to host the tests. This doesn't attempt to wire this up to CI. That requires running a headless X11 server which is a bit daunting. I'll assess the difficulty of that in a follow-up branch. This PR is at least helpful for local development without having to induce errors on a Rust project. For the actual tests this uses snapshots of `rustc` output from a real Rust project captured from the command line. Except for extracting the `message` object and reformatting they're copied verbatim into fixture JSON files. Only four different types of diagnostics are tested but they represent the main combinations of code actions and related information possible. They can be considered the happy path tests; as we encounter corner-cases we can introduce new tests fixtures.
* Fix comparison of Code Action edit lengthsRyan Cumming2019-06-251-1/+1
| | | | | This happened to work because we always produce a single edit but this is obviously dubious.
* Rich mapping of cargo watch outputRyan Cumming2019-06-251-54/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we depend on the ASCII rendering string that `rustc` provides to populate Visual Studio Code's diagnostic. This has a number of shortcomings: 1. It's not a very good use of space in the error list 2. We can't jump to secondary spans (e.g. where a called function is defined) 3. We can't use Code Actions aka Quick Fix This moves all of the low-level parsing and mapping to a `rust_diagnostics.ts`. This uses some heuristics to map Rust diagnostics to VsCode: 1. As before, the Rust diagnostic message and primary span is used for the root diagnostic. However, we now just use the message instead of the rendered version. 2. Every secondary span is converted to "related information". This shows as child in the error list and can be jumped to. 3. Every child diagnostic is categorised in to three buckets: 1. If they have no span they're treated as another line of the root messages 2. If they have replacement text they're treated as a Code Action 3. If they have a span but no replacement text they're treated as related information (same as secondary spans).
* Fix code after "apply suggestions"Aleksei Sidorov2019-06-241-4/+8
|
* Fix tslintsAleksei Sidorov2019-06-241-3/+1
|
* Introduce cargo-watch.check-commandAleksei Sidorov2019-06-241-2/+4
|
* Pass `--all-targets` to `cargo watch`Aleksi Juvani2019-05-211-1/+1
|
* cargo watch start and stop commandsBernardo2019-04-191-44/+58
|
* Fix eslint errorsEmil Lauridsen2019-04-031-1/+1
|
* Add extra double quotes only on Windows.Emil Lauridsen2019-04-031-0/+4
| | | | | | As tested by @edwin0cheng, Windows requires the quotes removed in the previous commit. This commit re-adds the quotes gated by an if statement on the node environment, so that quotes are only added on Windows.
* Fix VSCode cargo-watch functionality on Linux.Emil Lauridsen2019-04-031-2/+1
| | | | | | | | | | | | | As of #1079 the VSCode cargo-watch functionality has been broken on Linux systems. The cause seems to be that linux takes the added quotes inside process arguments literally, so it attempts to make cargo-watch run the command `cargo "check --message-format json"` with the entire quoted part being treated as a single long subcommand, which cargo doesn't know how to handle. Removing the extra quotes solves the issue.
* Add cargo-watch package animation and refactoringEdwin Cheng2019-04-021-43/+67
|
* Add Cargo.toml file check before cargo watch startEdwin Cheng2019-04-021-0/+22
|
* Add cargo-watch.check-argumentsEdwin Cheng2019-04-021-28/+50
|
* Add config for cargo-watch traceEdwin Cheng2019-04-021-7/+34
|
* Add proper process teminate methodEdwin Cheng2019-04-021-7/+10
|
* Fix prettier errorEdwin Cheng2019-04-021-11/+15
|
* Fix tslint errorEdwin Cheng2019-04-021-63/+28
|
* Improve cargo-watch usageEdwin Cheng2019-04-021-0/+168