aboutsummaryrefslogtreecommitdiff
path: root/editors/code/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge #1454bors[bot]2019-06-2910-254/+498
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1454: Fix `cargo watch` code action filtering r=etaoins a=etaoins There are two issues with the implementation of `provideCodeActions` introduced in #1439: 1. We're returning the code action based on the file its diagnostic is in; not the file the suggested fix is in. I'm not sure how often fixes are suggested cross-file but it's something we should handle. 2. We're not filtering code actions based on the passed range. The means if there is any suggestion in a file we'll show an action for every line of the file. I naively thought that VS Code would filter for us but that was wrong. Unfortunately the VS Code `CodeAction` object is very complex - it can handle edits across multiple files, run commands, etc. This makes it complex to check them for equality or see if any of their edits intersects with a specified range. To make it easier to work with suggestions this introduces a `SuggestedFix` model object and a `SuggestFixCollection` code action provider. This is a layer between the raw Rust JSON and VS Code's `CodeAction`s. I was reluctant to introduce another layer of abstraction here but my attempt to work directly with VS Code's model objects was worse. Co-authored-by: Ryan Cumming <[email protected]>
| * Comment on the key of `suggestedFixes`Ryan Cumming2019-06-291-0/+3
| | | | | | | | This isn't immediately obvious without looking at the users of the map
| * Fix `cargo watch` code action filteringRyan Cumming2019-06-2910-254/+495
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two issues with the implementation of `provideCodeActions` introduced in #1439: 1. We're returning the code action based on the file its diagnostic is in; not the file the suggested fix is in. I'm not sure how often fixes are suggested cross-file but it's something we should handle. 2. We're not filtering code actions based on the passed range. The means if there is any suggestion in a file we'll show an action for every line of the file. I naively thought that VS Code would filter for us but that was wrong. Unfortunately the VS Code `CodeAction` object is very complex - it can handle edits across multiple files, run commands, etc. This makes it complex to check them for equality or see if any of their edits intersects with a specified range. To make it easier to work with suggestions this introduces a `SuggestedFix` model object and a `SuggestFixCollection` code action provider. This is a layer between the raw Rust JSON and VS Code's `CodeAction`s. I was reluctant to introduce another layer of abstraction here but my attempt to work directly with VS Code's model objects was worse.
* | Add noUnusedLocals to VsCode tsconfigRyan Cumming2019-06-291-1/+0
|/ | | | | | `tslint` doesn't catch this because TypeScript has had this check builtin since 2.9. However, it's disabled by default so right now nothing is checking for unused variables.
* Extract lint scopes from `cargo watch`Ryan Cumming2019-06-263-6/+35
| | | | | | | | | | | Currently all of our VS Code diagnostics are given the source of `rustc`. However, if you have something like `cargo-watch.command` set to `clippy` it will also watch for Clippy lints. The `rustc` source is a bit misleading in that case. Fortunately, Rust's tool lints (RFC 2103) line up perfectly with VS Code's concept of `source`. This checks for lints scoped to a given tool and then splits them in to a `source` and tool-specific `code`.
* Initial Visual Studio Code unit testsRyan Cumming2019-06-269-61/+763
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As promised in #1439 this is an initial attempt at unit testing the VSCode extension. There are two separate parts to this: getting the test framework working and unit testing the code in #1439. The test framework nearly intact from the VSCode extension generator. The main thing missing was `test/index.ts` which acts as an entry point for Mocha. This was simply copied back in. I also needed to open the test VSCode instance inside a workspace as our file URI generation depends on a workspace being open. There are two ways to run the test framework: 1. Opening the extension's source in VSCode, pressing F5 and selecting the "Extensions Test" debug target. 2. Closing all copies of VSCode and running `npm test`. This is started from the command line but actually opens a temporary VSCode window to host the tests. This doesn't attempt to wire this up to CI. That requires running a headless X11 server which is a bit daunting. I'll assess the difficulty of that in a follow-up branch. This PR is at least helpful for local development without having to induce errors on a Rust project. For the actual tests this uses snapshots of `rustc` output from a real Rust project captured from the command line. Except for extracting the `message` object and reformatting they're copied verbatim into fixture JSON files. Only four different types of diagnostics are tested but they represent the main combinations of code actions and related information possible. They can be considered the happy path tests; as we encounter corner-cases we can introduce new tests fixtures.
* Tweak isUnusedOrUnnecessaryRyan Cumming2019-06-251-2/+8
| | | | | | | The first cut was a bit rough with the blanket `unused_*` rule. This trigger for things like `unused_mut` where the code is used but it's suboptimal. It's misleading to grey out the code in those cases. Instead, use an explicit list of things known to be dead code.
* Fix comparison of Code Action edit lengthsRyan Cumming2019-06-251-1/+1
| | | | | This happened to work because we always produce a single edit but this is obviously dubious.
* Rich mapping of cargo watch outputRyan Cumming2019-06-252-54/+352
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we depend on the ASCII rendering string that `rustc` provides to populate Visual Studio Code's diagnostic. This has a number of shortcomings: 1. It's not a very good use of space in the error list 2. We can't jump to secondary spans (e.g. where a called function is defined) 3. We can't use Code Actions aka Quick Fix This moves all of the low-level parsing and mapping to a `rust_diagnostics.ts`. This uses some heuristics to map Rust diagnostics to VsCode: 1. As before, the Rust diagnostic message and primary span is used for the root diagnostic. However, we now just use the message instead of the rendered version. 2. Every secondary span is converted to "related information". This shows as child in the error list and can be jumped to. 3. Every child diagnostic is categorised in to three buckets: 1. If they have no span they're treated as another line of the root messages 2. If they have replacement text they're treated as a Code Action 3. If they have a span but no replacement text they're treated as related information (same as secondary spans).
* Fix code after "apply suggestions"Aleksei Sidorov2019-06-243-13/+19
|
* Apply suggestions from code reviewAleksey Sidorov2019-06-241-2/+2
| | | Co-Authored-By: Aleksey Kladov <[email protected]>
* Fix tslintsAleksei Sidorov2019-06-242-5/+3
|
* Introduce cargo-watch.check-commandAleksei Sidorov2019-06-243-6/+21
|
* make LRU cache configurableAleksey Kladov2019-06-122-1/+6
|
* Make rainbows optionalPascal Hertleif2019-05-272-5/+13
|
* Semantic highlighting spikePascal Hertleif2019-05-271-3/+42
| | | | | | | | | | Very simple approach: For each identifier, set the hash of the range where it's defined as its 'id' and use it in the VSCode extension to generate unique colors. Thus, the generated colors are per-file. They are also quite fragile, and I'm not entirely sure why. Looks like we need to make sure the same ranges aren't overwritten by a later request?
* Improve highlighting of name refsLaurențiu Nicola2019-05-231-1/+6
|
* Address feedbackLaurențiu Nicola2019-05-211-3/+2
|
* Use ThemeColor and add support for light themesLaurențiu Nicola2019-05-211-13/+22
|
* Pass `--all-targets` to `cargo watch`Aleksi Juvani2019-05-211-1/+1
|
* switch to official extend selection APIAleksey Kladov2019-04-214-40/+1
|
* start cargo watch if not started interactivelyBernardo2019-04-192-2/+19
|
* cargo watch start and stop commandsBernardo2019-04-194-54/+89
|
* PrettierRoberto Vidal2019-04-161-2/+1
|
* Fixes unrelated process termination quirkRoberto Vidal2019-04-161-0/+0
|
* Adds "restart server" commandRoberto Vidal2019-04-161-1/+15
|
* Sends cwd info for runnables and code lensesRoberto Vidal2019-04-141-1/+2
|
* Adds support for multiple editor workspaces on initializationRoberto Vidal2019-04-141-7/+0
| | | | This is a quick, partial fix for #1104
* Fix eslint errorsEmil Lauridsen2019-04-031-1/+1
|
* Add extra double quotes only on Windows.Emil Lauridsen2019-04-031-0/+4
| | | | | | As tested by @edwin0cheng, Windows requires the quotes removed in the previous commit. This commit re-adds the quotes gated by an if statement on the node environment, so that quotes are only added on Windows.
* Fix VSCode cargo-watch functionality on Linux.Emil Lauridsen2019-04-031-2/+1
| | | | | | | | | | | | | As of #1079 the VSCode cargo-watch functionality has been broken on Linux systems. The cause seems to be that linux takes the added quotes inside process arguments literally, so it attempts to make cargo-watch run the command `cargo "check --message-format json"` with the entire quoted part being treated as a single long subcommand, which cargo doesn't know how to handle. Removing the extra quotes solves the issue.
* Add cargo-watch package animation and refactoringEdwin Cheng2019-04-022-44/+78
|
* Fix prettier errorEdwin Cheng2019-04-021-1/+1
|
* Add terminate process implemntation noteEdwin Cheng2019-04-021-0/+7
|
* Add Cargo.toml file check before cargo watch startEdwin Cheng2019-04-021-0/+22
|
* Add cargo-watch.check-argumentsEdwin Cheng2019-04-024-74/+127
|
* Add config for cargo-watch traceEdwin Cheng2019-04-023-15/+55
|
* Add proper process teminate methodEdwin Cheng2019-04-024-8/+62
|
* Fix prettier errorEdwin Cheng2019-04-024-22/+31
|
* Fixed tslint errorEdwin Cheng2019-04-021-1/+1
|
* Fix tslint errorEdwin Cheng2019-04-022-63/+65
|
* Improve cargo-watch usageEdwin Cheng2019-04-023-24/+177
|
* Don't execute cargo watch when popup is dismissedpcpthm2019-03-221-2/+2
|
* Change enableCargoWatchOnStartup to have three statesVille Penttinen2019-03-212-13/+18
| | | | | | | This fixes #1005. Defaults to `ask` which prompts users each time whether to start `cargo watch` or not. `enabled` always starts `cargo watch` and `disabled` does not.
* Appease CIIgor Matuszewski2019-03-181-9/+7
|
* Guard auto cargo watch behind a config optionIgor Matuszewski2019-03-182-0/+12
|
* Separate out the interactive cargo watch procedureIgor Matuszewski2019-03-182-64/+70
|
* Reformat using PrettierIgor Matuszewski2019-03-182-17/+35
|
* Remove unused importsIgor Matuszewski2019-03-181-2/+1
|
* Prefer installing `cargo-watch` via Task APIIgor Matuszewski2019-03-181-23/+14
| | | | This gives us much more fine-grained stdout buffering and ANSI terminal colors.
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-18 18:33:42 +0000