aboutsummaryrefslogtreecommitdiff
path: root/editors/code
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Fix no inlay hints / unresolved tokens until manual editVeetaha2020-08-081-3/+3
|/ / | | | | | | | | | | | | | | | | | | No we return ContentModified during the workspace loading. This signifies the language client to retry the operation (i.e. the client will continue polling the server while it returns ContentModified). I believe that there might be cases of overly big projects where the backoff logic we have setup in `sendRequestWithRetry` (which we use for inlay hints) might bail too early (currently the largest retry standby time is 10 seconds). However, I've tried on one of my project with 500+ dependencies and it is still enough.
* / Fix typo in settings descriptionRüdiger Herrmann2020-08-081-1/+1
|/ | | Remove a duplicate word from the description of the `warningsAsHint` setting.
* Merge #5513bors[bot]2020-07-311-2/+10
|\ | | | | | | | | | | | | | | | | | | 5513: Try figure out correct workspace in vscode multi root workspace r=vsrs a=urbandove the code to replace the root with the `${workspaceRoot}` arg breaks in multi root workspaces as it needs a qualifier `${workspaceRoot:workspaceName}` This PR attempts to figure out the root workspace - and if it cant find it falls back to the first workspace Co-authored-by: Urban Dove <[email protected]>
| * delete empty lineUrban Dove2020-07-261-1/+0
| |
| * try select correct workspace in vscode multi workspaceUrban Dove2020-07-261-2/+11
| |
* | flycheck: Added checkOnSave.noDefaultFeaturesClemens Wasser2020-07-301-0/+8
| | | | | | | | | | | | This commit adds the option `rust-analyzer.checkOnSave.noDefaultFeatures` and fixes #5550.
* | SSR: Restrict to current selection if anyDavid Lattimore2020-07-292-2/+4
| | | | | | | | | | The selection is also used to avoid unnecessary work, but only to the file level. Further restricting unnecessary work is left for later.
* | Add toggle for experimental diagnosticsJonas Schievink2020-07-241-5/+10
| |
* | SSR: Fix a typescript lint warningDavid Lattimore2020-07-241-1/+1
| |
* | SSR: Pass current file position through to SSR code.David Lattimore2020-07-242-3/+13
|/ | | | In a subsequent commit, it will be used for resolving paths.
* Merge #5480bors[bot]2020-07-231-0/+4
|\ | | | | | | | | | | | | | | | | | | | | 5480: Fix snippetTextEdits applying to other files r=matklad a=TimoFreiberg Fixes #4551 `vscode.window.visibleTextEditors` only contains editors whose contents are being displayed at the moment, so the previous logic only worked if the other file for which a snippetTextEdit is being received was visible in a separate split. I feel that this is a hacky approach, so feel free to reject it for something nicer :) Co-authored-by: Timo Freiberg <[email protected]>
| * Fix snippetTextEdits applying to other filesTimo Freiberg2020-07-221-0/+4
| | | | | | | | | | | | | | vscode.window.visibleTextEditors only contains editors whose contents are being displayed at the moment, so the previous logic only worked if the other file for which a snippetTextEdit is being received was visible in a separate split.
* | ProblemMatcher auto detects relative/absolute paths and matches VSCode LSP's ↵James Leitch2020-07-232-3/+10
|/ | | | owner and source. VSCode LSP updated to specify owner.
* Bump lodash from 4.17.15 to 4.17.19 in /editors/codedependabot[bot]2020-07-161-3/+3
| | | | | | | Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]>
* Automatically reload project info on Cargo.toml changesAleksey Kladov2020-07-101-0/+5
|
* Workaround rollup messing up default importsVeetaha2020-07-081-1/+4
|
* Gzip artifactsVeetaha2020-07-072-16/+17
| | | | | | | | | | Co-authored-by: bjorn3 <[email protected]> Override miniz_oxide to build it with optimizations Building this crate with optimizations decreases the gzipping part of `cargo xtask dist` from `30-40s` down to `3s`, the overhead for `rustc` to apply optimizations is miserable on this background
* Add a command to compute memory usage statisticsJonas Schievink2020-07-074-0/+44
|
*---. Merge #5235 #5236 #5241bors[bot]2020-07-072-4/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5235: Don't ping people in PRs r=matklad a=lnicola 5236: Disable ES module interop r=matklad a=lnicola 5241: Clippy perf warnings r=matklad a=kjeremy Removes redundant clones Co-authored-by: Laurențiu Nicola <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]> Co-authored-by: kjeremy <[email protected]>
| | * | Disable ES module interopLaurențiu Nicola2020-07-062-4/+2
| | |/
* | / Consider EPERM error as other vscode processes using rust-analyzerVeetaha2020-07-071-1/+1
| |/ |/|
* | Fix: allow for binaries from $PATH to pass validity checkVeetaha2020-07-061-6/+2
|/
* Revert "Dispose logger on extension deactivation"Veetaha2020-07-052-6/+0
| | | | | This reverts commit 13872543e074adc153b440660beda441fd562f53. That commit was wrong because we use-after-free the logger
* Dispose logger on extension deactivationVeetaha2020-07-052-0/+6
|
* Improve client logging (use output channel and more log levels)Veetaha2020-07-054-18/+49
|
* Merge #5203bors[bot]2020-07-031-1/+1
|\ | | | | | | | | | | | | | | 5203: Fix typo in description of vscode setting r=matklad a=Nashenas88 Co-authored-by: Paul Daniel Faria <[email protected]>
| * Fix typo in description of vscode settingPaul Daniel Faria2020-07-031-1/+1
| |
* | Merge #5202bors[bot]2020-07-035-13/+191
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5202: Runnable env r=matklad a=vsrs This PR adds on option to specify (in the settings.json) environment variables passed to the runnable. The simplest way for all runnables in a bunch: ```jsonc "rust-analyzer.runnableEnv": { "RUN_SLOW_TESTS": "1" } ``` Or it is possible to specify vars more granularly: ```jsonc "rust-analyzer.runnableEnv": [ { // "mask": null, // null mask means that this rule will be applied for all runnables env: { "APP_ID": "1", "APP_DATA": "asdf" } }, { "mask": "test_name", "env": { "APP_ID": "2", // overwrites only APP_ID } } ] ``` You can use any valid RegExp as a mask. Also note that a full runnable name is something like *run bin_or_example_name*, *test some::mod::test_name* or *test-mod some::mod*, so it is possible to distinguish binaries, single tests, and test modules with this masks: `"^run"`, `"^test "` (the trailing space matters!), and `"^test-mod"` respectively. Fixes #4450 I suppose this info should be somewhere in the docs, but unsure where is the best place. Co-authored-by: vsrs <[email protected]>
| * Fix workspaceRootvsrs2020-07-031-1/+3
| |
| * code lintingvsrs2020-07-033-32/+32
| |
| * Add testsvsrs2020-07-034-10/+128
| |
| * Add runnable env support.vsrs2020-07-034-11/+69
| |
* | Pass CodeActionKind through our middleware to populate menusJeremy Kolb2020-07-021-2/+4
|/
* Merge #5188bors[bot]2020-07-023-1/+46
|\ | | | | | | | | | | | | | | 5188: Implement StatusBar r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Implement StatusBarAleksey Kladov2020-07-023-1/+46
| |
| |
| \
| \
| \
*---. \ Merge #5089 #5161 #5184 #5185 #5186bors[bot]2020-07-021-7/+19
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5089: Disable auto-complete on comments r=matklad a=BGluth Resolves #4907 by disabling any auto-completion on comments. As flodiebold [pointed out](https://github.com/rust-analyzer/rust-analyzer/issues/4907#issuecomment-648439979), in the future we may want to support some form of auto-completion within doc comments, but for now it was suggested to just disable auto-completion on them entirely. The implementation involves adding a new field `is_comment` to `CompletionContext` and checking if the immediate token we auto-completed on is a comment. I couldn't see a case where we need to check any of the ancestors, but let me know if this is not sufficient. I also wasn't sure if it was necessary to add a new field to this struct, but I decided it's probably the best option if we want to potentially do auto-completion on doc comments in the future. Finally, the three tests I added should I think ideally not filter results by `CompletionKind::Keyword`, but if I want to get unfiltered results, I need access to a non-public function [get_all_completion_items](https://github.com/rust-analyzer/rust-analyzer/blob/9a4d02faf9c47f401b8756c3f7fcab2198f5f9cd/crates/ra_ide/src/completion/test_utils.rs#L32-L39) which I don't know if I should make public just for this. 5161: SSR: Add initial support for placeholder constraints r=matklad a=davidlattimore 5184: Always install required nightly extension if current one is not nightly r=matklad a=Veetaha This is weird, but having switched back to stable by uninstalling the extension appears that vscode doesn't destroy the `PersistentState` and thus changing to `nightly` channel doesn't work because the last check for nightly extension was less than 1 hour ago. The simple solution is to skip this check if we know that the current extension version is not nightly. 5185: Force showing extension activation error pop-up notification r=matklad a=Veetaha Fixes https://github.com/rust-analyzer/rust-analyzer/issues/5091 5186: fix: correct pd/ppd/tfn/tmod completion doc r=matklad a=fannheyward https://github.com/rust-analyzer/rust-analyzer/blob/a33eefa3b26000b3018e6bb873f18dbe15ab4ab7/crates/ra_ide/src/completion/complete_snippet.rs#L23-L24 Co-authored-by: BGluth <[email protected]> Co-authored-by: David Lattimore <[email protected]> Co-authored-by: Veetaha <[email protected]> Co-authored-by: Heyward Fann <[email protected]>
| | | * Force showing extension activation error pop-up notificationVeetaha2020-07-021-3/+11
| | | |
| | * | Always install required nightly extension if current one is not nightlyVeetaha2020-07-021-4/+8
| | |/
* | / Add reload workspace commandAleksey Kladov2020-07-014-8/+8
|/ /
* | Merge #5098bors[bot]2020-07-013-601/+390
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 5098: Bump npm deps r=Veetaha a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]> Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Be more strict with `@types/node`Laurențiu Nicola2020-07-012-4/+4
| | | | | | | | | | | | Co-authored-by: Veetaha <[email protected]>
| * | Use newer @types/nodeLaurențiu Nicola2020-06-291-1/+1
| | |
| * | Downgrade @types/nodeLaurențiu Nicola2020-06-282-4/+4
| | |
| * | Bump @rollup/plugin-commonjsLaurențiu Nicola2020-06-273-10/+9
| | |
| * | Bump some npm depsLaurențiu Nicola2020-06-272-591/+381
| | |
* | | Fix a typoMatthijs Brobbel2020-06-301-2/+2
| | |
* | | Merge #5101bors[bot]2020-06-302-1/+6
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5101: Add expect -- a light-weight alternative to insta r=matklad a=matklad This PR implements a small snapshot-testing library. Snapshot updating is done by setting an env var, or by using editor feature (which runs a test with env-var set). Here's workflow for updating a failing test: ![expect](https://user-images.githubusercontent.com/1711539/85926956-28afa080-b8a3-11ea-9260-c6d0d8914d0b.gif) Here's workflow for adding a new test: ![expect-fresh](https://user-images.githubusercontent.com/1711539/85926961-306f4500-b8a3-11ea-9369-f2373e327a3f.gif) Note that colorized diffs are not implemented in this PR, but should be easy to add (we already use them in test_utils). Main differences from insta (which is essential for rust-analyzer development, thanks @mitsuhiko!): * self-updating tests, no need for a separate tool * fewer features (only inline snapshots, no redactions) * fewer deps (no yaml, no persistence) * tighter integration with editor * first-class snapshot object, which can be used to write test functions (as opposed to testing macros) * trivial to tweak for rust-analyzer needs, by virtue of being a workspace member. I think eventually we should converge to a single snapshot testing library, but I am not sure that `expect` is exactly right, so I suggest rolling with both insta and expect for some time (if folks agree that expect might be better in the first place!). # Editor Integration Implementation The thing I am most excited about is the ability to update a specific snapshot from the editor. I want this to be available to other snapshot-testing libraries (cc @mitsuhiko, @aaronabramov), so I want to document how this works. The ideal UI here would be a code action (:bulb:). Unfortunately, it seems like it is impossible to implement without some kind of persistence (if you save test failures into some kind of a database, like insta does, than you can read the database from the editor plugin). Note that it is possible to highlight error by outputing error message in rustc's format. Unfortunately, one can't use the same trick to implement a quick fix. For this reason, expect makes use of another rust-analyzer feature -- ability to run a single test at the cursor position. This does need some expect-specific code in rust-analyzer unfortunately. Specifically, if rust-analyzer notices that the cursor is on `expect!` macro, it adds a special flag to runnable's JSON. However, given #5017 it is possible to approximate this well-enough without rust-analyzer integration. Specifically, an extension can register a special runner which checks (using regexes) if rust-anlyzer runnable covers text with specific macro invocation and do special magic in that case. closes #3835 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add light-weight snapshot testing library with editor integrationAleksey Kladov2020-06-272-1/+6
| |/
* | Merge #5119bors[bot]2020-06-291-3/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | 5119: Show notification while SSR is in progress r=matklad a=davidlattimore Ideally we would (a) show progress and (b) allow cancellation, but at least now there's some indication to the user that something is happening. Co-authored-by: David Lattimore <[email protected]>
| * | Show notification while SSR is in progressDavid Lattimore2020-06-291-3/+9
| |/ | | | | | | Ideally we would (a) show progress and (b) allow cancellation, but at least now there's some indication to the user that something is happening.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-01 03:37:08 +0000