aboutsummaryrefslogtreecommitdiff
path: root/editors/code
Commit message (Collapse)AuthorAgeFilesLines
* vscode: care about alwaysDownloadServer option before askingVeetaha2020-03-073-23/+31
| | | | | | | Also renamed BinarySource to ArtifactSource in anticipation of nightlies installation that requires downloading not a binary itself but .vsix package, thus generalized to `artifact` term
* vscode: contribute "alwaysDownloadServer" option to configVeetaha2020-03-071-0/+5
|
* vscode: post refactor HintsUpdater (simplify create() -> constructor call)Veetaha2020-03-071-16/+10
|
* vscode: more privacy for HintsUpdaterVeetaha2020-03-071-1/+1
|
* vscode: remove logging from inlays, run fix lint issuesVeetaha2020-03-071-18/+7
|
* vscode: remove logic for caching editors as per @matkladVeetaha2020-03-071-222/+136
|
* vscode: prerefactor util.ts and ctx.tsVeetaha2020-03-072-10/+14
|
* vscode: refresh all editors on text changes, simplify inlays apiVeetaha2020-03-071-13/+11
|
* vscode: add dat semicolonVeetaha2020-03-071-1/+1
|
* vscode: simpifyVeetaha2020-03-071-5/+1
|
* vscode: redesign inlay hints to be capable of handling multiple editorsVeetaha2020-03-072-106/+273
|
* vscode: extract Type and Param hint cases of InlayHint at type level (needed ↵Veetaha2020-03-071-8/+14
| | | | further)
* :arrow_up: npm depsAleksey Kladov2020-03-062-7/+7
|
* Don't creat public APIs with typosAleksey Kladov2020-03-061-1/+1
|
* Concise mode for parameter hintsAleksey Kladov2020-03-061-0/+4
| | | | | This works around VS Code bug where it tries to cram everything in a tiny popup, and brings experience closer to Intellij.
* Feature flag for arg snippetsAleksey Kladov2020-03-061-0/+4
|
* Actually include readme into .vsixAleksey Kladov2020-03-031-0/+1
|
* Merge #3388bors[bot]2020-03-035-15/+25
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3388: Remove inlay hint in diff views r=matklad a=vbfox If the left side of a diff view that contain the old version of the file apply inlays they are misplaced and produce a weird display: ![image](https://user-images.githubusercontent.com/131878/75628802-b1ac1900-5bdc-11ea-8c26-6722d8e38371.png) After the change: ![image](https://user-images.githubusercontent.com/131878/75628831-e91ac580-5bdc-11ea-9039-c6b4ffbdb2be.png) The detection is done by blacklisting the url schemes used by git and subversion scm extensions, whitelisting `file` is also possible but neither is perfect as VSCode now support both pluggable scm extensions and pluggable remote filesystems. But I suspect that the list of scm extensions is more easily manageable. **Note**: I can rebase on #3378 if needed as it touches the same lines of code Co-authored-by: Julien Roncaglia <[email protected]>
| * Centralize the check for languageId on documentJulien Roncaglia2020-03-025-24/+25
| | | | | | | | Also move visibleRustEditors to Ctx
| * Remove inlay in diff viewsJulien Roncaglia2020-03-011-1/+10
| | | | | | | | | | | | | | | | If the left side of a diff view that contain the old version of the file apply inlays they are misplaced. The detection is done by blacklisting the url schemes used by git and subversion scm extensions.
* | Update code dependenciesJeremy Kolb2020-03-032-70/+105
| |
* | Don't fail loudly if the old highlighting breaksAleksey Kladov2020-03-021-4/+6
| |
* | Minimal viable metaAleksey Kladov2020-03-022-1/+11
|/
* vscode: simplify assert.eq() to assert() as per matkladVeetaha2020-02-282-15/+4
|
* vscode: add dat semicolonVeetaha2020-02-281-1/+1
|
* vscode: add equality assertionVeetaha2020-02-282-2/+12
|
* vscode: rename nodeAssert -> nativeAssertVeetaha2020-02-281-2/+2
|
* vscode: add error loging on failed assertionVeetaha2020-02-281-1/+6
|
* vscode: migrate to more type-safe assert implVeetaha2020-02-283-8/+10
|
* Fix union classificationAleksey Kladov2020-02-281-2/+0
|
* Merge #3363bors[bot]2020-02-281-20/+64
|\ | | | | | | | | | | | | | | | | | | | | 3363: Cleanup highlighting tags r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Cleanup highlighting tagsAleksey Kladov2020-02-281-17/+70
| |
| * add more tagsAleksey Kladov2020-02-281-9/+0
| |
* | removing ctrl+r key binding fixes #2733Jason Williams2020-02-281-5/+0
| |
* | Merge #3361bors[bot]2020-02-281-0/+2
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3361: Reset fontStyle for inlay hints r=matklad a=matklad Otherwise, we get bold hints on `true` and `false` bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Reset fontStyle for inlay hintsAleksey Kladov2020-02-281-0/+2
| |/ | | | | | | Otherwise, we get bold hints on `true` and `false`
* / vscode: added feature flags for better short-term uxVeetaha2020-02-271-1/+23
|/
* Map builtinAleksey Kladov2020-02-271-0/+6
|
* Set attr scopeAleksey Kladov2020-02-271-0/+6
|
* Map unsafe keywordAleksey Kladov2020-02-271-0/+6
|
* Fix styleAleksey Kladov2020-02-271-1/+1
|
* Fix lintAleksey Kladov2020-02-271-1/+1
|
* Actually gate CI on eslintAleksey Kladov2020-02-271-1/+2
|
* Merge #3339bors[bot]2020-02-271-1/+9
|\ | | | | | | | | | | | | | | | | | | | | 3339: Fix flickering with new syntax highlighting r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <[email protected]>
| * Fix flickering with new syntax highlightingAleksey Kladov2020-02-271-1/+9
| |
* | Merge #3308bors[bot]2020-02-271-1/+1
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3308: vscode: fix vscode-vim keybindings conflict r=matklad a=Veetaha Closes #3013 I hope vscode-vim extension overrides the `type` command so that it prevents some keypresses to reach the text document editor. It conflicts with our `onEnter` keybinding that is used to support automatic doc comments extending and indentation insertion. The VSCode-native way to implement this would be to use regular expressions, but as per matklad it is considered not acceptable for the language server. Thus we implement it via a `Enter` keybinding that invokes our `onEnter` command which does it via the language-server. At the end of the day we may only apply ad hoc workarounds for conflicting extensions. But vscode has another bug for that. You either cannot use parantheses in `when` condition of a keybinding or it just malfunctions. See an issue about that here: https://github.com/microsoft/vscode/issues/91473 To get the ultimate context, follow this [zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Enhanced.20typing) Co-authored-by: Veetaha <[email protected]>
| * vscode: fix vscode-vim keybindings conflictVeetaha2020-02-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | vscode-vim extension overrides the `type` command so that it prevents some keypresses to reach the text document editor. It conflicts with our `onEnter` keybinding that is used to support automatic doc comments extending and indentation insertion. The VSCode-native way to implement this would be to use regular expressions, but as per matklad it is considered not acceptable for the language server. Thus we implement it via a `Enter` keybinding that invokes our `onEnter` command which sends a request to rust-analyzer process and applies the appropriate source change recieved from it. At the end of the day we may only apply ad hoc workarounds for conflicting extensions. But vscode has another bug for that. You either cannot use parantheses in `when` condition of a keybinding or it just malfunctions. See an issue about that here: https://github.com/microsoft/vscode/issues/91473 To get the ultimate context, follow this zulip thread: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Enhanced.20typing
* | Color constantsAleksey Kladov2020-02-271-0/+9
| |
* | Better highlightign APIAleksey Kladov2020-02-271-0/+19
| |
* | wipAleksey Kladov2020-02-261-0/+14
| |