aboutsummaryrefslogtreecommitdiff
path: root/editors
Commit message (Collapse)AuthorAgeFilesLines
* Merge #5203bors[bot]2020-07-031-1/+1
|\ | | | | | | | | | | | | | | 5203: Fix typo in description of vscode setting r=matklad a=Nashenas88 Co-authored-by: Paul Daniel Faria <[email protected]>
| * Fix typo in description of vscode settingPaul Daniel Faria2020-07-031-1/+1
| |
* | Merge #5202bors[bot]2020-07-035-13/+191
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5202: Runnable env r=matklad a=vsrs This PR adds on option to specify (in the settings.json) environment variables passed to the runnable. The simplest way for all runnables in a bunch: ```jsonc "rust-analyzer.runnableEnv": { "RUN_SLOW_TESTS": "1" } ``` Or it is possible to specify vars more granularly: ```jsonc "rust-analyzer.runnableEnv": [ { // "mask": null, // null mask means that this rule will be applied for all runnables env: { "APP_ID": "1", "APP_DATA": "asdf" } }, { "mask": "test_name", "env": { "APP_ID": "2", // overwrites only APP_ID } } ] ``` You can use any valid RegExp as a mask. Also note that a full runnable name is something like *run bin_or_example_name*, *test some::mod::test_name* or *test-mod some::mod*, so it is possible to distinguish binaries, single tests, and test modules with this masks: `"^run"`, `"^test "` (the trailing space matters!), and `"^test-mod"` respectively. Fixes #4450 I suppose this info should be somewhere in the docs, but unsure where is the best place. Co-authored-by: vsrs <[email protected]>
| * Fix workspaceRootvsrs2020-07-031-1/+3
| |
| * code lintingvsrs2020-07-033-32/+32
| |
| * Add testsvsrs2020-07-034-10/+128
| |
| * Add runnable env support.vsrs2020-07-034-11/+69
| |
* | Pass CodeActionKind through our middleware to populate menusJeremy Kolb2020-07-021-2/+4
|/
* Merge #5188bors[bot]2020-07-023-1/+46
|\ | | | | | | | | | | | | | | 5188: Implement StatusBar r=matklad a=matklad Co-authored-by: Aleksey Kladov <[email protected]>
| * Implement StatusBarAleksey Kladov2020-07-023-1/+46
| |
| |
| \
| \
| \
*---. \ Merge #5089 #5161 #5184 #5185 #5186bors[bot]2020-07-021-7/+19
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5089: Disable auto-complete on comments r=matklad a=BGluth Resolves #4907 by disabling any auto-completion on comments. As flodiebold [pointed out](https://github.com/rust-analyzer/rust-analyzer/issues/4907#issuecomment-648439979), in the future we may want to support some form of auto-completion within doc comments, but for now it was suggested to just disable auto-completion on them entirely. The implementation involves adding a new field `is_comment` to `CompletionContext` and checking if the immediate token we auto-completed on is a comment. I couldn't see a case where we need to check any of the ancestors, but let me know if this is not sufficient. I also wasn't sure if it was necessary to add a new field to this struct, but I decided it's probably the best option if we want to potentially do auto-completion on doc comments in the future. Finally, the three tests I added should I think ideally not filter results by `CompletionKind::Keyword`, but if I want to get unfiltered results, I need access to a non-public function [get_all_completion_items](https://github.com/rust-analyzer/rust-analyzer/blob/9a4d02faf9c47f401b8756c3f7fcab2198f5f9cd/crates/ra_ide/src/completion/test_utils.rs#L32-L39) which I don't know if I should make public just for this. 5161: SSR: Add initial support for placeholder constraints r=matklad a=davidlattimore 5184: Always install required nightly extension if current one is not nightly r=matklad a=Veetaha This is weird, but having switched back to stable by uninstalling the extension appears that vscode doesn't destroy the `PersistentState` and thus changing to `nightly` channel doesn't work because the last check for nightly extension was less than 1 hour ago. The simple solution is to skip this check if we know that the current extension version is not nightly. 5185: Force showing extension activation error pop-up notification r=matklad a=Veetaha Fixes https://github.com/rust-analyzer/rust-analyzer/issues/5091 5186: fix: correct pd/ppd/tfn/tmod completion doc r=matklad a=fannheyward https://github.com/rust-analyzer/rust-analyzer/blob/a33eefa3b26000b3018e6bb873f18dbe15ab4ab7/crates/ra_ide/src/completion/complete_snippet.rs#L23-L24 Co-authored-by: BGluth <[email protected]> Co-authored-by: David Lattimore <[email protected]> Co-authored-by: Veetaha <[email protected]> Co-authored-by: Heyward Fann <[email protected]>
| | | * Force showing extension activation error pop-up notificationVeetaha2020-07-021-3/+11
| | | |
| | * | Always install required nightly extension if current one is not nightlyVeetaha2020-07-021-4/+8
| | |/
* | / Add reload workspace commandAleksey Kladov2020-07-014-8/+8
|/ /
* | Merge #5098bors[bot]2020-07-013-601/+390
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 5098: Bump npm deps r=Veetaha a=lnicola Co-authored-by: Laurențiu Nicola <[email protected]> Co-authored-by: Laurențiu Nicola <[email protected]>
| * | Be more strict with `@types/node`Laurențiu Nicola2020-07-012-4/+4
| | | | | | | | | | | | Co-authored-by: Veetaha <[email protected]>
| * | Use newer @types/nodeLaurențiu Nicola2020-06-291-1/+1
| | |
| * | Downgrade @types/nodeLaurențiu Nicola2020-06-282-4/+4
| | |
| * | Bump @rollup/plugin-commonjsLaurențiu Nicola2020-06-273-10/+9
| | |
| * | Bump some npm depsLaurențiu Nicola2020-06-272-591/+381
| | |
* | | Fix a typoMatthijs Brobbel2020-06-301-2/+2
| | |
* | | Merge #5101bors[bot]2020-06-302-1/+6
|\ \ \ | |_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5101: Add expect -- a light-weight alternative to insta r=matklad a=matklad This PR implements a small snapshot-testing library. Snapshot updating is done by setting an env var, or by using editor feature (which runs a test with env-var set). Here's workflow for updating a failing test: ![expect](https://user-images.githubusercontent.com/1711539/85926956-28afa080-b8a3-11ea-9260-c6d0d8914d0b.gif) Here's workflow for adding a new test: ![expect-fresh](https://user-images.githubusercontent.com/1711539/85926961-306f4500-b8a3-11ea-9369-f2373e327a3f.gif) Note that colorized diffs are not implemented in this PR, but should be easy to add (we already use them in test_utils). Main differences from insta (which is essential for rust-analyzer development, thanks @mitsuhiko!): * self-updating tests, no need for a separate tool * fewer features (only inline snapshots, no redactions) * fewer deps (no yaml, no persistence) * tighter integration with editor * first-class snapshot object, which can be used to write test functions (as opposed to testing macros) * trivial to tweak for rust-analyzer needs, by virtue of being a workspace member. I think eventually we should converge to a single snapshot testing library, but I am not sure that `expect` is exactly right, so I suggest rolling with both insta and expect for some time (if folks agree that expect might be better in the first place!). # Editor Integration Implementation The thing I am most excited about is the ability to update a specific snapshot from the editor. I want this to be available to other snapshot-testing libraries (cc @mitsuhiko, @aaronabramov), so I want to document how this works. The ideal UI here would be a code action (:bulb:). Unfortunately, it seems like it is impossible to implement without some kind of persistence (if you save test failures into some kind of a database, like insta does, than you can read the database from the editor plugin). Note that it is possible to highlight error by outputing error message in rustc's format. Unfortunately, one can't use the same trick to implement a quick fix. For this reason, expect makes use of another rust-analyzer feature -- ability to run a single test at the cursor position. This does need some expect-specific code in rust-analyzer unfortunately. Specifically, if rust-analyzer notices that the cursor is on `expect!` macro, it adds a special flag to runnable's JSON. However, given #5017 it is possible to approximate this well-enough without rust-analyzer integration. Specifically, an extension can register a special runner which checks (using regexes) if rust-anlyzer runnable covers text with specific macro invocation and do special magic in that case. closes #3835 Co-authored-by: Aleksey Kladov <[email protected]>
| * | Add light-weight snapshot testing library with editor integrationAleksey Kladov2020-06-272-1/+6
| |/
* | Merge #5119bors[bot]2020-06-291-3/+9
|\ \ | | | | | | | | | | | | | | | | | | | | | 5119: Show notification while SSR is in progress r=matklad a=davidlattimore Ideally we would (a) show progress and (b) allow cancellation, but at least now there's some indication to the user that something is happening. Co-authored-by: David Lattimore <[email protected]>
| * | Show notification while SSR is in progressDavid Lattimore2020-06-291-3/+9
| |/ | | | | | | Ideally we would (a) show progress and (b) allow cancellation, but at least now there's some indication to the user that something is happening.
* / Fix SSR prompt following #4919David Lattimore2020-06-271-1/+1
|/
* Merge #5017bors[bot]2020-06-266-83/+104
|\ | | | | | | | | | | | | | | | | | | | | | | 5017: Add custom cargo runners support. r=matklad a=vsrs This PR adds an option to delegate actual cargo commands building to another extension. For example, to use a different manager like [cross](https://github.com/rust-embedded/cross). https://github.com/vsrs/cross-rust-analyzer is an example of such extension. I'll publish it after the rust-analyzer release with this functionality. Fixes https://github.com/rust-analyzer/rust-analyzer/issues/4902 Co-authored-by: vsrs <[email protected]>
| * Fix ts lintsvsrs2020-06-241-2/+2
| |
| * Switch to ShellExecution instead of full Taskvsrs2020-06-242-41/+45
| |
| * Add custom cargo runnersvsrs2020-06-246-56/+73
| |
* | Merge branch 'Veetaha-feat/sync-branch'Aleksey Kladov2020-06-252-103/+0
|\ \
| * | Migrate flycheck to fully-lsp-compatible progress reports (introduce ↵veetaha2020-06-182-103/+0
| | | | | | | | | | | | ra_progress crate)
* | | Merge #5025bors[bot]2020-06-241-57/+27
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 5025: Don't mess with messy temp dir and just download into extension dir r=matklad a=Veetaha Temp dirs are messy. Dealing with them requires handling quite a bunch of edge cases. As proposed by lnicola this seems better to just put the temp files in the extension dir and not care much about suddenly leaving garbage. Instead we get shorter and less platform-caveat-y code. We will also assume users don't try to issue a download in different vscode windows simultaneously. Fixes #5019 Co-authored-by: Veetaha <[email protected]>
| * | | Append 10 random hex chars to temp artifact filesVeetaha2020-06-241-1/+5
| | | |
| * | | Don't mess with messy temp dir and just download into extension dirVeetaha2020-06-241-57/+23
| | |/ | |/| | | | | | | | | | | | | | | | | | | Temp dirs are messy. Dealing with them requires handling quite a bunch of edge cases. As proposed by lnicola this seems better to just put the temp files in the extension dir and not care much about suddenly leaving garbage. Instead we get shorter and less platform-caveat-y code. We will also assume users don't try to issue a download in different vscode windows simultaneously
* / | Remove namedExports configLaurențiu Nicola2020-06-241-6/+1
|/ /
| |
| \
| \
| \
| \
| \
*-----. \ Merge #4992 #4993 #4994 #4997 #4998bors[bot]2020-06-234-50/+66
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4992: Never disable error logging on the frontend r=matklad a=Veetaha 4993: Make bootstrap error message more informative and better-fitting r=matklad a=Veetaha Now this better fits standard vscode extension activation failure message and suggests enabling verbose logs. ![image](https://user-images.githubusercontent.com/36276403/85321828-ffbb9400-b4cd-11ea-8adf-4032b1f62dfd.png) 4994: Decouple http file stream logic from temp dir logic r=matklad a=Veetaha Followup for #4989 4997: Update manual.adoc r=matklad a=gwutz GNOME Builder (Nightly) supports now rust-analyzer 4998: Disrecommend trace.server: "verbose" for regular users r=matklad a=Veetaha This option has never been useful for me, I wonder if anyone finds regular users can use this for sending logs Co-authored-by: Veetaha <[email protected]> Co-authored-by: Günther Wagner <[email protected]>
| | | | * | Disrecommend trace.server: "verbose" for regular usersVeetaha2020-06-221-1/+1
| |_|_|/ / |/| | | |
| | | * | Decouple http file stream logic from temp dir logicVeetaha2020-06-222-44/+57
| |_|/ / |/| | |
| | * | Make bootstrap error message more informative and better-fittingVeetaha2020-06-221-4/+8
| | | |
| * | | Never disable error logging on the frontendVeetaha2020-06-221-1/+0
|/ / /
* / / Hotfix skipping the first chunks of the artifactsVeetaha2020-06-221-6/+7
|/ /
* | Download artifacts into tmp dirVeetaha2020-06-202-11/+60
| |
* | Update workaround commentVeetaha2020-06-191-3/+2
| |
* | Add `rust-analyzer.gotoLocation` commandvsrs2020-06-184-0/+23
| |
* | Fix rust-analyzer.debug.openDebugPane optionvsrs2020-06-182-2/+2
|/
* Warnings as hint or infoGabriel Valfridsson2020-06-161-0/+18
|
* checkOnSafe.features and checkOnSafe.allFeatures now work identically.Clemens Wasser2020-06-101-2/+5
|
* Most of the checkOnSafe options now default to the cargo equivalent.Clemens Wasser2020-06-101-4/+7
|
* Added the rust-analyzer.checkOnSave.features option.Clemens Wasser2020-06-101-0/+8
|