aboutsummaryrefslogtreecommitdiff
path: root/editors
Commit message (Collapse)AuthorAgeFilesLines
* vscode: changed dns sanity-check url from google.com to example.comVeetaha2020-02-091-3/+6
|
* vscode: add on-success logic to dns resolution sanity checkVeetaha2020-02-091-4/+7
|
* vscode: removed unnecessary awaitsVeetaha2020-02-091-2/+2
|
* Merge #3053bors[bot]2020-02-0910-29/+396
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3053: Feature: downloading lsp server from GitHub r=matklad a=Veetaha This is currently very WIP, I may need to change this and that, add "download language server command", logging stuff (for future bug reports), etc., but it already works. Also didn't test this on windows yet and mac (don't have the latter) The quirks: * Downloaded binary doesn't have executable permissions by default, that's why we ~~`chmod 111`~~ (**[UPD]** `chmod 755` as per @lnicola [suggestion](https://github.com/rust-analyzer/rust-analyzer/pull/3053#discussion_r376694456)) for it. * To remove installed binary run `rm /${HOME}/.config/Code/User/globalStorage/matklad.rust-analyzer/ra_lsp_server-linux`, ~~note that `-f` flag is necessary, because of `111` permissions (I think this should be changed)~~ (**[UPD]** --force is no longer needed due to 755 permissions). I also tried to keep things simple and not to use too many dependencies, all the ones added have 0 dependencies, (`ts-not-nil` is my personal npm package, that imitates `unwrap()` in TypeScript) **[UPD]** I reduced throttle latency of progress indicator to 200ms for smoother UX // TODO: - [x] ~~Add `Rust Analyzer: Download latest language server` vscode command.~~ **[UPD]**: having reviewed the code and estimated available options I concluded that this feature requires too many code changes, I'd like to extract this into a separate PR after we merge this one. - [x] Add some logging for future debugging - [x] ~~Gracefully handle the case when language server is not available (e.g. no internet connection, user explicitly rejected the download, etc.)~~ **[UPD]** Decided to postpone better implementation of graceful degradation logic as per [conversation](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Deployment.20and.20installation/near/187758550). Demo (**[UPD]** this is a bit outdated, but still mainly reflects the feature): ![ra-github-release-download-mvp](https://user-images.githubusercontent.com/36276403/74077961-4f248a80-4a2d-11ea-962f-27c650fd6c4c.gif) Related issue: #2988 #3007 Co-authored-by: Veetaha <[email protected]> Co-authored-by: Veetaha <[email protected]>
| * vscode: added logging when donloading binariesVeetaha2020-02-093-5/+26
| |
| * vscode: move throtting of download progress to call siteVeetaha2020-02-092-16/+19
| |
| * vscode: replaced unwrapNotNil() with ! as per @matkladVeetaha2020-02-093-21/+3
| |
| * vscode: refactor inverted ternaries to if statements as per @matkladVeetaha2020-02-092-2/+6
| |
| * vscode: remove noise data fields declarations as per @matkladVeetaha2020-02-091-6/+1
| |
| * vscode: refactor levels of code nesting and string literals quotesVeetaha2020-02-091-26/+30
| |
| * vscode: fix chmod to octal literalVeetaha2020-02-091-1/+1
| | | | | | Co-Authored-By: Aleksey Kladov <[email protected]>
| * vscode: minor names and message contents changesVeetaha2020-02-082-9/+12
| |
| * vscode: rename raLspServer variable to langServerVeetaha2020-02-081-3/+3
| |
| * vscode: refactor commentVeetaha2020-02-081-1/+1
| |
| * vscode: refactor platform artifact name query to switch statement, move ↵Veetaha2020-02-084-70/+89
| | | | | | | | BinarySource union variants into a namespace
| * vscode: reduce throttle latency of downloadFile() progress callback for ↵Veetaha2020-02-081-1/+1
| | | | | | | | smoother UX
| * vscode: add name to the second unused argument of withProgress() callbackVeetaha2020-02-081-1/+1
| |
| * vscode: add docs to installation module interfaces and sanity check to ↵Veetaha2020-02-082-4/+39
| | | | | | | | donloadFile()
| * vscode: converted fetchLatestArtifactMetadata params to positional, added docsVeetaha2020-02-081-10/+10
| |
| * vscode: changed chmod value to 755 as per @lnicolaVeetaha2020-02-081-3/+3
| |
| * vscode: amended config to use binary from globalStoragePath, added ui for ↵Veetaha2020-02-0810-41/+229
| | | | | | | | downloading
| * added fetchLatestArtifactMetadata() and downloadFile() functionsVeetaha2020-02-084-1/+111
| |
| * vscode: add FIXME about language client shared resource protectionVeetaha2020-02-081-0/+3
| |
* | Remove rust-analyzer.elFlorian Diebold2020-02-081-295/+0
|/ | | | The support has been moved to emacs-lsp.
* Merge #3024bors[bot]2020-02-058-21/+36
|\ | | | | | | | | | | | | | | 3024: vscode: eliminate floating promises and insane amount of resource handle leaks r=matklad a=Veetaha Khm, yeah ... Co-authored-by: Veetaha <[email protected]>
| * vscode: eliminate floating promises and insane amount of resource handle leaksVeetaha2020-02-058-21/+36
| |
* | vscode: removed changes to integrity hash in package-lock.jsonVeetaha2020-02-051-1/+1
| |
* | vscode: yet another refactor commitVeetaha2020-02-047-35/+30
|/
* Merge two if statements into one in editors/code/src/commands/on_enter.ts.Grégoire Geis2020-02-041-1/+1
| | | Co-Authored-By: Veetaha <[email protected]>
* vscode: Only handle enter if the suggest widget is hidden.Gregoire Geis2020-02-031-1/+1
|
* Remove enableEnhancedTyping and type overriding infrastructure.Gregoire Geis2020-02-034-41/+1
|
* Change default enhanced typing behavior from using type to using keybindings.Gregoire Geis2020-02-031-1/+6
|
* Add regular onEnter command, allowing onEnter to be called without ↵Gregoire Geis2020-02-033-19/+40
| | | | overriding the type command.
* Remove unnecessary flagsAleksey Kladov2020-02-031-2/+2
|
* Remove rollup-typescriptAleksey Kladov2020-02-033-15/+2
| | | | It seems like just calling typescript directly is simpler and more reliable?
* Update some rollup packagesAleksey Kladov2020-02-032-29/+32
|
* Use simple prng instead of a dependencyAleksey Kladov2020-02-034-18/+23
| | | | closes #2999
* Remove recent improvements to the build scriptAleksey Kladov2020-02-033-15/+14
| | | | | | | | tslib as a dev dependency and commonjs modules are definitely *wrong* in the ideal world, **but** in the real world that's the only combination that works. See https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Problems.20with.20TypeScript.20build
* Fix build of typscript extensionAleksey Kladov2020-02-031-0/+1
|
* vscode: fix bundling by switching to es2015 target modules systemVeetaha2020-02-031-1/+1
|
* vscode: dropped npm-check-updates scriptVeetaha2020-02-022-2014/+1
|
* vscode: updated rollup typescript so it typechecks the bundleVeetaha2020-02-022-7/+2020
|
* vscode: use void where possibleVeetaha2020-02-023-5/+9
|
* vscode: fix, fallback to any for cmd typeVeetaha2020-02-021-1/+1
|
* vscode extension: migrate from any to unknown where possibleVeetaha2020-02-024-9/+9
|
* vscode: fix typeVeetaha2020-02-021-1/+1
|
* vscode refactoring: use more laconic export snytax, split huge string to ↵Veetaha2020-02-023-33/+18
| | | | several lines
* vscode extension cleanup: migrate to prefer-const tslint ruleVeetaha2020-02-026-10/+11
|
* Merge #2979bors[bot]2020-02-023-4/+4
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2979: vscode: now we are actually using tslib r=matklad a=Veetaha We had an incorrect setup where `tslib` was in `devDependencies`. FYI: tslib is a runtime dependency, it contains functions that are used by transpiled JavaScript in order not to inline them in each file. For example: ```ts // foo.ts (source code) import * as foo from "foo"; // --------------------------- // foo.js (compiled output) "use strict"; var __importStar = (this && this.__importStar) || function (mod) { if (mod && mod.__esModule) return mod; var result = {}; if (mod != null) for (var k in mod) if (Object.hasOwnProperty.call(mod, k)) result[k] = mod[k]; result["default"] = mod; return result; }; Object.defineProperty(exports, "__esModule", { value: true }); const foo = __importStar(require("foo")); ``` As you see, `tsc` generated that `__importStar` helper function in compiled output. And it generates it per each file if you don't enable `"importHelpers": true`. Now with `importHelpers` enabled we get the following picture: ```ts // foo.ts (source code) import * as foo from "foo"; // --------------------------- // foo.js (compiled output) "use strict"; Object.defineProperty(exports, "__esModule", { value: true }); const tslib_1 = require("tslib"); const foo = tslib_1.__importStar(require("foo")); ``` It saves some bundle size, but I am not entirely sure wheter we want that. Discussions are welcome! Co-authored-by: Veetaha <[email protected]>
| * vscode: moved tslib to runtime dependencies and added \"importHelpers\": trueVeetaha2020-02-013-4/+4
| |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 09:09:03 +0100