aboutsummaryrefslogtreecommitdiff
path: root/xtask
Commit message (Collapse)AuthorAgeFilesLines
...
* Convert TODO to a FIXME as per matkladveetaha2020-05-121-1/+1
|
* Convert TODO to a Note(matklad)veetaha2020-05-121-1/+1
|
* Convert to TODOs to FIXMEs as per matkladveetaha2020-05-121-4/+2
|
* Revert "Remove MacroStmts as per edwin0cheng" (cc @edwin0cheng) and add a ↵veetaha2020-05-121-0/+13
| | | | | | | | | | fixme to document it. This reverts commit 7a49165f5d5c8186edd04f874eae8a98e39d3df6. MacroStmts ast node is not used by itself, but it pertains to SyntaxNodeKind MACRO_STMTS that is used by ra_paser, so even tho the node itself is not used, it is better to keep it with a FIXME to actually add a doc comment when it becomes useful.
* Add a doc comment on the difference between Name and NameRef ast nodesveetaha2020-05-121-1/+16
|
* Resolve TODO about macro 2.0 defveetaha2020-05-101-8/+4
|
* Fix typoveetaha2020-05-101-1/+1
|
* Carify on a semicolon in macro callveetaha2020-05-101-2/+7
|
* Resolve TODO about curly-braced constructions in expression statementveetaha2020-05-101-1/+3
|
* Remove TODO about Block since it was removedveetaha2020-05-101-3/+3
|
* Resolve todos about refs and empty statementsveetaha2020-05-101-5/+4
|
* Converted TODO about MacroItems to FIXME as per edwin0chengveetaha2020-05-101-8/+3
|
* Verified ConstArg example, waiting for response on what `=` sign pertains toveetaha2020-05-101-4/+3
|
* Correcy use tree and type args docsveetaha2020-05-101-5/+3
|
* Correct `use` cannot have type args as per flodieboldveetaha2020-05-101-1/+1
|
* Correct path docs and add colon2 token to Path ast nodeveetaha2020-05-101-12/+14
|
* Add example with const in TypeBound as per flodieboldveetaha2020-05-101-4/+2
|
* Remove todo comment about arg vs param difference as per clarification from ↵veetaha2020-05-101-4/+0
| | | | flodiebold
* Properly document const impl as per flodieboldveetaha2020-05-101-2/+2
|
* Remove on TypeAliasDef as per flodieboldveetaha2020-05-101-2/+1
|
* Remove MacroStmts as per edwin0chengveetaha2020-05-101-15/+0
|
* Add proper docs for TokenTree as per edwin0chengveetaha2020-05-101-1/+2
|
* Add ast docs to codegen scriptveetaha2020-05-102-17/+1515
|
* Add fixture doc commentTimo Freiberg2020-05-061-1/+0
|
* Simplify tidy testsAleksey Kladov2020-05-062-35/+33
|
* RegenerateAleksey Kladov2020-05-063-4/+4
|
* Rename AtomTextEdit -> IndelAleksey Kladov2020-05-051-1/+0
|
* Rename ImplItem to AssocItemEdwin Cheng2020-05-051-2/+2
|
* Add documents owner for ImplDef and SourceFileEdwin Cheng2020-05-031-2/+2
|
* Introduce EffectExprAleksey Kladov2020-05-022-12/+8
|
* Revert "Merge #4233"Aleksey Kladov2020-05-021-1/+4
| | | | | This reverts commit a5f2b16366f027ad60c58266a66eb7fbdcbda9f9, reversing changes made to c96b2180c1c4206a0a98c280b4d30897eb116336.
* Merge #4246bors[bot]2020-05-011-1/+1
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4246: Validate uses of self and super r=matklad a=djrenren This change follows on the validation of the `crate` keyword in paths. It verifies the following things: `super`: - May only be preceded by other `super` segments - If in a `UseItem` then all semantically preceding paths also consist only of `super` `self` - May only be the start of a path Just a note, a couple times while working on this I found myself really wanting a Visitor of some sort so that I could traverse descendants while skipping sub-trees that are unimportant. Iterators don't really work for this, so as you can see I reached for recursion. Considering paths are generally small a fancy debounced visitor probably isn't important but figured I'd say something in case we had something like this lying around and I wasn't using it. Co-authored-by: John Renner <[email protected]>
| * Validate uses of self and superJohn Renner2020-05-011-1/+1
| |
* | Remove dead code, which elaborately pretends to be aliveAleksey Kladov2020-04-301-4/+1
|/
* Fix a bunch of false-positives in join-linesAleksey Kladov2020-04-301-1/+1
|
* Allow to set env vars and pipe stdin via not_bashAleksey Kladov2020-04-302-92/+79
|
* Merge #4219bors[bot]2020-04-301-33/+67
|\ | | | | | | | | | | | | | | | | | | 4219: Avoid `rustup` invocation for non-rustup rust installation r=matklad a=oxalica Fix #4218 and #3243. Co-authored-by: oxalica <[email protected]>
| * Avoid `rustup` invocation for non-rustup rust installationoxalica2020-04-301-33/+67
| |
* | Merge #4178bors[bot]2020-04-301-1/+1
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4178: Validate the location of `crate` in paths r=matklad a=djrenren **This solution does not fully handle `use` statements. See below** This pull requests implements simple validation of usages of the `crate` keyword in `Path`s. Specifically it validates that: - If a `PathSegment` is starts with the `crate` keyword, it is also the first segment of the `Path` - All other usages of `crate` in `Path`s are considered errors. This aligns with `rustc`'s rules. Unlike rustc this implementation does not issue a special error message in the case of `::crate` but it does catch the error. Furthermore, this change does not cover all error cases. Specifically the following is not caught: ```rust use foo::{crate} ``` This is because this check is context sensitive. From an AST perspective, `crate` is the root of the `Path`. Only by inspecting the full `UseItem` do we see that it is not in fact the root. This problem becomes worse because `UseTree`s are allowed to be arbitrarily nested: ```rust use {crate, {{crate, foo::{crate}}} ``` So this is a hard problem to solve without essentially a breadth-first search. In a traditional compiler, I'd say this error is most easily found during the AST -> HIR conversion pass but within rust-analyzer I'm not sure where it belongs. Under the implementation in this PR, such errors are ignored so we're *more correct* just not *entirely correct*. Co-authored-by: John Renner <[email protected]>
| * Validate the location of `crate` in pathsJohn Renner2020-04-291-1/+1
| |
* | Use x86_64-unknown-linux-gnu for releasesLaurențiu Nicola2020-04-281-5/+3
|/
* Bump required rust to 1.43kjeremy2020-04-231-1/+1
|
* Group generated ast boilerplate apart from the interesting partveetaha2020-04-181-120/+130
|
* Refucktor codegenveetaha2020-04-181-6/+6
|
* tests: add more info about what failed in tidy testsBenjamin Coenen2020-04-171-3/+3
| | | | Signed-off-by: Benjamin Coenen <[email protected]>
* Change add_function assist to use todo!()Timo Freiberg2020-04-131-0/+1
|
* Align grammar for record patterns and literalsAleksey Kladov2020-04-111-1/+1
| | | | | | The grammar now looks like this [name_ref :] pat
* Change missing impl assist to use todo!() instead of unimplemented()Chris Hopman2020-04-101-1/+10
| | | | | | | | | | | | todo!() "Indicates unfinished code" (https://doc.rust-lang.org/std/macro.todo.html) Rust documentation provides further clarification: > The difference between unimplemented! and todo! is that while todo! > conveys an intent of implementing the functionality later and the > message is "not yet implemented", unimplemented! makes no such claims. todo!() seems more appropriate for assists that insert missing impls.
* SimplifyAleksey Kladov2020-04-101-1/+1
|
* Rename some tokensAleksey Kladov2020-04-102-13/+13
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-18 12:43:18 +0000