Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Don't require module docs for Features and Assists | Aleksey Kladov | 2020-05-31 | 1 | -2/+5 | |
| | | ||||||
* | | Specify actions | Aleksey Kladov | 2020-05-31 | 1 | -5/+20 | |
| | | ||||||
* | | Simplify | Aleksey Kladov | 2020-05-31 | 1 | -1/+1 | |
| | | ||||||
* | | Generate features docs from source | Aleksey Kladov | 2020-05-31 | 4 | -2/+83 | |
| | | ||||||
* | | Generalize | Aleksey Kladov | 2020-05-30 | 2 | -9/+21 | |
|/ | ||||||
* | minor | Aleksey Kladov | 2020-05-30 | 1 | -71/+73 | |
| | ||||||
* | Support raw_ref_op's raw reference operator | robojumper | 2020-05-28 | 1 | -1/+3 | |
| | ||||||
* | New assist: add turbo fish | Aleksey Kladov | 2020-05-19 | 1 | -0/+1 | |
| | ||||||
* | Convert TODO about ParamList used in closures to a FIXME | veetaha | 2020-05-12 | 1 | -2/+1 | |
| | | | | cc @matklad (you didn't comment on this one) | |||||
* | Remove an equals sign from `ConstArg` (this probably pertains only to ↵ | veetaha | 2020-05-12 | 1 | -3/+1 | |
| | | | | | | ConstParam) (As per matklad) | |||||
* | Remove a comment on NameRefToken as per matklad | veetaha | 2020-05-12 | 1 | -1/+1 | |
| | ||||||
* | Convert TODO to a FIXME as per matklad | veetaha | 2020-05-12 | 1 | -1/+1 | |
| | ||||||
* | Convert TODO to a Note(matklad) | veetaha | 2020-05-12 | 1 | -1/+1 | |
| | ||||||
* | Convert to TODOs to FIXMEs as per matklad | veetaha | 2020-05-12 | 1 | -4/+2 | |
| | ||||||
* | Revert "Remove MacroStmts as per edwin0cheng" (cc @edwin0cheng) and add a ↵ | veetaha | 2020-05-12 | 1 | -0/+13 | |
| | | | | | | | | | | fixme to document it. This reverts commit 7a49165f5d5c8186edd04f874eae8a98e39d3df6. MacroStmts ast node is not used by itself, but it pertains to SyntaxNodeKind MACRO_STMTS that is used by ra_paser, so even tho the node itself is not used, it is better to keep it with a FIXME to actually add a doc comment when it becomes useful. | |||||
* | Add a doc comment on the difference between Name and NameRef ast nodes | veetaha | 2020-05-12 | 1 | -1/+16 | |
| | ||||||
* | Resolve TODO about macro 2.0 def | veetaha | 2020-05-10 | 1 | -8/+4 | |
| | ||||||
* | Fix typo | veetaha | 2020-05-10 | 1 | -1/+1 | |
| | ||||||
* | Carify on a semicolon in macro call | veetaha | 2020-05-10 | 1 | -2/+7 | |
| | ||||||
* | Resolve TODO about curly-braced constructions in expression statement | veetaha | 2020-05-10 | 1 | -1/+3 | |
| | ||||||
* | Remove TODO about Block since it was removed | veetaha | 2020-05-10 | 1 | -3/+3 | |
| | ||||||
* | Resolve todos about refs and empty statements | veetaha | 2020-05-10 | 1 | -5/+4 | |
| | ||||||
* | Converted TODO about MacroItems to FIXME as per edwin0cheng | veetaha | 2020-05-10 | 1 | -8/+3 | |
| | ||||||
* | Verified ConstArg example, waiting for response on what `=` sign pertains to | veetaha | 2020-05-10 | 1 | -4/+3 | |
| | ||||||
* | Correcy use tree and type args docs | veetaha | 2020-05-10 | 1 | -5/+3 | |
| | ||||||
* | Correct `use` cannot have type args as per flodiebold | veetaha | 2020-05-10 | 1 | -1/+1 | |
| | ||||||
* | Correct path docs and add colon2 token to Path ast node | veetaha | 2020-05-10 | 1 | -12/+14 | |
| | ||||||
* | Add example with const in TypeBound as per flodiebold | veetaha | 2020-05-10 | 1 | -4/+2 | |
| | ||||||
* | Remove todo comment about arg vs param difference as per clarification from ↵ | veetaha | 2020-05-10 | 1 | -4/+0 | |
| | | | | flodiebold | |||||
* | Properly document const impl as per flodiebold | veetaha | 2020-05-10 | 1 | -2/+2 | |
| | ||||||
* | Remove on TypeAliasDef as per flodiebold | veetaha | 2020-05-10 | 1 | -2/+1 | |
| | ||||||
* | Remove MacroStmts as per edwin0cheng | veetaha | 2020-05-10 | 1 | -15/+0 | |
| | ||||||
* | Add proper docs for TokenTree as per edwin0cheng | veetaha | 2020-05-10 | 1 | -1/+2 | |
| | ||||||
* | Add ast docs to codegen script | veetaha | 2020-05-10 | 2 | -17/+1515 | |
| | ||||||
* | Add fixture doc comment | Timo Freiberg | 2020-05-06 | 1 | -1/+0 | |
| | ||||||
* | Simplify tidy tests | Aleksey Kladov | 2020-05-06 | 2 | -35/+33 | |
| | ||||||
* | Regenerate | Aleksey Kladov | 2020-05-06 | 3 | -4/+4 | |
| | ||||||
* | Rename AtomTextEdit -> Indel | Aleksey Kladov | 2020-05-05 | 1 | -1/+0 | |
| | ||||||
* | Rename ImplItem to AssocItem | Edwin Cheng | 2020-05-05 | 1 | -2/+2 | |
| | ||||||
* | Add documents owner for ImplDef and SourceFile | Edwin Cheng | 2020-05-03 | 1 | -2/+2 | |
| | ||||||
* | Introduce EffectExpr | Aleksey Kladov | 2020-05-02 | 2 | -12/+8 | |
| | ||||||
* | Revert "Merge #4233" | Aleksey Kladov | 2020-05-02 | 1 | -1/+4 | |
| | | | | | This reverts commit a5f2b16366f027ad60c58266a66eb7fbdcbda9f9, reversing changes made to c96b2180c1c4206a0a98c280b4d30897eb116336. | |||||
* | Merge #4246 | bors[bot] | 2020-05-01 | 1 | -1/+1 | |
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4246: Validate uses of self and super r=matklad a=djrenren This change follows on the validation of the `crate` keyword in paths. It verifies the following things: `super`: - May only be preceded by other `super` segments - If in a `UseItem` then all semantically preceding paths also consist only of `super` `self` - May only be the start of a path Just a note, a couple times while working on this I found myself really wanting a Visitor of some sort so that I could traverse descendants while skipping sub-trees that are unimportant. Iterators don't really work for this, so as you can see I reached for recursion. Considering paths are generally small a fancy debounced visitor probably isn't important but figured I'd say something in case we had something like this lying around and I wasn't using it. Co-authored-by: John Renner <[email protected]> | |||||
| * | Validate uses of self and super | John Renner | 2020-05-01 | 1 | -1/+1 | |
| | | ||||||
* | | Remove dead code, which elaborately pretends to be alive | Aleksey Kladov | 2020-04-30 | 1 | -4/+1 | |
|/ | ||||||
* | Fix a bunch of false-positives in join-lines | Aleksey Kladov | 2020-04-30 | 1 | -1/+1 | |
| | ||||||
* | Allow to set env vars and pipe stdin via not_bash | Aleksey Kladov | 2020-04-30 | 2 | -92/+79 | |
| | ||||||
* | Merge #4219 | bors[bot] | 2020-04-30 | 1 | -33/+67 | |
|\ | | | | | | | | | | | | | | | | | | | 4219: Avoid `rustup` invocation for non-rustup rust installation r=matklad a=oxalica Fix #4218 and #3243. Co-authored-by: oxalica <[email protected]> | |||||
| * | Avoid `rustup` invocation for non-rustup rust installation | oxalica | 2020-04-30 | 1 | -33/+67 | |
| | | ||||||
* | | Merge #4178 | bors[bot] | 2020-04-30 | 1 | -1/+1 | |
|\ \ | |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 4178: Validate the location of `crate` in paths r=matklad a=djrenren **This solution does not fully handle `use` statements. See below** This pull requests implements simple validation of usages of the `crate` keyword in `Path`s. Specifically it validates that: - If a `PathSegment` is starts with the `crate` keyword, it is also the first segment of the `Path` - All other usages of `crate` in `Path`s are considered errors. This aligns with `rustc`'s rules. Unlike rustc this implementation does not issue a special error message in the case of `::crate` but it does catch the error. Furthermore, this change does not cover all error cases. Specifically the following is not caught: ```rust use foo::{crate} ``` This is because this check is context sensitive. From an AST perspective, `crate` is the root of the `Path`. Only by inspecting the full `UseItem` do we see that it is not in fact the root. This problem becomes worse because `UseTree`s are allowed to be arbitrarily nested: ```rust use {crate, {{crate, foo::{crate}}} ``` So this is a hard problem to solve without essentially a breadth-first search. In a traditional compiler, I'd say this error is most easily found during the AST -> HIR conversion pass but within rust-analyzer I'm not sure where it belongs. Under the implementation in this PR, such errors are ignored so we're *more correct* just not *entirely correct*. Co-authored-by: John Renner <[email protected]> |