1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
|
use std::{
default::Default,
fmt, fs,
path::{Path, PathBuf},
str::FromStr,
};
use crate::{dirs, err::ConfigErr, utils, LintMap};
use clap::Parser;
use lib::{session::Version, LINTS};
use serde::{Deserialize, Serialize};
use vfs::ReadOnlyVfs;
#[derive(Parser, Debug)]
#[clap(version, author, about)]
pub struct Opts {
#[clap(subcommand)]
pub cmd: SubCommand,
}
#[derive(Parser, Debug)]
pub enum SubCommand {
/// Lints and suggestions for the nix programming language
Check(Check),
/// Find and fix issues raised by statix-check
Fix(Fix),
/// Fix exactly one issue at provided position
Single(Single),
/// Print detailed explanation for a lint warning
Explain(Explain),
/// Dump a sample config to stdout
Dump(Dump),
}
#[derive(Parser, Debug)]
pub struct Check {
/// File or directory to run check on
#[clap(default_value = ".", parse(from_os_str))]
target: PathBuf,
/// Globs of file patterns to skip
#[clap(short, long)]
ignore: Vec<String>,
/// Don't respect .gitignore files
#[clap(short, long)]
unrestricted: bool,
/// Output format.
/// Supported values: stderr, errfmt, json (on feature flag only)
#[clap(short = 'o', long, default_value_t, parse(try_from_str))]
pub format: OutFormat,
/// Path to statix.toml
#[clap(short = 'c', long = "config", default_value = "./statix.toml")]
pub conf_path: PathBuf,
/// Enable "streaming" mode, accept file on stdin, output diagnostics on stdout
#[clap(short, long = "stdin")]
pub streaming: bool,
}
impl Check {
pub fn vfs(&self) -> Result<ReadOnlyVfs, ConfigErr> {
if self.streaming {
use std::io::{self, BufRead};
let src = io::stdin()
.lock()
.lines()
.map(|l| l.unwrap())
.collect::<Vec<String>>()
.join("\n");
Ok(ReadOnlyVfs::singleton("<stdin>", src.as_bytes()))
} else {
let ignore = dirs::build_ignore_set(&self.ignore, &self.target, self.unrestricted)?;
let files = dirs::walk_nix_files(ignore, &self.target)?;
vfs(files.collect::<Vec<_>>())
}
}
}
#[derive(Parser, Debug)]
pub struct Fix {
/// File or directory to run fix on
#[clap(default_value = ".", parse(from_os_str))]
target: PathBuf,
/// Globs of file patterns to skip
#[clap(short, long)]
ignore: Vec<String>,
/// Don't respect .gitignore files
#[clap(short, long)]
unrestricted: bool,
/// Do not fix files in place, display a diff instead
#[clap(short, long = "dry-run")]
pub diff_only: bool,
/// Path to statix.toml
#[clap(short = 'c', long = "config", default_value = "./statix.toml")]
pub conf_path: PathBuf,
/// Enable "streaming" mode, accept file on stdin, output diagnostics on stdout
#[clap(short, long = "stdin")]
pub streaming: bool,
}
pub enum FixOut {
Diff,
Stream,
Write,
}
impl Fix {
pub fn vfs(&self) -> Result<ReadOnlyVfs, ConfigErr> {
if self.streaming {
use std::io::{self, BufRead};
let src = io::stdin()
.lock()
.lines()
.map(|l| l.unwrap())
.collect::<Vec<String>>()
.join("\n");
Ok(ReadOnlyVfs::singleton("<stdin>", src.as_bytes()))
} else {
let ignore = dirs::build_ignore_set(&self.ignore, &self.target, self.unrestricted)?;
let files = dirs::walk_nix_files(ignore, &self.target)?;
vfs(files.collect::<Vec<_>>())
}
}
// i need this ugly helper because clap's data model
// does not reflect what i have in mind
pub fn out(&self) -> FixOut {
if self.diff_only {
FixOut::Diff
} else if self.streaming {
FixOut::Stream
} else {
FixOut::Write
}
}
}
#[derive(Parser, Debug)]
pub struct Single {
/// File to run single-fix on
#[clap(parse(from_os_str))]
pub target: Option<PathBuf>,
/// Position to attempt a fix at
#[clap(short, long, parse(try_from_str = parse_line_col))]
pub position: (usize, usize),
/// Do not fix files in place, display a diff instead
#[clap(short, long = "dry-run")]
pub diff_only: bool,
/// Enable "streaming" mode, accept file on stdin, output diagnostics on stdout
#[clap(short, long = "stdin")]
pub streaming: bool,
/// Path to statix.toml
#[clap(short = 'c', long = "config", default_value = "./statix.toml")]
pub conf_path: PathBuf,
}
impl Single {
pub fn vfs(&self) -> Result<ReadOnlyVfs, ConfigErr> {
if self.streaming {
use std::io::{self, BufRead};
let src = io::stdin()
.lock()
.lines()
.map(|l| l.unwrap())
.collect::<Vec<String>>()
.join("\n");
Ok(ReadOnlyVfs::singleton("<stdin>", src.as_bytes()))
} else {
let src = std::fs::read_to_string(self.target.as_ref().unwrap())
.map_err(ConfigErr::InvalidPath)?;
Ok(ReadOnlyVfs::singleton("<stdin>", src.as_bytes()))
}
}
pub fn out(&self) -> FixOut {
if self.diff_only {
FixOut::Diff
} else if self.streaming {
FixOut::Stream
} else {
FixOut::Write
}
}
}
#[derive(Parser, Debug)]
pub struct Explain {
/// Warning code to explain
#[clap(parse(try_from_str = parse_warning_code))]
pub target: u32,
}
#[derive(Parser, Debug)]
pub struct Dump {}
#[derive(Debug, Copy, Clone)]
pub enum OutFormat {
#[cfg(feature = "json")]
Json,
Errfmt,
StdErr,
}
impl Default for OutFormat {
fn default() -> Self {
OutFormat::StdErr
}
}
impl fmt::Display for OutFormat {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(
f,
"{}",
match self {
#[cfg(feature = "json")]
Self::Json => "json",
Self::Errfmt => "errfmt",
Self::StdErr => "stderr",
}
)
}
}
impl FromStr for OutFormat {
type Err = &'static str;
fn from_str(value: &str) -> Result<Self, Self::Err> {
match value.to_ascii_lowercase().as_str() {
#[cfg(feature = "json")]
"json" => Ok(Self::Json),
#[cfg(not(feature = "json"))]
"json" => Err("statix was not compiled with the `json` feature flag"),
"errfmt" => Ok(Self::Errfmt),
"stderr" => Ok(Self::StdErr),
_ => Err("unknown output format, try: json, errfmt"),
}
}
}
#[derive(Serialize, Deserialize, Debug)]
pub struct ConfFile {
#[serde(default = "Vec::new")]
disabled: Vec<String>,
nix_version: Option<String>,
}
impl Default for ConfFile {
fn default() -> Self {
let disabled = vec![];
let nix_version = Some(utils::default_nix_version());
Self {
disabled,
nix_version,
}
}
}
impl ConfFile {
pub fn from_path<P: AsRef<Path>>(path: P) -> Result<Self, ConfigErr> {
let path = path.as_ref();
let config_file = fs::read_to_string(path).map_err(ConfigErr::InvalidPath)?;
(toml::de::from_str(&config_file)).map_err(ConfigErr::ConfFileParse)
}
pub fn discover<P: AsRef<Path>>(path: P) -> Result<Self, ConfigErr> {
let cannonical_path = fs::canonicalize(path.as_ref()).map_err(ConfigErr::InvalidPath)?;
for p in cannonical_path.ancestors() {
let statix_toml_path = p.with_file_name("statix.toml");
if statix_toml_path.exists() {
return Self::from_path(statix_toml_path);
};
}
Ok(Self::default())
}
pub fn dump(&self) -> String {
toml::ser::to_string_pretty(&self).unwrap()
}
pub fn lints(&self) -> LintMap {
utils::lint_map_of(
(&*LINTS)
.iter()
.filter(|l| !self.disabled.iter().any(|check| check == l.name()))
.cloned()
.collect::<Vec<_>>()
.as_slice(),
)
}
pub fn version(&self) -> Result<Version, ConfigErr> {
if let Some(v) = &self.nix_version {
v.parse::<Version>()
.map_err(|_| ConfigErr::ConfFileVersionParse(v.clone()))
} else if let Some(v) = utils::get_version_info()
.map(|o| o.parse::<Version>().ok())
.flatten()
{
Ok(v)
} else {
Ok(utils::default_nix_version().parse::<Version>().unwrap())
}
}
}
fn parse_line_col(src: &str) -> Result<(usize, usize), ConfigErr> {
let parts = src.split(',');
match parts.collect::<Vec<_>>().as_slice() {
[line, col] => {
let do_parse = |val: &str| {
val.parse::<usize>()
.map_err(|_| ConfigErr::InvalidPosition(src.to_owned()))
};
let l = do_parse(line)?;
let c = do_parse(col)?;
Ok((l, c))
}
_ => Err(ConfigErr::InvalidPosition(src.to_owned())),
}
}
fn parse_warning_code(src: &str) -> Result<u32, ConfigErr> {
let mut char_stream = src.chars();
let severity = char_stream
.next()
.ok_or_else(|| ConfigErr::InvalidWarningCode(src.to_owned()))?
.to_ascii_lowercase();
match severity {
'w' => char_stream
.collect::<String>()
.parse::<u32>()
.map_err(|_| ConfigErr::InvalidWarningCode(src.to_owned())),
_ => Ok(0),
}
}
fn vfs(files: Vec<PathBuf>) -> Result<ReadOnlyVfs, ConfigErr> {
let mut vfs = ReadOnlyVfs::default();
for file in files.iter() {
if let Ok(data) = fs::read_to_string(&file) {
let _id = vfs.alloc_file_id(&file);
vfs.set_file_contents(&file, data.as_bytes());
} else {
println!("`{}` contains non-utf8 content", file.display());
};
}
Ok(vfs)
}
|