1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
|
use std::ops::Not;
use crate::{session::SessionInfo, Metadata, Report, Rule, Suggestion};
use if_chain::if_chain;
use macros::lint;
use rnix::{
types::{EntryHolder, LetIn, TypedNode},
NodeOrToken, SyntaxElement, SyntaxKind,
};
/// ## What it does
/// Checks for `let-in` expressions which create no new bindings.
///
/// ## Why is this bad?
/// `let-in` expressions that create no new bindings are useless.
/// These are probably remnants from debugging or editing expressions.
///
/// ## Example
///
/// ```nix
/// let in pkgs.statix
/// ```
///
/// Preserve only the body of the `let-in` expression:
///
/// ```nix
/// pkgs.statix
/// ```
#[lint(
name = "empty_let_in",
note = "Useless let-in expression",
code = 2,
match_with = SyntaxKind::NODE_LET_IN
)]
struct EmptyLetIn;
impl Rule for EmptyLetIn {
fn validate(&self, node: &SyntaxElement, _sess: &SessionInfo) -> Option<Report> {
if_chain! {
if let NodeOrToken::Node(node) = node;
if let Some(let_in_expr) = LetIn::cast(node.clone());
let entries = let_in_expr.entries();
let inherits = let_in_expr.inherits();
if entries.count() == 0;
if inherits.count() == 0;
if let Some(body) = let_in_expr.body();
// ensure that the let-in-expr does not have comments
if node
.children_with_tokens()
.any(|el| el.kind() == SyntaxKind::TOKEN_COMMENT)
.not();
then {
let at = node.text_range();
let replacement = body;
let message = "This let-in expression has no entries";
Some(self.report().suggest(at, message, Suggestion::new(at, replacement)))
} else {
None
}
}
}
}
|
