1 files changed, 31 insertions, 11 deletions

diff --git a/src/readline.rs b/src/readline.rs
index d689f95..8906a4f 100644
--- a/src/readline.rs
+++ b/src/readline.rs
@@ -7,6 +7,7 @@ use rustyline::error::ReadlineError;
 use rustyline::highlight::Highlighter;
 use rustyline::hint::{Hinter, HistoryHinter};
 use rustyline::{Context, Editor, Helper};
+use rustyline::validate::Validator;
 
 use directories::ProjectDirs;
 
@@ -14,6 +15,7 @@ use regex::Regex;
 
 use crate::error::CalcError;
 use crate::eval_math_expression;
+use crate::lex::{CONSTANTS, FUNCTIONS};
 
 pub struct RLHelper {
     completer: FilenameCompleter,
@@ -51,20 +53,34 @@ impl Highlighter for LineHighlighter {
         let op = eval_math_expression(line, prev_ans);
         match op {
             Ok(_) => {
-                let constants = ["e", "pi"];
-                let functions = [
-                    "sin", "cos", "tan", "csc", "sec", "cot", "sinh", "cosh", "tanh", "ln", "log",
-                    "sqrt", "ceil", "floor", "rad", "deg", "abs", "asin", "acos", "atan", "acsc",
-                    "asec", "acot",
-                ];
+                let constants = CONSTANTS.keys();
+                let functions = FUNCTIONS.keys();
                 let ops = Regex::new(r"(?P<o>[\+-/\*%\^!])").unwrap();
                 let mut coloured: String = ops.replace_all(line, "\x1b[35m$o\x1b[0m").into();
 
-                for c in &constants {
-                    coloured = coloured.replace(c, &format!("\x1b[33m{}\x1b[0m", c));
+                for c in constants {
+                    // This regex consists of the following pieces:
+                    // * the constant (`o`) to highlight (to be substituted as `{}` via `format!`),
+                    //   e.g. `e`  or `pi`.
+                    // * (optionally) an ANSI escape-code (`\x1b\[35m`) that is used to highlight
+                    //   a binary operator (e.g. `+`/`-`/...). With this one it is ensured that
+                    //   binary operators are always correctly detected after a constant
+                    //   (see the next bullet-point for why that's needed).
+                    // * the following operator (e.g. `+`/`-`/...), a space or the end
+                    //   of the expression (to highlight e.g. `1+e` correctly). This is
+                    //   required to distinguish a constant in an expression from a function-call,
+                    //   e.g. `e+1` from `exp(1)`, without this matching logic, the `e` from
+                    //   `exp` would be improperly interpreted as constant.
+                    //
+                    // To make sure none of existing highlighting (i.e. highlighting
+                    // of binary operators that happens before) breaks, the escape-codes & operator
+                    // (called `r`) are appended after the highlighted constant.
+                    let re = Regex::new(format!("(?P<o>{})(?P<r>(\x1b\\[35m)?([\\+-/\\*%\\^! ]|$))", c).as_str()).unwrap();
+                    coloured = re.replace_all(&coloured, "\x1b[33m$o\x1b[0m$r").into();
                 }
-                for f in &functions {
-                    coloured = coloured.replace(f, &format!("\x1b[34m{}\x1b[0m", f));
+                for f in functions {
+                    let re = Regex::new(format!("(?P<o>{})(?P<r>(\\(|$))", f).as_str()).unwrap();
+                    coloured = re.replace_all(&coloured, "\x1b[34m$o\x1b[0m$r").into();
                 }
                 Owned(coloured)
             }
@@ -75,6 +91,7 @@ impl Highlighter for LineHighlighter {
 }
 
 impl Highlighter for RLHelper {
+    fn highlight_char(&self, _: &str, _: usize) -> bool { true }
     fn highlight_hint<'h>(&self, hint: &'h str) -> Cow<'h, str> {
         self.highlighter.highlight_hint(hint)
     }
@@ -96,11 +113,14 @@ impl Completer for RLHelper {
 }
 
 impl Hinter for RLHelper {
-    fn hint(&self, line: &str, a: usize, b: &Context) -> Option<String> {
+    type Hint = String;
+    fn hint(&self, line: &str, a: usize, b: &Context) -> Option<Self::Hint> {
         self.hinter.hint(line, a, b)
     }
 }
 
+impl Validator for RLHelper {}
+
 impl Helper for RLHelper {}
 
 pub fn create_readline() -> Editor<RLHelper> {