diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-11-02 13:08:53 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-11-02 13:08:53 +0000 |
| commit | 731b38fa3c1694648e6c8e60f61820f9783343eb (patch) | |
| tree | b3f4e94e8eac9bb24296aacafacb100930bee59e /.github/workflows | |
| parent | 6507877e7039d4517682a4fc232356662f509d81 (diff) | |
| parent | b6101184537b1165cfdd5fc473e04ad4c5b7bffa (diff) | |
Merge #6438
6438: Deny unreachable-pub r=matklad a=matklad
It's very useful when `pub` is equivalent to "this is crate's public
API", let's enforce this!
Ideally, we should enforce it for local `cargo test`, and only during
CI, but that needs https://github.com/rust-lang/cargo/issues/5034.
Co-authored-by: Aleksey Kladov <[email protected]>
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/ci.yaml | 2 | ||||
| -rw-r--r-- | .github/workflows/metrics.yaml | 2 | ||||
| -rw-r--r-- | .github/workflows/release.yaml | 2 | ||||
| -rw-r--r-- | .github/workflows/rustdoc.yaml | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 77f2e2e16..83b1d33a1 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml | |||
| @@ -12,7 +12,7 @@ env: | |||
| 12 | CARGO_NET_RETRY: 10 | 12 | CARGO_NET_RETRY: 10 |
| 13 | CI: 1 | 13 | CI: 1 |
| 14 | RUST_BACKTRACE: short | 14 | RUST_BACKTRACE: short |
| 15 | RUSTFLAGS: -D warnings | 15 | RUSTFLAGS: "-D warnings " # -W unreachable-pub" |
| 16 | RUSTUP_MAX_RETRIES: 10 | 16 | RUSTUP_MAX_RETRIES: 10 |
| 17 | 17 | ||
| 18 | jobs: | 18 | jobs: |
diff --git a/.github/workflows/metrics.yaml b/.github/workflows/metrics.yaml index ea780e875..72050a527 100644 --- a/.github/workflows/metrics.yaml +++ b/.github/workflows/metrics.yaml | |||
| @@ -7,7 +7,7 @@ on: | |||
| 7 | env: | 7 | env: |
| 8 | CARGO_INCREMENTAL: 0 | 8 | CARGO_INCREMENTAL: 0 |
| 9 | CARGO_NET_RETRY: 10 | 9 | CARGO_NET_RETRY: 10 |
| 10 | RUSTFLAGS: -D warnings | 10 | RUSTFLAGS: "-D warnings " # -W unreachable-pub" |
| 11 | RUSTUP_MAX_RETRIES: 10 | 11 | RUSTUP_MAX_RETRIES: 10 |
| 12 | 12 | ||
| 13 | jobs: | 13 | jobs: |
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index c1d56a8e0..fbefbd9eb 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml | |||
| @@ -11,7 +11,7 @@ on: | |||
| 11 | env: | 11 | env: |
| 12 | CARGO_INCREMENTAL: 0 | 12 | CARGO_INCREMENTAL: 0 |
| 13 | CARGO_NET_RETRY: 10 | 13 | CARGO_NET_RETRY: 10 |
| 14 | RUSTFLAGS: -D warnings | 14 | RUSTFLAGS: "-D warnings " # -W unreachable-pub" |
| 15 | RUSTUP_MAX_RETRIES: 10 | 15 | RUSTUP_MAX_RETRIES: 10 |
| 16 | 16 | ||
| 17 | jobs: | 17 | jobs: |
diff --git a/.github/workflows/rustdoc.yaml b/.github/workflows/rustdoc.yaml index cf4bca840..29ca3d3b2 100644 --- a/.github/workflows/rustdoc.yaml +++ b/.github/workflows/rustdoc.yaml | |||
| @@ -7,7 +7,7 @@ on: | |||
| 7 | env: | 7 | env: |
| 8 | CARGO_INCREMENTAL: 0 | 8 | CARGO_INCREMENTAL: 0 |
| 9 | CARGO_NET_RETRY: 10 | 9 | CARGO_NET_RETRY: 10 |
| 10 | RUSTFLAGS: -D warnings | 10 | RUSTFLAGS: "-D warnings " # -W unreachable-pub" |
| 11 | RUSTUP_MAX_RETRIES: 10 | 11 | RUSTUP_MAX_RETRIES: 10 |
| 12 | 12 | ||
| 13 | jobs: | 13 | jobs: |