diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-11-03 07:54:45 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2020-11-03 07:54:45 +0000 |
commit | 07c7f35effe1a4602ba02baf9ff67a4eb214818f (patch) | |
tree | 1cf4253dc23366dfd20f36285036d73b168a526e /.github | |
parent | 658e97a39e77bcb978697a66ddccd7e4b58990cf (diff) | |
parent | 8efe43245bc64ed27f88c333541b2cb7af2ce44c (diff) |
Merge #6430
6430: Move completions rendering into a separate module r=popzxc a=popzxc
This PR extracts rendering-related things from `Completions` structure to the new `render` module.
`render` module declares a `Render` structure (which is a generic renderer interface), `RenderContext` (interface for data/methods not required for completions generating, but required for rendering), and a bunch of smaller `*Render` structures which encapsulate logic behind rendering a certain item.
This is just a step in full separation direction, since the following this are still to be done:
- Move some data from `CompletionContext` to the `RenderContext`;
- Forbid any kind of rendering outside of `render` module;
- Extract score computing into a separate module.
This PR is already pretty big, so not to make it even harder to review I decided to split this process into several subsequent PRs.
Co-authored-by: Igor Aleksanov <[email protected]>
Diffstat (limited to '.github')
0 files changed, 0 insertions, 0 deletions