diff options
| author | Aleksey Kladov <[email protected]> | 2020-08-18 17:52:12 +0100 |
|---|---|---|
| committer | Aleksey Kladov <[email protected]> | 2020-08-18 17:52:12 +0100 |
| commit | 0c602bb963dc814caf48d7924002eb8aa3a6efd5 (patch) | |
| tree | 3afd7ca0ca87ad5a761372e633959356b804f205 | |
| parent | aa2def023e6b0aa8a68f4992423f566d435e55c6 (diff) | |
Encourage rebases more
| -rw-r--r-- | docs/dev/style.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/docs/dev/style.md b/docs/dev/style.md index 2454087e8..44f0956c2 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md | |||
| @@ -239,8 +239,9 @@ If the line is too long, you want to split the sentence in two :-) | |||
| 239 | # Commit Style | 239 | # Commit Style |
| 240 | 240 | ||
| 241 | We don't have specific rules around git history hygiene. | 241 | We don't have specific rules around git history hygiene. |
| 242 | Maintaining clean git history is encouraged, but not enforced. | 242 | Maintaining clean git history is strongly encouraged, but not enforced. |
| 243 | Use rebase workflow, it's OK to rewrite history during PR review process. | 243 | Use rebase workflow, it's OK to rewrite history during PR review process. |
| 244 | After you are happy with the state of the code, please use [interactive rebase](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History) to squash fixup commits. | ||
| 244 | 245 | ||
| 245 | Avoid @mentioning people in commit messages and pull request descriptions(they are added to commit message by bors). | 246 | Avoid @mentioning people in commit messages and pull request descriptions(they are added to commit message by bors). |
| 246 | Such messages create a lot of duplicate notification traffic during rebases. | 247 | Such messages create a lot of duplicate notification traffic during rebases. |