aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>2020-03-02 03:28:08 +0000
committerGitHub <[email protected]>2020-03-02 03:28:08 +0000
commit29bdd435fcd5c120863cfef17a327fc6fc278d1c (patch)
tree0daf7ab297b9fd468ba7201a2a8566fe1045e47e
parentb71fc18abe6e9572a3ca3ae18597fe05121095af (diff)
parent930b70c5d27b5a5a9273d6acb7e8d4c3a6c5db62 (diff)
Merge #3389
3389: Note vscode remote limitation when client install fails r=matklad a=not-much-io Just adding a note about the limitation referenced in https://github.com/rust-analyzer/rust-analyzer/issues/2522/ Considered checking if this message is relevant in the context (is this remote?) but decided against it because of return on investment - seeing how fast vscode iterates this limitation might just disappear in the near future. Also checked if there is a way to already do this which lead me to leaving a specifing question at https://github.com/microsoft/vscode-remote-release/issues/385 Co-authored-by: nmio <[email protected]>
-rw-r--r--xtask/src/install.rs3
1 files changed, 2 insertions, 1 deletions
diff --git a/xtask/src/install.rs b/xtask/src/install.rs
index 1d13b26da..f76467cac 100644
--- a/xtask/src/install.rs
+++ b/xtask/src/install.rs
@@ -122,7 +122,8 @@ fn install_client(ClientOpt::VsCode: ClientOpt) -> Result<()> {
122 if !installed_extensions.contains("rust-analyzer") { 122 if !installed_extensions.contains("rust-analyzer") {
123 bail!( 123 bail!(
124 "Could not install the Visual Studio Code extension. \ 124 "Could not install the Visual Studio Code extension. \
125 Please make sure you have at least NodeJS 12.x together with the latest version of VS Code installed and try again." 125 Please make sure you have at least NodeJS 12.x together with the latest version of VS Code installed and try again. \
126 Note that installing via xtask install does not work for VS Code Remote, instead you’ll need to install the .vsix manually."
126 ); 127 );
127 } 128 }
128 129