Merge #1247

1247: Remove collect r=matklad a=kjeremy

Might help with perf

Co-authored-by: Jeremy Kolb <[email protected]>

1 files changed, 1 insertions, 2 deletions

diff --git a/crates/ra_assists/src/add_missing_impl_members.rs b/crates/ra_assists/src/add_missing_impl_members.rs
index 17c2af899..23c01e747 100644
--- a/crates/ra_assists/src/add_missing_impl_members.rs
+++ b/crates/ra_assists/src/add_missing_impl_members.rs
@@ -53,11 +53,10 @@ fn add_missing_impl_members_inner(
             trait_def.syntax().descendants().find_map(ast::ItemList::cast)?.impl_items();
         let impl_items = impl_item_list.impl_items();
 
-        let trait_fns = trait_items.map(ImplItem::kind).filter_map(fn_def_opt).collect::<Vec<_>>();
+        let trait_fns = trait_items.map(ImplItem::kind).filter_map(fn_def_opt);
         let impl_fns = impl_items.map(ImplItem::kind).filter_map(fn_def_opt).collect::<Vec<_>>();
 
         trait_fns
-            .into_iter()
             .filter(|t| def_name(t).is_some())
             .filter(|t| match mode {
                 AddMissingImplMembersMode::DefaultMethodsOnly => t.body().is_some(),