Merge #1492

1492: Fix clippy::redundant_clone r=matklad a=sinkuu



Co-authored-by: Shotaro Yamada <[email protected]>

4 files changed, 5 insertions, 6 deletions

diff --git a/crates/ra_hir/src/code_model.rs b/crates/ra_hir/src/code_model.rs
index ed640d7fc..7d5d9b995 100644
--- a/crates/ra_hir/src/code_model.rs
+++ b/crates/ra_hir/src/code_model.rs
@@ -169,7 +169,7 @@ impl ModuleSource {
             (None, Some(item_id)) => {
                 let module = item_id.to_node(db);
                 assert!(module.item_list().is_some(), "expected inline module");
-                ModuleSource::Module(module.to_owned())
+                ModuleSource::Module(module)
             }
             (None, None) => panic!(),
         }
diff --git a/crates/ra_hir/src/ty/infer.rs b/crates/ra_hir/src/ty/infer.rs
index 9228dd314..f47f4c5de 100644
--- a/crates/ra_hir/src/ty/infer.rs
+++ b/crates/ra_hir/src/ty/infer.rs
@@ -895,8 +895,7 @@ impl<'a, D: HirDatabase> InferenceContext<'a, D> {
             }
             None => (receiver_ty, Ty::Unknown, None),
         };
-        let substs =
-            self.substs_for_method_call(def_generics.clone(), generic_args, &derefed_receiver_ty);
+        let substs = self.substs_for_method_call(def_generics, generic_args, &derefed_receiver_ty);
         let method_ty = method_ty.apply_substs(substs);
         let method_ty = self.insert_type_vars(method_ty);
         self.register_obligations_for_call(&method_ty);
diff --git a/crates/ra_ide_api/src/hover.rs b/crates/ra_ide_api/src/hover.rs
index 1edeb7579..48f1f49c9 100644
--- a/crates/ra_ide_api/src/hover.rs
+++ b/crates/ra_ide_api/src/hover.rs
@@ -88,7 +88,7 @@ impl HoverResult {
 fn hover_text(docs: Option<String>, desc: Option<String>) -> Option<String> {
     match (desc, docs) {
         (Some(desc), docs) => Some(rust_code_markup_with_doc(desc, docs)),
-        (None, Some(docs)) => Some(docs.to_string()),
+        (None, Some(docs)) => Some(docs),
         _ => None,
     }
 }
diff --git a/crates/ra_ide_api/src/mock_analysis.rs b/crates/ra_ide_api/src/mock_analysis.rs
index 4dbbd489a..132f6f875 100644
--- a/crates/ra_ide_api/src/mock_analysis.rs
+++ b/crates/ra_ide_api/src/mock_analysis.rs
@@ -62,13 +62,13 @@ impl MockAnalysis {
     pub fn add_file_with_position(&mut self, path: &str, text: &str) -> FilePosition {
         let (offset, text) = extract_offset(text);
         let file_id = FileId((self.files.len() + 1) as u32);
-        self.files.push((path.to_string(), text.to_string()));
+        self.files.push((path.to_string(), text));
         FilePosition { file_id, offset }
     }
     pub fn add_file_with_range(&mut self, path: &str, text: &str) -> FileRange {
         let (range, text) = extract_range(text);
         let file_id = FileId((self.files.len() + 1) as u32);
-        self.files.push((path.to_string(), text.to_string()));
+        self.files.push((path.to_string(), text));
         FileRange { file_id, range }
     }
     pub fn id_of(&self, path: &str) -> FileId {