Merge #3205

3205: vscode: migrate to tripple equals r=matklad a=Veetaha



Co-authored-by: Veetaha <[email protected]>

4 files changed, 10 insertions, 9 deletions

diff --git a/editors/code/.eslintrc.js b/editors/code/.eslintrc.js
index 5cda886ed..d494ebce8 100644
--- a/editors/code/.eslintrc.js
+++ b/editors/code/.eslintrc.js
@@ -12,6 +12,7 @@ module.exports = {
         "@typescript-eslint"
     ],
     "rules": {
+        "eqeqeq": ["error", "always", { "null": "ignore" }],
         "camelcase": ["error"],
         "@typescript-eslint/member-delimiter-style": [
             "error",
diff --git a/editors/code/package-lock.json b/editors/code/package-lock.json
index d7da47089..76ef2aae4 100644
--- a/editors/code/package-lock.json
+++ b/editors/code/package-lock.json
@@ -5,18 +5,18 @@
     "requires": true,
     "dependencies": {
         "@babel/code-frame": {
-            "version": "7.5.5",
-            "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.5.5.tgz",
-            "integrity": "sha512-27d4lZoomVyo51VegxI20xZPuSHusqbQag/ztrBC7wegWoQ1nLREPVSKSW8byhTlzTKyNE4ifaTA6lCp7JjpFw==",
+            "version": "7.8.3",
+            "resolved": "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.8.3.tgz",
+            "integrity": "sha512-a9gxpmdXtZEInkCSHUJDLHZVBgb1QS0jhss4cPP93EW7s+uC5bikET2twEF3KV+7rDblJcmNvTR7VJejqd2C2g==",
             "dev": true,
             "requires": {
-                "@babel/highlight": "^7.0.0"
+                "@babel/highlight": "^7.8.3"
             }
         },
         "@babel/highlight": {
-            "version": "7.5.0",
-            "resolved": "https://registry.npmjs.org/@babel/highlight/-/highlight-7.5.0.tgz",
-            "integrity": "sha512-7dV4eu9gBxoM0dAnj/BCFDW9LFU0zvTrkq0ugM7pnHEgguOEeOz1so2ZghEdzviYzQEED0r4EAgpsBChKy1TRQ==",
+            "version": "7.8.3",
+            "resolved": "https://registry.npmjs.org/@babel/highlight/-/highlight-7.8.3.tgz",
+            "integrity": "sha512-PX4y5xQUvy0fnEVHrYOarRPXVWafSjTW9T0Hab8gVIawpl2Sj0ORyrygANq+KjcNlSSTw0YCLSNA8OyZ1I4yEg==",
             "dev": true,
             "requires": {
                 "chalk": "^2.0.0",
diff --git a/editors/code/src/inlay_hints.ts b/editors/code/src/inlay_hints.ts
index 26705067a..641ec15c6 100644
--- a/editors/code/src/inlay_hints.ts
+++ b/editors/code/src/inlay_hints.ts
@@ -73,7 +73,7 @@ class HintsUpdater {
     async setEnabled(enabled: boolean): Promise<void> {
         console.log({ enabled, prev: this.enabled });
 
-        if (this.enabled == enabled) return;
+        if (this.enabled === enabled) return;
         this.enabled = enabled;
 
         if (this.enabled) {
diff --git a/editors/code/src/installation/server.ts b/editors/code/src/installation/server.ts
index 63ab104a1..750852921 100644
--- a/editors/code/src/installation/server.ts
+++ b/editors/code/src/installation/server.ts
@@ -42,7 +42,7 @@ export async function ensureServerBinary(source: null | BinarySource): Promise<n
 
             console.log("Installed version:", installedVersion, "required:", requiredVersion);
 
-            if (isBinaryAvailable(prebuiltBinaryPath) && installedVersion == requiredVersion) {
+            if (isBinaryAvailable(prebuiltBinaryPath) && installedVersion === requiredVersion) {
                 return prebuiltBinaryPath;
             }