aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAleksey Kladov <[email protected]>2019-01-08 18:59:55 +0000
committerAleksey Kladov <[email protected]>2019-01-08 19:03:13 +0000
commit921689b70da39160dd381e9716472827e36b03b8 (patch)
treea390d74ee5272a4a0070f5d4ea5281a04d4ba56a
parentf553837c1ca30a52bf5091689c21d3c3e3362395 (diff)
kill text utils
-rw-r--r--crates/ra_syntax/src/lib.rs4
-rw-r--r--crates/ra_syntax/src/reparsing.rs13
-rw-r--r--crates/ra_syntax/src/text_utils.rs8
-rw-r--r--crates/ra_text_edit/src/lib.rs7
4 files changed, 13 insertions, 19 deletions
diff --git a/crates/ra_syntax/src/lib.rs b/crates/ra_syntax/src/lib.rs
index a75e641ea..1dbfca91b 100644
--- a/crates/ra_syntax/src/lib.rs
+++ b/crates/ra_syntax/src/lib.rs
@@ -31,7 +31,6 @@ mod parser_impl;
31mod reparsing; 31mod reparsing;
32mod string_lexing; 32mod string_lexing;
33mod syntax_kinds; 33mod syntax_kinds;
34pub mod text_utils;
35/// Utilities for simple uses of the parser. 34/// Utilities for simple uses of the parser.
36pub mod utils; 35pub mod utils;
37mod validation; 36mod validation;
@@ -75,8 +74,7 @@ impl SourceFile {
75 .map(|(green_node, errors)| SourceFile::new(green_node, errors)) 74 .map(|(green_node, errors)| SourceFile::new(green_node, errors))
76 } 75 }
77 fn full_reparse(&self, edit: &AtomTextEdit) -> TreePtr<SourceFile> { 76 fn full_reparse(&self, edit: &AtomTextEdit) -> TreePtr<SourceFile> {
78 let text = 77 let text = edit.apply(self.syntax().text().to_string());
79 text_utils::replace_range(self.syntax().text().to_string(), edit.delete, &edit.insert);
80 SourceFile::parse(&text) 78 SourceFile::parse(&text)
81 } 79 }
82 pub fn errors(&self) -> Vec<SyntaxError> { 80 pub fn errors(&self) -> Vec<SyntaxError> {
diff --git a/crates/ra_syntax/src/reparsing.rs b/crates/ra_syntax/src/reparsing.rs
index d5d72e1f8..2f1de6b02 100644
--- a/crates/ra_syntax/src/reparsing.rs
+++ b/crates/ra_syntax/src/reparsing.rs
@@ -3,7 +3,6 @@ use crate::grammar;
3use crate::lexer::{tokenize, Token}; 3use crate::lexer::{tokenize, Token};
4use crate::parser_api::Parser; 4use crate::parser_api::Parser;
5use crate::parser_impl; 5use crate::parser_impl;
6use crate::text_utils::replace_range;
7use crate::yellow::{self, GreenNode, SyntaxError, SyntaxNode}; 6use crate::yellow::{self, GreenNode, SyntaxError, SyntaxNode};
8use crate::{SyntaxKind::*, TextRange, TextUnit}; 7use crate::{SyntaxKind::*, TextRange, TextUnit};
9use ra_text_edit::AtomTextEdit; 8use ra_text_edit::AtomTextEdit;
@@ -62,11 +61,8 @@ fn reparse_block<'node>(
62} 61}
63 62
64fn get_text_after_edit(node: &SyntaxNode, edit: &AtomTextEdit) -> String { 63fn get_text_after_edit(node: &SyntaxNode, edit: &AtomTextEdit) -> String {
65 replace_range( 64 let edit = AtomTextEdit::replace(edit.delete - node.range().start(), edit.insert.clone());
66 node.text().to_string(), 65 edit.apply(node.text().to_string())
67 edit.delete - node.range().start(),
68 &edit.insert,
69 )
70} 66}
71 67
72fn is_contextual_kw(text: &str) -> bool { 68fn is_contextual_kw(text: &str) -> bool {
@@ -156,7 +152,7 @@ fn merge_errors(
156mod tests { 152mod tests {
157 use test_utils::{extract_range, assert_eq_text}; 153 use test_utils::{extract_range, assert_eq_text};
158 154
159 use crate::{SourceFile, AstNode, text_utils::replace_range, utils::dump_tree}; 155 use crate::{SourceFile, AstNode, utils::dump_tree};
160 use super::*; 156 use super::*;
161 157
162 fn do_check<F>(before: &str, replace_with: &str, reparser: F) 158 fn do_check<F>(before: &str, replace_with: &str, reparser: F)
@@ -167,7 +163,8 @@ mod tests {
167 ) -> Option<(&'a SyntaxNode, GreenNode, Vec<SyntaxError>)>, 163 ) -> Option<(&'a SyntaxNode, GreenNode, Vec<SyntaxError>)>,
168 { 164 {
169 let (range, before) = extract_range(before); 165 let (range, before) = extract_range(before);
170 let after = replace_range(before.clone(), range, replace_with); 166 let edit = AtomTextEdit::replace(range, replace_with.to_owned());
167 let after = edit.apply(before.clone());
171 168
172 let fully_reparsed = SourceFile::parse(&after); 169 let fully_reparsed = SourceFile::parse(&after);
173 let incrementally_reparsed = { 170 let incrementally_reparsed = {
diff --git a/crates/ra_syntax/src/text_utils.rs b/crates/ra_syntax/src/text_utils.rs
deleted file mode 100644
index 7aaf4c223..000000000
--- a/crates/ra_syntax/src/text_utils.rs
+++ /dev/null
@@ -1,8 +0,0 @@
1use crate::TextRange;
2
3pub fn replace_range(mut text: String, range: TextRange, replace_with: &str) -> String {
4 let start = u32::from(range.start()) as usize;
5 let end = u32::from(range.end()) as usize;
6 text.replace_range(start..end, replace_with);
7 text
8}
diff --git a/crates/ra_text_edit/src/lib.rs b/crates/ra_text_edit/src/lib.rs
index 22f3fdc0c..fb693b3ae 100644
--- a/crates/ra_text_edit/src/lib.rs
+++ b/crates/ra_text_edit/src/lib.rs
@@ -28,4 +28,11 @@ impl AtomTextEdit {
28 pub fn insert(offset: TextUnit, text: String) -> AtomTextEdit { 28 pub fn insert(offset: TextUnit, text: String) -> AtomTextEdit {
29 AtomTextEdit::replace(TextRange::offset_len(offset, 0.into()), text) 29 AtomTextEdit::replace(TextRange::offset_len(offset, 0.into()), text)
30 } 30 }
31
32 pub fn apply(&self, mut text: String) -> String {
33 let start = u32::from(self.delete.start()) as usize;
34 let end = u32::from(self.delete.end()) as usize;
35 text.replace_range(start..end, &self.insert);
36 text
37 }
31} 38}