Merge #459

459: use real signature in completion r=matklad a=matklad



Co-authored-by: Aleksey Kladov <[email protected]>

1 files changed, 4 insertions, 6 deletions

diff --git a/crates/ra_analysis/src/completion/completion_item.rs b/crates/ra_analysis/src/completion/completion_item.rs
index cd4d529f9..a25b87bee 100644
--- a/crates/ra_analysis/src/completion/completion_item.rs
+++ b/crates/ra_analysis/src/completion/completion_item.rs
@@ -150,12 +150,10 @@ impl Builder {
     fn from_function(mut self, ctx: &CompletionContext, function: hir::Function) -> Builder {
         // If not an import, add parenthesis automatically.
         if ctx.use_item_syntax.is_none() {
-            if let Some(sig_info) = function.signature_info(ctx.db) {
-                if sig_info.params.is_empty() {
-                    self.snippet = Some(format!("{}()$0", self.label));
-                } else {
-                    self.snippet = Some(format!("{}($0)", self.label));
-                }
+            if function.signature(ctx.db).args().is_empty() {
+                self.snippet = Some(format!("{}()$0", self.label));
+            } else {
+                self.snippet = Some(format!("{}($0)", self.label));
             }
         }
         self.kind = Some(CompletionItemKind::Function);