aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAleksey Kladov <[email protected]>2021-04-13 12:13:50 +0100
committerAleksey Kladov <[email protected]>2021-04-19 14:08:49 +0100
commitad24310d4146df8174048d6537192f51b35a391b (patch)
tree96d632e864cc076438e673e4770ac2d402b185af
parent3f1a220f32220cd4a664ca1adac5eb36e9eb33b2 (diff)
internal: document review requesting etiquette
* don't feel obliged to quickly review every PR assigned to you * so that other folks can notify you about interesting PRs without thinking to much about creating additional work for you
-rw-r--r--docs/dev/README.md3
1 files changed, 3 insertions, 0 deletions
diff --git a/docs/dev/README.md b/docs/dev/README.md
index d0e6d29d8..360cedf88 100644
--- a/docs/dev/README.md
+++ b/docs/dev/README.md
@@ -242,6 +242,9 @@ There are three sets of people with extra permissions:
242 They also have direct commit access, but all changes should via bors queue. 242 They also have direct commit access, but all changes should via bors queue.
243 It's ok to self-approve if you think you know what you are doing! 243 It's ok to self-approve if you think you know what you are doing!
244 bors should automatically sync the permissions. 244 bors should automatically sync the permissions.
245 Feel free to assign any PR to a reviewer with the relevant expertise to bring the work to their attention.
246 Don't feel pressured to review assigned PRs though.
247 If you don't feel like reviewing for whatever reason, someone else will pick the review up!
245* [**triage**](https://github.com/orgs/rust-analyzer/teams/triage) team in the organization. 248* [**triage**](https://github.com/orgs/rust-analyzer/teams/triage) team in the organization.
246 This team can label and close issues. 249 This team can label and close issues.
247 250