diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-10-02 09:14:38 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-10-02 09:14:38 +0100 |
| commit | c01cd6e3ed0763f8e773c34dc76db0e39396133d (patch) | |
| tree | 15a8b6e9e44d2a29b19b1aecd86b7c39762a5d32 | |
| parent | e535489f03901ab94a89dd2de67f35714f0c3cfc (diff) | |
| parent | 0599e64bb296201b0aa5c637be34e28149d00e5d (diff) | |
Merge #6118
6118: Document Clippy strategy r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <[email protected]>
| -rw-r--r-- | docs/dev/style.md | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/docs/dev/style.md b/docs/dev/style.md index f0fdb5adc..fb407afcd 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md | |||
| @@ -371,3 +371,13 @@ After you are happy with the state of the code, please use [interactive rebase]( | |||
| 371 | 371 | ||
| 372 | Avoid @mentioning people in commit messages and pull request descriptions(they are added to commit message by bors). | 372 | Avoid @mentioning people in commit messages and pull request descriptions(they are added to commit message by bors). |
| 373 | Such messages create a lot of duplicate notification traffic during rebases. | 373 | Such messages create a lot of duplicate notification traffic during rebases. |
| 374 | |||
| 375 | # Clippy | ||
| 376 | |||
| 377 | We don't enforce Clippy. | ||
| 378 | A number of default lints have high false positive rate. | ||
| 379 | Selectively patching false-positives with `allow(clippy)` is considered worse than not using Clippy at all. | ||
| 380 | There's `cargo xtask lint` command which runs a subset of low-FPR lints. | ||
| 381 | Careful tweaking of `xtask lint` is welcome. | ||
| 382 | See also [rust-lang/clippy#5537](https://github.com/rust-lang/rust-clippy/issues/5537). | ||
| 383 | Of course, applying Clippy suggestions is welcome as long as they indeed improve the code. | ||