diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-04-22 09:29:01 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2021-04-22 09:29:01 +0100 |
commit | d1c9bd134df23aadc7d3fea7907269d841db9063 (patch) | |
tree | eb15ae619c8c3fe6d7110171395ec0993dc5657f | |
parent | 1f1a1ce4f57076be38d18f0a6defddb9c690bb1c (diff) | |
parent | 27073f4fc3e967339eb08b9c2b0899639dd6e618 (diff) |
Merge #8621
8621: feat: make sure nightly regressions don't break users r=lnicola a=matklad
Co-authored-by: Aleksey Kladov <[email protected]>
-rw-r--r-- | .github/ISSUE_TEMPLATE/critical_nightly_regression.md | 17 | ||||
-rw-r--r-- | docs/dev/README.md | 4 |
2 files changed, 21 insertions, 0 deletions
diff --git a/.github/ISSUE_TEMPLATE/critical_nightly_regression.md b/.github/ISSUE_TEMPLATE/critical_nightly_regression.md new file mode 100644 index 000000000..a0b1627d7 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/critical_nightly_regression.md | |||
@@ -0,0 +1,17 @@ | |||
1 | --- | ||
2 | name: Critical Nightly Regression | ||
3 | about: You are using nightly rust-analyzer and the latest version is unusable. | ||
4 | title: '' | ||
5 | labels: '' | ||
6 | assignees: 'matklad' | ||
7 | |||
8 | --- | ||
9 | |||
10 | <!-- | ||
11 | Troubleshooting guide: https://rust-analyzer.github.io/manual.html#troubleshooting | ||
12 | |||
13 | Please try to provide information which will help us to fix the issue faster. Minimal reproducible examples with few dependencies are especially lovely <3. | ||
14 | --> | ||
15 | |||
16 | This is a serious regression in nightly and it's important to fix it before the next release. | ||
17 | @matklad, please take a look. | ||
diff --git a/docs/dev/README.md b/docs/dev/README.md index 7e4488a41..b98ac4c0a 100644 --- a/docs/dev/README.md +++ b/docs/dev/README.md | |||
@@ -229,7 +229,11 @@ If it fails because of something that needs to be fixed, remove the release tag | |||
229 | Make sure to remove the new changelog post created when running `cargo xtask release` a second time. | 229 | Make sure to remove the new changelog post created when running `cargo xtask release` a second time. |
230 | 230 | ||
231 | We release "nightly" every night automatically and promote the latest nightly to "stable" manually, every week. | 231 | We release "nightly" every night automatically and promote the latest nightly to "stable" manually, every week. |
232 | |||
232 | We don't do "patch" releases, unless something truly egregious comes up. | 233 | We don't do "patch" releases, unless something truly egregious comes up. |
234 | To do a patch release, cherry-pick the fix on top of the current `release` branch and push the branch. | ||
235 | There's no need to write a changelog for a patch release, it's OK to include the notes about the fix into the next weekly one. | ||
236 | Note: we tag releases by dates, releasing a patch release on the same day should work (by overwriting a tag), but I am not 100% sure. | ||
233 | 237 | ||
234 | ## Permissions | 238 | ## Permissions |
235 | 239 | ||