aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbors[bot] <bors[bot]@users.noreply.github.com>2018-12-21 22:48:57 +0000
committerbors[bot] <bors[bot]@users.noreply.github.com>2018-12-21 22:48:57 +0000
commitf2581a4a2988aca2ac3953b7c5b3b0cbd4934eea (patch)
tree0d9fd0d5831921a2f950927910959275679c9165
parent184665ff9b7b64730ecf481c1914a74e7191a6dd (diff)
parent1dffbe5c379894add3097c005a8b0e4c70173e4a (diff)
Merge #318
318: Remove a completed and an unactionable todo r=matklad a=DJMcNab Co-authored-by: DJMcNab <[email protected]>
-rw-r--r--crates/ra_syntax/src/lexer.rs2
-rw-r--r--crates/ra_syntax/tests/test.rs12
2 files changed, 5 insertions, 9 deletions
diff --git a/crates/ra_syntax/src/lexer.rs b/crates/ra_syntax/src/lexer.rs
index f388da273..c6acd095e 100644
--- a/crates/ra_syntax/src/lexer.rs
+++ b/crates/ra_syntax/src/lexer.rs
@@ -160,7 +160,7 @@ fn next_token_inner(c: char, ptr: &mut Ptr) -> SyntaxKind {
160 // if we find one, then this is an invalid character literal 160 // if we find one, then this is an invalid character literal
161 if ptr.at('\'') { 161 if ptr.at('\'') {
162 ptr.bump(); 162 ptr.bump();
163 return CHAR; // TODO: error reporting 163 return CHAR;
164 } 164 }
165 LIFETIME 165 LIFETIME
166 } else { 166 } else {
diff --git a/crates/ra_syntax/tests/test.rs b/crates/ra_syntax/tests/test.rs
index 14ad836b5..4266864bd 100644
--- a/crates/ra_syntax/tests/test.rs
+++ b/crates/ra_syntax/tests/test.rs
@@ -65,14 +65,10 @@ fn self_hosting_parsing() {
65 for entry in walkdir::WalkDir::new(dir) 65 for entry in walkdir::WalkDir::new(dir)
66 .into_iter() 66 .into_iter()
67 .filter_entry(|entry| { 67 .filter_entry(|entry| {
68 !entry 68 !entry.path().components().any(|component| {
69 .path() 69 // Get all files which are not in the crates/ra_syntax/tests/data folder
70 .components() 70 component == Component::Normal(OsStr::new("data"))
71 // TODO: this more neatly 71 })
72 .any(|component| {
73 // Get all files which are not in the crates/ra_syntax/tests/data folder
74 component == Component::Normal(OsStr::new("data"))
75 })
76 }) 72 })
77 .map(|e| e.unwrap()) 73 .map(|e| e.unwrap())
78 .filter(|entry| { 74 .filter(|entry| {