better join-lines

3 files changed, 12 insertions, 1 deletions

diff --git a/code/src/extension.ts b/code/src/extension.ts
index 134459f30..df2109f50 100644
--- a/code/src/extension.ts
+++ b/code/src/extension.ts
@@ -50,6 +50,7 @@ export function activate(context: vscode.ExtensionContext) {
             let anchor = sel.isEmpty ? active : sel.anchor
             return new vscode.Selection(anchor, active)
         })
+        editor.revealRange(editor.selection)
     })
     registerCommand('libsyntax-rust.joinLines', async () => {
         let editor = vscode.window.activeTextEditor
diff --git a/crates/libeditor/src/typing.rs b/crates/libeditor/src/typing.rs
index 918f2325c..04021d164 100644
--- a/crates/libeditor/src/typing.rs
+++ b/crates/libeditor/src/typing.rs
@@ -72,9 +72,11 @@ fn remove_newline(
     if node.kind() == WHITESPACE && node_text.bytes().filter(|&b| b == b'\n').count() == 1 {
         match (node.prev_sibling(), node.next_sibling()) {
             (Some(prev), Some(next)) => {
+                let range = TextRange::from_to(prev.range().start(), node.range().end());
                 if prev.kind() == COMMA && (next.kind() == R_PAREN || next.kind() == R_BRACK) {
-                    let range = TextRange::from_to(prev.range().start(), node.range().end());
                     edit.delete(range);
+                } else if prev.kind() == COMMA && next.kind() == R_CURLY {
+                    edit.replace(range, " ".to_string());
                 } else {
                     edit.replace(
                         node.range(),
diff --git a/crates/libeditor/tests/test.rs b/crates/libeditor/tests/test.rs
index e5088ad27..858c6c4a6 100644
--- a/crates/libeditor/tests/test.rs
+++ b/crates/libeditor/tests/test.rs
@@ -224,6 +224,14 @@ fn foo() {
     foo(1, 2, 3)
 }
 ");
+
+    do_check(r"
+struct Foo <|>{
+    f: u32,
+}<|>
+", r"
+struct Foo { f: u32 }
+");
 }
 
 fn file(text: &str) -> ParsedFile {