aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorveetaha <[email protected]>2020-05-10 19:06:12 +0100
committerveetaha <[email protected]>2020-05-10 19:06:12 +0100
commitf5e2e02aa9864f5c929ff36f99cde5fd4be2544e (patch)
tree63b8b3acbeeea47cf64cabf889237a971861d212
parent71f2be968b128f489a2384b029ec3d678d085820 (diff)
Converted TODO about MacroItems to FIXME as per edwin0cheng
-rw-r--r--crates/ra_syntax/src/ast/generated/nodes.rs8
-rw-r--r--xtask/src/ast_src.rs11
2 files changed, 5 insertions, 14 deletions
diff --git a/crates/ra_syntax/src/ast/generated/nodes.rs b/crates/ra_syntax/src/ast/generated/nodes.rs
index 29345dc05..72977a3c6 100644
--- a/crates/ra_syntax/src/ast/generated/nodes.rs
+++ b/crates/ra_syntax/src/ast/generated/nodes.rs
@@ -2461,12 +2461,8 @@ impl ConstArg {
2461 pub fn eq_token(&self) -> Option<SyntaxToken> { support::token(&self.syntax, T![=]) } 2461 pub fn eq_token(&self) -> Option<SyntaxToken> { support::token(&self.syntax, T![=]) }
2462 pub fn block_expr(&self) -> Option<BlockExpr> { support::child(&self.syntax) } 2462 pub fn block_expr(&self) -> Option<BlockExpr> { support::child(&self.syntax) }
2463} 2463}
2464/// Macro items is a node that holds all the items created by expanding a macro. 2464/// FIXME: (@edwin0cheng) Remove it to use ItemList instead
2465/// 2465/// https://github.com/rust-analyzer/rust-analyzer/pull/4083#discussion_r422666243
2466/// ```
2467/// foo!(); // expands into some items -v
2468/// // ❰ struct Foo; impl Bar for Foo; ❱
2469/// ```
2470/// 2466///
2471/// [Reference](https://doc.rust-lang.org/reference/macros.html) 2467/// [Reference](https://doc.rust-lang.org/reference/macros.html)
2472#[derive(Debug, Clone, PartialEq, Eq, Hash)] 2468#[derive(Debug, Clone, PartialEq, Eq, Hash)]
diff --git a/xtask/src/ast_src.rs b/xtask/src/ast_src.rs
index 8999efc75..821b13378 100644
--- a/xtask/src/ast_src.rs
+++ b/xtask/src/ast_src.rs
@@ -1990,14 +1990,9 @@ pub(crate) const AST_SRC: AstSrc = AstSrc {
1990 /// [RFC](https://github.com/rust-lang/rfcs/blob/master/text/2000-const-generics.md#declaring-a-const-parameter) 1990 /// [RFC](https://github.com/rust-lang/rfcs/blob/master/text/2000-const-generics.md#declaring-a-const-parameter)
1991 struct ConstArg { Literal, T![=], BlockExpr } 1991 struct ConstArg { Literal, T![=], BlockExpr }
1992 1992
1993 // TODO: Idk what I am writing here, please don't believe these words. 1993
1994 // TODO: clarify @matklad @edwin0cheng 1994 /// FIXME: (@edwin0cheng) Remove it to use ItemList instead
1995 /// Macro items is a node that holds all the items created by expanding a macro. 1995 /// https://github.com/rust-analyzer/rust-analyzer/pull/4083#discussion_r422666243
1996 ///
1997 /// ```
1998 /// foo!(); // expands into some items -v
1999 /// // ❰ struct Foo; impl Bar for Foo; ❱
2000 /// ```
2001 /// 1996 ///
2002 /// [Reference](https://doc.rust-lang.org/reference/macros.html) 1997 /// [Reference](https://doc.rust-lang.org/reference/macros.html)
2003 struct MacroItems: ModuleItemOwner { } 1998 struct MacroItems: ModuleItemOwner { }