diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-11-17 17:50:08 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-11-17 17:50:08 +0000 |
| commit | 156f7d6963fb6b47570bfa457fdf51733a182054 (patch) | |
| tree | 1070543fd0be92d3ab720bc297962a5dad5e64e8 /crates/assists/src/utils.rs | |
| parent | f4b4f17662a7a1c80743b3108bb0da28b0fe47e5 (diff) | |
| parent | 16f0b2fdde2fba8f45cc18a8de11b45751c0f923 (diff) | |
Merge #6553
6553: Auto imports in completion r=matklad a=SomeoneToIgnore
Closes https://github.com/rust-analyzer/rust-analyzer/issues/1062 but does not handle the completion order, since it's a separate task for https://github.com/rust-analyzer/rust-analyzer/issues/4922 , https://github.com/rust-analyzer/rust-analyzer/issues/4922 and maybe something else.
2 quirks in the current implementation:
* traits are not auto imported during method completion
If I understand the current situation right, we cannot search for traits by a **part** of a method name, we need a full name with correct case to get a trait for it.
* VSCode (?) autocompletion is not as rigid as in Intellij Rust as you can notice on the animation.
Intellij is able to refresh the completions on every new symbol added, yet VS Code does not query the completions on every symbol for me.
With a few debug prints placed in RA, I've observed the following behaviour: after the first set of completion suggestions is received, next symbol input does not trigger a server request, if the completions contain this symbol.
When more symbols added, the existing completion suggestions are filtered out until none are left and only then, on the next symbol it queries for completions.
It seems like the only alternative to get an updated set of results is to manually retrigger it with Esc and Ctrl + Space.
Despite the eerie latter bullet, the completion seems to work pretty fine and fast nontheless, but if you have any ideas on how to make it more smooth, I'll gladly try it out.
Co-authored-by: Kirill Bulatov <[email protected]>
Diffstat (limited to 'crates/assists/src/utils.rs')
| -rw-r--r-- | crates/assists/src/utils.rs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/crates/assists/src/utils.rs b/crates/assists/src/utils.rs index d1a0a99b1..66c0cdd5f 100644 --- a/crates/assists/src/utils.rs +++ b/crates/assists/src/utils.rs | |||
| @@ -22,8 +22,7 @@ use crate::{ | |||
| 22 | ast_transform::{self, AstTransform, QualifyPaths, SubstituteTypeParams}, | 22 | ast_transform::{self, AstTransform, QualifyPaths, SubstituteTypeParams}, |
| 23 | }; | 23 | }; |
| 24 | 24 | ||
| 25 | pub use insert_use::MergeBehaviour; | 25 | pub use insert_use::{insert_use, ImportScope, MergeBehaviour}; |
| 26 | pub(crate) use insert_use::{insert_use, ImportScope}; | ||
| 27 | 26 | ||
| 28 | pub fn mod_path_to_ast(path: &hir::ModPath) -> ast::Path { | 27 | pub fn mod_path_to_ast(path: &hir::ModPath) -> ast::Path { |
| 29 | let mut segments = Vec::new(); | 28 | let mut segments = Vec::new(); |