aboutsummaryrefslogtreecommitdiff
path: root/crates/assists
diff options
context:
space:
mode:
authorBenjamin Coenen <[email protected]>2020-10-16 19:21:16 +0100
committerBenjamin Coenen <[email protected]>2020-10-16 19:21:16 +0100
commit62192cede3567df632c819656cc28ec3b2d2f5d6 (patch)
tree59c69e6e52dcc3e2a5840c1c7d433ccc25c59300 /crates/assists
parent89aad020c841111b931644e057cd64dcd3d55aca (diff)
replace_string_with_char #6252
Signed-off-by: Benjamin Coenen <[email protected]>
Diffstat (limited to 'crates/assists')
-rw-r--r--crates/assists/src/handlers/replace_string_with_char.rs127
-rw-r--r--crates/assists/src/lib.rs2
2 files changed, 129 insertions, 0 deletions
diff --git a/crates/assists/src/handlers/replace_string_with_char.rs b/crates/assists/src/handlers/replace_string_with_char.rs
new file mode 100644
index 000000000..3dc19431c
--- /dev/null
+++ b/crates/assists/src/handlers/replace_string_with_char.rs
@@ -0,0 +1,127 @@
1use std::borrow::Cow;
2
3use syntax::{
4 ast::{self, HasQuotes, HasStringValue},
5 AstToken,
6 SyntaxKind::{RAW_STRING, STRING},
7 TextRange, TextSize,
8};
9use test_utils::mark;
10
11use crate::{AssistContext, AssistId, AssistKind, Assists};
12
13// Assist: replace_string_with_char
14//
15// Replace string with char
16//
17// ```
18// fn main() {
19// find("{<|>");
20// }
21// ```
22// ->
23// ```
24// fn main() {
25// find('{');
26// }
27// ```
28pub(crate) fn replace_string_with_char(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
29 let token = ctx.find_token_at_offset(STRING).and_then(ast::String::cast)?;
30 let value = token.value()?;
31 let target = token.syntax().text_range();
32 if value.len() > 1 || value.is_empty() {
33 return None;
34 }
35
36 acc.add(
37 AssistId("replace_string_with_char", AssistKind::RefactorRewrite),
38 "Replace string with char",
39 target,
40 |edit| {
41 edit.replace(token.syntax().text_range(), format!("'{}'", value));
42 },
43 )
44}
45
46#[cfg(test)]
47mod tests {
48 use crate::tests::{check_assist, check_assist_not_applicable, check_assist_target};
49
50 use super::*;
51
52 #[test]
53 fn replace_string_with_char_target() {
54 check_assist_target(
55 replace_string_with_char,
56 r#"
57 fn f() {
58 let s = "<|>c";
59 }
60 "#,
61 r#""c""#,
62 );
63 }
64
65 #[test]
66 fn replace_string_with_char_assist() {
67 check_assist(
68 replace_string_with_char,
69 r#"
70 fn f() {
71 let s = "<|>c";
72 }
73 "#,
74 r##"
75 fn f() {
76 let s = 'c';
77 }
78 "##,
79 )
80 }
81
82 #[test]
83 fn replace_string_with_char_assist_not_applicable() {
84 check_assist_not_applicable(
85 replace_string_with_char,
86 r#"
87 fn f() {
88 let s = "<|>test";
89 }
90 "#,
91 )
92 }
93
94 #[test]
95 fn replace_string_with_char_works_inside_macros() {
96 check_assist(
97 replace_string_with_char,
98 r#"
99 fn f() {
100 format!(<|>"x", 92)
101 }
102 "#,
103 r##"
104 fn f() {
105 format!('x', 92)
106 }
107 "##,
108 )
109 }
110
111 #[test]
112 fn replace_string_with_char_works_func_args() {
113 check_assist(
114 replace_string_with_char,
115 r#"
116 fn f() {
117 find(<|>"x");
118 }
119 "#,
120 r##"
121 fn f() {
122 find('x');
123 }
124 "##,
125 )
126 }
127}
diff --git a/crates/assists/src/lib.rs b/crates/assists/src/lib.rs
index a2bec818c..2a98cccc0 100644
--- a/crates/assists/src/lib.rs
+++ b/crates/assists/src/lib.rs
@@ -159,6 +159,7 @@ mod handlers {
159 mod replace_impl_trait_with_generic; 159 mod replace_impl_trait_with_generic;
160 mod replace_let_with_if_let; 160 mod replace_let_with_if_let;
161 mod replace_qualified_name_with_use; 161 mod replace_qualified_name_with_use;
162 mod replace_string_with_char;
162 mod replace_unwrap_with_match; 163 mod replace_unwrap_with_match;
163 mod split_import; 164 mod split_import;
164 mod unwrap_block; 165 mod unwrap_block;
@@ -208,6 +209,7 @@ mod handlers {
208 replace_impl_trait_with_generic::replace_impl_trait_with_generic, 209 replace_impl_trait_with_generic::replace_impl_trait_with_generic,
209 replace_let_with_if_let::replace_let_with_if_let, 210 replace_let_with_if_let::replace_let_with_if_let,
210 replace_qualified_name_with_use::replace_qualified_name_with_use, 211 replace_qualified_name_with_use::replace_qualified_name_with_use,
212 replace_string_with_char::replace_string_with_char,
211 replace_unwrap_with_match::replace_unwrap_with_match, 213 replace_unwrap_with_match::replace_unwrap_with_match,
212 split_import::split_import, 214 split_import::split_import,
213 unwrap_block::unwrap_block, 215 unwrap_block::unwrap_block,