diff options
author | Igor Aleksanov <[email protected]> | 2020-11-03 07:33:13 +0000 |
---|---|---|
committer | Igor Aleksanov <[email protected]> | 2020-11-03 07:33:13 +0000 |
commit | 4d333ebb6372c135e5a723da899528cc22d07faa (patch) | |
tree | 7ab4c7f113a1686d7378502e2685d3529cb6f5ba /crates/completion/src/render/enum_variant.rs | |
parent | caf0fa20a7d895612ceee1948d6a9895e53bee4a (diff) |
Get rid of do-er antipattern
Diffstat (limited to 'crates/completion/src/render/enum_variant.rs')
-rw-r--r-- | crates/completion/src/render/enum_variant.rs | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/crates/completion/src/render/enum_variant.rs b/crates/completion/src/render/enum_variant.rs index f8b151318..fd412ed0e 100644 --- a/crates/completion/src/render/enum_variant.rs +++ b/crates/completion/src/render/enum_variant.rs | |||
@@ -9,8 +9,17 @@ use crate::{ | |||
9 | render::{builder_ext::Params, RenderContext}, | 9 | render::{builder_ext::Params, RenderContext}, |
10 | }; | 10 | }; |
11 | 11 | ||
12 | pub(crate) fn render_enum_variant<'a>( | ||
13 | ctx: RenderContext<'a>, | ||
14 | local_name: Option<String>, | ||
15 | variant: hir::EnumVariant, | ||
16 | path: Option<ModPath>, | ||
17 | ) -> CompletionItem { | ||
18 | EnumVariantRender::new(ctx, local_name, variant, path).render() | ||
19 | } | ||
20 | |||
12 | #[derive(Debug)] | 21 | #[derive(Debug)] |
13 | pub(crate) struct EnumVariantRender<'a> { | 22 | struct EnumVariantRender<'a> { |
14 | ctx: RenderContext<'a>, | 23 | ctx: RenderContext<'a>, |
15 | name: String, | 24 | name: String, |
16 | variant: hir::EnumVariant, | 25 | variant: hir::EnumVariant, |
@@ -21,7 +30,7 @@ pub(crate) struct EnumVariantRender<'a> { | |||
21 | } | 30 | } |
22 | 31 | ||
23 | impl<'a> EnumVariantRender<'a> { | 32 | impl<'a> EnumVariantRender<'a> { |
24 | pub(crate) fn new( | 33 | fn new( |
25 | ctx: RenderContext<'a>, | 34 | ctx: RenderContext<'a>, |
26 | local_name: Option<String>, | 35 | local_name: Option<String>, |
27 | variant: hir::EnumVariant, | 36 | variant: hir::EnumVariant, |
@@ -51,7 +60,7 @@ impl<'a> EnumVariantRender<'a> { | |||
51 | } | 60 | } |
52 | } | 61 | } |
53 | 62 | ||
54 | pub(crate) fn render(self) -> CompletionItem { | 63 | fn render(self) -> CompletionItem { |
55 | let mut builder = CompletionItem::new( | 64 | let mut builder = CompletionItem::new( |
56 | CompletionKind::Reference, | 65 | CompletionKind::Reference, |
57 | self.ctx.source_range(), | 66 | self.ctx.source_range(), |