diff options
author | Jonas Schievink <[email protected]> | 2020-09-17 17:50:30 +0100 |
---|---|---|
committer | Jonas Schievink <[email protected]> | 2020-09-27 18:41:54 +0100 |
commit | 1a28f30ba48254fae30a29c2f1053f653d5e687e (patch) | |
tree | 66fb358443e69ad81bd9a5331b205891a7d5acfc /crates/flycheck/src | |
parent | 662ed41ebcb1cd221b32be95d08b5bf5f10ae525 (diff) |
Spawn a flycheck instance per workspace
Diffstat (limited to 'crates/flycheck/src')
-rw-r--r-- | crates/flycheck/src/lib.rs | 24 |
1 files changed, 17 insertions, 7 deletions
diff --git a/crates/flycheck/src/lib.rs b/crates/flycheck/src/lib.rs index 16078d104..d982c5f29 100644 --- a/crates/flycheck/src/lib.rs +++ b/crates/flycheck/src/lib.rs | |||
@@ -59,11 +59,12 @@ pub struct FlycheckHandle { | |||
59 | 59 | ||
60 | impl FlycheckHandle { | 60 | impl FlycheckHandle { |
61 | pub fn spawn( | 61 | pub fn spawn( |
62 | id: usize, | ||
62 | sender: Box<dyn Fn(Message) + Send>, | 63 | sender: Box<dyn Fn(Message) + Send>, |
63 | config: FlycheckConfig, | 64 | config: FlycheckConfig, |
64 | workspace_root: PathBuf, | 65 | workspace_root: PathBuf, |
65 | ) -> FlycheckHandle { | 66 | ) -> FlycheckHandle { |
66 | let actor = FlycheckActor::new(sender, config, workspace_root); | 67 | let actor = FlycheckActor::new(id, sender, config, workspace_root); |
67 | let (sender, receiver) = unbounded::<Restart>(); | 68 | let (sender, receiver) = unbounded::<Restart>(); |
68 | let thread = jod_thread::spawn(move || actor.run(receiver)); | 69 | let thread = jod_thread::spawn(move || actor.run(receiver)); |
69 | FlycheckHandle { sender, thread } | 70 | FlycheckHandle { sender, thread } |
@@ -81,7 +82,11 @@ pub enum Message { | |||
81 | AddDiagnostic { workspace_root: PathBuf, diagnostic: Diagnostic }, | 82 | AddDiagnostic { workspace_root: PathBuf, diagnostic: Diagnostic }, |
82 | 83 | ||
83 | /// Request check progress notification to client | 84 | /// Request check progress notification to client |
84 | Progress(Progress), | 85 | Progress { |
86 | /// Flycheck instance ID | ||
87 | id: usize, | ||
88 | progress: Progress, | ||
89 | }, | ||
85 | } | 90 | } |
86 | 91 | ||
87 | #[derive(Debug)] | 92 | #[derive(Debug)] |
@@ -95,6 +100,7 @@ pub enum Progress { | |||
95 | struct Restart; | 100 | struct Restart; |
96 | 101 | ||
97 | struct FlycheckActor { | 102 | struct FlycheckActor { |
103 | id: usize, | ||
98 | sender: Box<dyn Fn(Message) + Send>, | 104 | sender: Box<dyn Fn(Message) + Send>, |
99 | config: FlycheckConfig, | 105 | config: FlycheckConfig, |
100 | workspace_root: PathBuf, | 106 | workspace_root: PathBuf, |
@@ -113,11 +119,15 @@ enum Event { | |||
113 | 119 | ||
114 | impl FlycheckActor { | 120 | impl FlycheckActor { |
115 | fn new( | 121 | fn new( |
122 | id: usize, | ||
116 | sender: Box<dyn Fn(Message) + Send>, | 123 | sender: Box<dyn Fn(Message) + Send>, |
117 | config: FlycheckConfig, | 124 | config: FlycheckConfig, |
118 | workspace_root: PathBuf, | 125 | workspace_root: PathBuf, |
119 | ) -> FlycheckActor { | 126 | ) -> FlycheckActor { |
120 | FlycheckActor { sender, config, workspace_root, cargo_handle: None } | 127 | FlycheckActor { id, sender, config, workspace_root, cargo_handle: None } |
128 | } | ||
129 | fn progress(&self, progress: Progress) { | ||
130 | self.send(Message::Progress { id: self.id, progress }); | ||
121 | } | 131 | } |
122 | fn next_event(&self, inbox: &Receiver<Restart>) -> Option<Event> { | 132 | fn next_event(&self, inbox: &Receiver<Restart>) -> Option<Event> { |
123 | let check_chan = self.cargo_handle.as_ref().map(|cargo| &cargo.receiver); | 133 | let check_chan = self.cargo_handle.as_ref().map(|cargo| &cargo.receiver); |
@@ -139,7 +149,7 @@ impl FlycheckActor { | |||
139 | command.stdout(Stdio::piped()).stderr(Stdio::null()).stdin(Stdio::null()); | 149 | command.stdout(Stdio::piped()).stderr(Stdio::null()).stdin(Stdio::null()); |
140 | if let Ok(child) = command.spawn().map(JodChild) { | 150 | if let Ok(child) = command.spawn().map(JodChild) { |
141 | self.cargo_handle = Some(CargoHandle::spawn(child)); | 151 | self.cargo_handle = Some(CargoHandle::spawn(child)); |
142 | self.send(Message::Progress(Progress::DidStart)); | 152 | self.progress(Progress::DidStart); |
143 | } | 153 | } |
144 | } | 154 | } |
145 | Event::CheckEvent(None) => { | 155 | Event::CheckEvent(None) => { |
@@ -153,11 +163,11 @@ impl FlycheckActor { | |||
153 | self.check_command() | 163 | self.check_command() |
154 | ) | 164 | ) |
155 | } | 165 | } |
156 | self.send(Message::Progress(Progress::DidFinish(res))); | 166 | self.progress(Progress::DidFinish(res)); |
157 | } | 167 | } |
158 | Event::CheckEvent(Some(message)) => match message { | 168 | Event::CheckEvent(Some(message)) => match message { |
159 | cargo_metadata::Message::CompilerArtifact(msg) => { | 169 | cargo_metadata::Message::CompilerArtifact(msg) => { |
160 | self.send(Message::Progress(Progress::DidCheckCrate(msg.target.name))); | 170 | self.progress(Progress::DidCheckCrate(msg.target.name)); |
161 | } | 171 | } |
162 | 172 | ||
163 | cargo_metadata::Message::CompilerMessage(msg) => { | 173 | cargo_metadata::Message::CompilerMessage(msg) => { |
@@ -179,7 +189,7 @@ impl FlycheckActor { | |||
179 | } | 189 | } |
180 | fn cancel_check_process(&mut self) { | 190 | fn cancel_check_process(&mut self) { |
181 | if self.cargo_handle.take().is_some() { | 191 | if self.cargo_handle.take().is_some() { |
182 | self.send(Message::Progress(Progress::DidCancel)); | 192 | self.progress(Progress::DidCancel); |
183 | } | 193 | } |
184 | } | 194 | } |
185 | fn check_command(&self) -> Command { | 195 | fn check_command(&self) -> Command { |