diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-03-09 11:58:48 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2021-03-09 11:58:48 +0000 |
commit | 21913d0fdb848445a908021dbcd4c3accf2ca0a5 (patch) | |
tree | 692581b2fcd0bcd7c382b593427dd39a47aa175c /crates/hir_def/src/adt.rs | |
parent | 5e0e5302d58cba5689e1a28c8e3b33f06a092546 (diff) | |
parent | 778deb38fe7e1bac8833934224d26f44eb80a6cc (diff) | |
parent | 867fdf8f03a25862c122614688c38f5e26e08e1f (diff) |
Merge #7873 #7933
7873: Consider unresolved qualifiers during flyimport r=matklad a=SomeoneToIgnore
Closes https://github.com/rust-analyzer/rust-analyzer/issues/7679
Takes unresolved qualifiers into account, providing better completions (or none, if the path is resolved or do not match).
Does not handle cases when both path qualifier and some trait has to be imported: there are many extra issues with those (such as overlapping imports, for instance) that will require large diffs to address.
Also does not do a fuzzy search on qualifier, that requires some adjustments in `import_map` for better queries and changes to the default replace range which also seems relatively big to include here.
![qualifier_completion](https://user-images.githubusercontent.com/2690773/110040808-0af8dc00-7d4c-11eb-83db-65af94e843bb.gif)
7933: Improve compilation speed r=matklad a=matklad
bors r+
🤖
Co-authored-by: Kirill Bulatov <[email protected]>
Co-authored-by: Aleksey Kladov <[email protected]>